Skip to content

FIx Create Term Definition algorithm for terms starting with @ #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasei opened this issue Oct 31, 2019 · 3 comments · Fixed by #190
Closed

FIx Create Term Definition algorithm for terms starting with @ #188

kasei opened this issue Oct 31, 2019 · 3 comments · Fixed by #190

Comments

@kasei
Copy link
Contributor

kasei commented Oct 31, 2019

Based on the recent resolution to ignore/warn on context terms starting with @, I believe the text in the Create Term Definition algorithm, step 5 needs to be updated so that it does not indicate that such terms cause processing to be aborted.

@gkellogg
Copy link
Member

Processing is aborted for that term so that no term definition will be created, which essentially causes them to be ignored. That is the intention.

Perhaps you think that saying "processing is aborted" would be tantamount to rejecting a Promise? That's not what is intended, only the processing of this term.

Perhaps if it said just to return?

@azaroth42
Copy link
Contributor

I also interpreted this to be abort completely (e.g. an error). Return would be clearer, IMO.

@kasei
Copy link
Contributor Author

kasei commented Oct 31, 2019

“Return” would be much clearer, given that “ processing is aborted” is the exact same terminology used when an actual error is encountered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants