Skip to content

#648 0027-out.jsonld: @graph and value objects #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2025
Merged

#648 0027-out.jsonld: @graph and value objects #650

merged 5 commits into from
Jun 4, 2025

Conversation

anatoly-scherbakov
Copy link
Contributor

No description provided.

@anatoly-scherbakov anatoly-scherbakov self-assigned this Apr 6, 2025
@anatoly-scherbakov anatoly-scherbakov linked an issue Apr 6, 2025 that may be closed by this pull request
Error in fromRdf/0027-out.jsonld #648
Closed
@BigBlueHat BigBlueHat requested a review from gkellogg April 9, 2025 16:37
@w3cbot w3cbot mentioned this pull request Apr 9, 2025
Closed
gkellogg
gkellogg requested changes Apr 22, 2025
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using native values, the RDF to Object Conversion algorithm still places these in value objects.

@gkellogg gkellogg requested review from niklasl and pchampin April 22, 2025 21:29
@gkellogg gkellogg moved this to Testing in JSON-LD Management Apr 22, 2025
@gkellogg gkellogg moved this from Testing to PRs in JSON-LD Management Apr 23, 2025
pchampin
pchampin requested changes May 8, 2025
View reviewed changes
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe tha the changes in fromRdf-manifest.html should be reverted.
Otherwise, I approve the changes to 0027-out.jsonld .

pchampin
pchampin approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in the HTML manifest is actually addressing an older inconsistency

@BigBlueHat BigBlueHat merged commit d2be7d2 into main Jun 4, 2025
1 check passed
@BigBlueHat BigBlueHat deleted the 648-error-in-fromrdf0027-outjsonld branch June 4, 2025 16:24
@w3cbot
Copy link

w3cbot commented Jun 4, 2025

This was discussed during the #json-ld meeting on 04 June 2025.

View the transcript

w3c/json-ld-api#650

<gb> Pull Request 650 #648 `0027-out.jsonld`: `@graph` and value objects (by anatoly-scherbakov) [test:missing-coverage]

anatoly-scherbakov: Someone said that `@graph` is not required, but it is in the test.
… Changes pchampin proposed have been taken care of.

pchampin: It doesn't seem that my suggestions were merged.
… This touches two files, and the changes seem unrelated.
… The HTML manifest has been changed.

anatoly-scherbakov: I don't know why the manifest changes are here.

gkellogg: the technology hasn't changed much, so this could be a bug in the manifest

anatoly-scherbakov: I'm going to try removing the changes to the HTML manifest.

pchampin: I was looking at the individual commits; I suspect that the change to the HTML manifest was not done by anatoly-scherbakov,

anatoly-scherbakov: Changes are done by the bot.

pchampin: The issue is that I don't see why there's a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkellogg gkellogg gkellogg approved these changes

@pchampin pchampin pchampin approved these changes

@niklasl niklasl Awaiting requested review from niklasl

Assignees

@anatoly-scherbakov anatoly-scherbakov

Labels
test:missing-coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in fromRdf/0027-out.jsonld
5 participants
@anatoly-scherbakov @w3cbot @gkellogg @pchampin @BigBlueHat