Skip to content

Typo in context validation algorithm step from grammar adjustment needs fixing #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dlongley opened this issue Jul 28, 2024 · 2 comments
Closed

Typo in context validation algorithm step from grammar adjustment needs fixing #299

dlongley opened this issue Jul 28, 2024 · 2 comments
Assignees
@msporny
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.

Comments

@dlongley
Copy link
Contributor

A slight mixup here in the grammar fixes, this step should read "or if" not "then if".

Originally posted by @dlongley in #291 (comment)
@msporny msporny added CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. labels Jul 28, 2024
@msporny msporny self-assigned this Jul 28, 2024
@TallTed
Copy link
Member

TallTed commented Jul 29, 2024 •
edited
Loading

Given that the above change is correct, then the fix is somewhat larger.

If |contextValue| does not deeply equal |expectedContext|, then if any subtree in
|result|.|document| contains an `@context` property or any URI in

should become

If |contextValue| does not deeply equal |expectedContext|, any subtree in
|result|.|document| contains an `@context` property, or any URI in

@msporny
Copy link
Member

msporny commented Jul 30, 2024

Purely editorial, fixed in c887ab2, closing.

@msporny msporny closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msporny @dlongley @TallTed