Skip to content

Commit ea657c8

Browse files
committed
docs: remove reference to Node 10 incompatibility
The bug in V8 that meant we couldn't instrument Node 10 was fixed and Node 10.4.0 shipped with a newer version of V8. This is the original bug report in Node: nodejs/node#20516 This is the PR that fixed it in Node: nodejs/node#19989 Closes elastic#448
1 parent 178f701 commit ea657c8

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

docs/compatibility.asciidoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ image::https://github.com/raw/nodejs/Release/master/schedule.png[]
1515
Some versions of Node.js contain bugs or issues that limit our ability to instrument them correctly.
1616
The following versions of Node.js are known to not be fully instrumented:
1717

18-
- v10.x - Async/Await in Node.js 10 is currently buggy and can therefore not be supported (https://github.com/nodejs/node/issues/20516:[nodejs/node#20516])
1918
- v8.1.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
2019
- v8.0.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
2120

test/instrumentation/modules/hapi.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ var semver = require('semver')
1313
// hapi 17+ requires Node.js 8.9.0 or higher
1414
if (semver.lt(process.version, '8.9.0') && semver.gte(pkg.version, '17.0.0')) process.exit()
1515

16-
// hapi does not work on Node.js 10 because of https://github.com/nodejs/node/issues/20516
17-
if (semver.gte(process.version, '10.0.0-rc')) process.exit()
18-
1916
var http = require('http')
2017

2118
var Hapi = require('hapi')

0 commit comments

Comments
 (0)