Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Encoding incompatibility in status transaction receipt #2401

Closed
alepc253 opened this issue Feb 20, 2019 · 1 comment · Fixed by #2413
Closed

Encoding incompatibility in status transaction receipt #2401

alepc253 opened this issue Feb 20, 2019 · 1 comment · Fixed by #2413
Labels
Bug Addressing a bug

Comments

@alepc253
Copy link

Expected behavior

Any transaction receipt with 0x01 as result should be considered successful.

Actual behavior

Function isValidReceiptStatus in TransactionReceiptValidator.js doesn't consider 0x01 as valid.

Steps to reproduce the behavior

This is seen in an RSK node but could happen in any node that manages this type of hexa encoding.

  1. Connect to an RSK network (i.e. https://public-node.testnet.rsk.co)
  2. Execute this command: web3.eth.getTransactionReceipt("0x3f7c81902c008538d5c9f39115a31e14036fc6b9110899239660f074203f3cc1")
  3. Check in the receipt that status value is 0x01

Therefore, if you apply isValidReceiptStatus from TransactionReceiptValidator.js to that receipt, it will throw an exception with this message: "Transaction has been reverted by the EVM".

Error Logs

Versions

Truffle v5.0.4 (core: 5.0.4)
Solidity v0.5.0 (solc-js)
Node v11.10.
web3.js 1.0.0-beta.46

@nivida nivida added the Bug Addressing a bug label Feb 20, 2019
@nivida
Copy link
Contributor

nivida commented Feb 20, 2019

Thanks for creating this issue! I will check and fix it asap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Addressing a bug
Projects
None yet
2 participants