From f5e3f3ee0384976f221092f1d16eefdaf5b9a11b Mon Sep 17 00:00:00 2001 From: Yue JIN <40021217+kingyue737@users.noreply.github.com> Date: Wed, 8 Nov 2023 17:43:58 +0800 Subject: [PATCH 1/2] fix: repoBaseUrl contains unexpected scope name --- src/stores/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/stores/index.ts b/src/stores/index.ts index a36eece..4945af6 100644 --- a/src/stores/index.ts +++ b/src/stores/index.ts @@ -4,10 +4,10 @@ import packageJson from '@root/package.json'; export const useCoreStore = defineStore('core', () => { const packageName = packageJson.name; - const storageName = 'vuetify-inline-fields'; + const storageName = packageName.split('/')[1]; // Links // - const repoBaseUrl = `https://github.com/webdevnerdstuff/${packageName}`; + const repoBaseUrl = `https://github.com/webdevnerdstuff/${storageName}`; const links = { changeLog: `${repoBaseUrl}/blob/main/CHANGELOG.md`, discord: 'https://discord.com/users/979453275369783346', From e8cb61dbd1d67aa8236dadf827b1a3b9ec94848c Mon Sep 17 00:00:00 2001 From: WebDevNerdStuff Date: Wed, 8 Nov 2023 10:51:24 -0800 Subject: [PATCH 2/2] fix: adjust variable names --- src/stores/index.ts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/stores/index.ts b/src/stores/index.ts index 4945af6..49cdcd6 100644 --- a/src/stores/index.ts +++ b/src/stores/index.ts @@ -3,18 +3,18 @@ import packageJson from '@root/package.json'; export const useCoreStore = defineStore('core', () => { - const packageName = packageJson.name; - const storageName = packageName.split('/')[1]; + const scopedPackageName = packageJson.name; + const packageName = scopedPackageName.split('/')[1]; // Links // - const repoBaseUrl = `https://github.com/webdevnerdstuff/${storageName}`; + const repoBaseUrl = `https://github.com/webdevnerdstuff/${packageName}`; const links = { changeLog: `${repoBaseUrl}/blob/main/CHANGELOG.md`, discord: 'https://discord.com/users/979453275369783346', github: repoBaseUrl, githubProfile: 'https://github.com/webdevnerdstuff', license: `${repoBaseUrl}/blob/main/LICENSE.md`, - npm: `https://www.npmjs.com/package/${packageName}`, + npm: `https://www.npmjs.com/package/${scopedPackageName}`, vue: 'https://vuejs.org/', vueUse: 'https://vueuse.org/', vuetify: 'https://vuetifyjs.com/', @@ -23,29 +23,29 @@ export const useCoreStore = defineStore('core', () => { const actions = { setLocalStorage(val: string): string { - const oldValue = localStorage.getItem(storageName); + const oldValue = localStorage.getItem(packageName); const newValue = val ?? oldValue; - localStorage.setItem(storageName, newValue); + localStorage.setItem(packageName, newValue); return newValue; }, setTheme(val: string): string { const themeName = val === 'dark' ? 'light' : 'dark'; - const currentTheme = localStorage.getItem(`${storageName}-theme`); + const currentTheme = localStorage.getItem(`${packageName}-theme`); const newTheme = themeName ?? currentTheme; - localStorage.setItem(`${storageName}-theme`, newTheme); + localStorage.setItem(`${packageName}-theme`, newTheme); return newTheme; }, }; const getters = { getLocalStorage: () => (): unknown => { - const value = localStorage.getItem(storageName); + const value = localStorage.getItem(packageName); return value; }, getTheme: () => { - const value = localStorage.getItem(`${storageName}-theme`); + const value = localStorage.getItem(`${packageName}-theme`); return value; }, }; @@ -56,6 +56,6 @@ export const useCoreStore = defineStore('core', () => { links, package: packageJson, pluginVersion: packageJson.version, - storageName, + packageName, }; });