Skip to content

Commit e2c4b0a

Browse files
committed
fix getInboxesFromNumber() method inbox parsing
1 parent 672d75a commit e2c4b0a

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

index.android.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ exports.getInboxes = function(options) {
88
order = options.order || constants.DEFAULT_SORT_ORDER;
99
return new Promise(function (resolve, reject) {
1010
var contentResolver = app.android.context.getContentResolver();
11-
var sortOrder = sort + " " + order + "" + ((max == constants.READ_ALL_SMS) ? "" : " limit " + max);
11+
var sortOrder = sort + " " + order + ((max == constants.READ_ALL_SMS) ? "" : " limit " + max);
1212
var columns = [ "_id", "thread_id", "address", "date", "date_sent", "body", "type" ];
1313
var cursor = contentResolver.query(android.net.Uri.parse(constants.CONTENT_SMS_INBOX_URI),
1414
columns, null, null, sortOrder);
@@ -37,16 +37,17 @@ exports.getInboxesFromNumber = function(fromNumber, options) {
3737
order = options.order || constants.DEFAULT_SORT_ORDER;
3838
return new Promise(function (resolve, reject) {
3939
var contentResolver = app.android.context.getContentResolver();
40-
var sortOrder = sort + " " + order + "" + ((max == constants.READ_ALL_SMS) ? "" : " limit " + max);
40+
var sortOrder = sort + " " + order + ((max == constants.READ_ALL_SMS) ? "" : " limit " + max);
41+
var columns = [ "_id", "thread_id", "address", "date", "date_sent", "body", "type" ];
4142
var cursor = contentResolver.query(android.net.Uri.parse(constants.CONTENT_SMS_INBOX_URI),
42-
null, "address=?", [fromNumber], sortOrder);
43+
columns, "address=?", [fromNumber], sortOrder);
4344
var count = cursor.getCount();
4445

4546
if (count > 0) {
4647
var smsList = [];
4748
while (cursor.moveToNext()) {
4849
var smsModel = new Sms();
49-
smsModel.initializeFromNative(cursor);
50+
smsModel.parseFromNative(cursor);
5051
smsList.push(smsModel);
5152
}
5253
cursor.close();
@@ -62,7 +63,7 @@ exports.getInboxesFromNumber = function(fromNumber, options) {
6263
exports.deleteSms = function(smsId) {
6364
return new Promise(function (resolve, reject) {
6465
var contentResolver = app.android.context.getContentResolver();
65-
resolve(contentResolver.delete(android.net.Uri.parse(constants.CONTENT_SMS_URI +"/"+ smsId), null, null));
66+
resolve(contentResolver.delete(android.net.Uri.parse(constants.CONTENT_SMS_URI + smsId), null, null));
6667
});
6768
}
6869

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-sms-inbox",
3-
"version": "1.0.3",
3+
"version": "1.0.4",
44
"description": "Read text messages in the android phone inbox using undocumented android api.",
55
"main": "index.js",
66
"nativescript": {

0 commit comments

Comments
 (0)