Skip to content

concat() assertions around input shape/datatypes seem invalid #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inexorabletash opened this issue Jan 10, 2024 · 0 comments · Fixed by #577
Closed

concat() assertions around input shape/datatypes seem invalid #503

inexorabletash opened this issue Jan 10, 2024 · 0 comments · Fixed by #577

Comments

@inexorabletash
Copy link
Contributor

The MLGraphBuilder concat(sequence<MLOperand> inputs, unsigned long axis) method has:

Assert: the shape, i.e. dimensions of each operand in inputs is the same, except on the dimension given by axis on which they are concatenated.
Assert: the dataType of each operand in inputs is the same.

Since the inputs are provided by script, these don't seem to be invariants. Are these intended to be validation steps instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants