Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

feat: add cache invalidation (options.?) #4

Closed
kmontag opened this issue Jun 2, 2017 · 2 comments
Closed

feat: add cache invalidation (options.?) #4

kmontag opened this issue Jun 2, 2017 · 2 comments

Comments

@kmontag
Copy link

kmontag commented Jun 2, 2017

As pointed out in #3, it's important to be able to expire the cache for this loader when the build environment changes. We're currently doing this by naming the cache directory based on a hash of relevant file content (NPM shrinkwrap, webpack config, etc) - however, over time this means developers accumulate a bunch of old cache directories, which need to be cleaned up manually or in a separate build step.

Would it be possible to add a cache-key option that, when changed, would cause the loader to just ignore and overwrite existing cache files?

@michael-ciniawsky michael-ciniawsky added this to the 1.1.0 milestone Jun 8, 2017
@michael-ciniawsky michael-ciniawsky changed the title Cache key option feat: add cache invalidation (options.?) Jun 8, 2017
@alexander-akait
Copy link
Member

@kmontag It is reduce performance, eslint, stylelint, babel-loader and etc don't removes old cache files, it is normal behavior

@sokra
Copy link
Member

sokra commented Aug 28, 2017

done

@sokra sokra closed this as completed Aug 28, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 1.1.0 Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants