-
-
Notifications
You must be signed in to change notification settings - Fork 51
Generate normalized cache context relative paths #54
Generate normalized cache context relative paths #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, let's add couple tests
@evilebottnawi tests added |
@evilebottnawi can we merge this? |
@mistic let's fix conflict and we can merge, also will be great fix CI before release new version |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 58.11% 58.47% +0.35%
==========================================
Files 2 2
Lines 117 118 +1
Branches 17 17
==========================================
+ Hits 68 69 +1
Misses 42 42
Partials 7 7
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 58.11% 58.47% +0.35%
==========================================
Files 2 2
Lines 117 118 +1
Branches 17 17
==========================================
+ Hits 68 69 +1
Misses 42 42
Partials 7 7
Continue to review full report at Codecov.
|
This PR enables the cache context relative paths generation to always use normalized posix paths instead of specific OS ones.
\CC @evilebottnawi