-
-
Notifications
You must be signed in to change notification settings - Fork 51
Fix usage with raw loader #69
Fix usage with raw loader #69
Conversation
Could it be better if we use https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings |
@malash thanks for the suggestions. I had them in account on the last changes 👍 |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 57.48% 58.13% +0.65%
==========================================
Files 2 2
Lines 127 129 +2
Branches 20 20
==========================================
+ Hits 73 75 +2
Misses 46 46
Partials 8 8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 57.48% 58.13% +0.65%
==========================================
Files 2 2
Lines 127 129 +2
Branches 20 20
==========================================
+ Hits 73 75 +2
Misses 46 46
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Just question: maybe we can use serialize-to-js
package, it is support many types and in theory loader can return non buffer and non string (yes it is not used in real life and not good idea, but it it possible)
@evilebottnawi it could have been an excellent solution but after trying that serializer-to-js I found performance penalties. I think we should stick with buffer-json for the time being 😃 |
That should fix #68
/CC @evilebottnawi