Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

Fix integration between prettier and eslint #85

Closed

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Jun 17, 2019

This fix the integration between prettier and eslint so we can have the prettier errors for source code included in the eslint report errors for a better debugging and development experience.

/CC @evilebottnawi

@mistic mistic requested a review from alexander-akait June 17, 2019 18:07
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is work for other types? Looks like no

@alexander-akait
Copy link
Member

Don't think this integration better because in future we will use remark for linting markdown and other linters, also eslint prettier it is new abstraction with own problems and bugs, better avoid this

@mistic
Copy link
Collaborator Author

mistic commented Jun 18, 2019

@evilebottnawi then do you know any way to show debug information about the prettier failures only using prettier? Just fail on a file without letting know where is the line with the problem (and actually what is the problem) is not a very good experience

@alexander-akait
Copy link
Member

hm, i am using prettier as plugin for IDE, maybe we should improve this in prettier or use --loglevel, agree, let's solve this in future, not high priority right now

@mistic
Copy link
Collaborator Author

mistic commented Jun 25, 2019

@evilebottnawi ok that makes sense, I will close this for now while you work on a fix in the prettier side.
Meanwhile I've opened a PR to help minimize the problems

@mistic mistic closed this Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants