test: don't use --runInBand and improve execution performance (#2005)

Author: hiroppy

globalSetupTest.js

@@ -0,0 +1,31 @@
+'use strict';
+
+// eslint-disable-next-line import/no-extraneous-dependencies
+const tcpPortUsed = require('tcp-port-used');
+const ports = require('./test/ports-map');
+
+async function validatePorts() {
+  const samples = [];
+
+  Object.entries(ports).forEach(([key, value]) => {
+    const arr = Array.isArray(value) ? value : [value];
+
+    arr.forEach((port) => {
+      const check = tcpPortUsed.check(port, 'localhost').then((inUse) => {
+        if (inUse) throw new Error(`${port} has already used. [${key}]`);
+      });
+
+      samples.push(check);
+    });
+  });
+
+  try {
+    await Promise.all(samples);
+  } catch (e) {
+    // eslint-disable-next-line no-console
+    console.error(e);
+    process.exit(1);
+  }
+}
+
+module.exports = validatePorts;

jest.config.js

@@ -7,4 +7,5 @@ module.exports = {
   moduleFileExtensions: ['js', 'json'],
   testMatch: ['**/test/**/*.test.js'],
   setupFilesAfterEnv: ['<rootDir>/setupTest.js'],
+  globalSetup: '<rootDir>/globalSetupTest.js',
 };

package-lock.json

@@ -19,7 +19,7 @@
     "lint": "npm-run-all -l -p \"lint:**\"",
     "commitlint": "commitlint --from=master",
     "security": "npm audit",
-    "test:only": "jest --runInBand",
+    "test:only": "jest",
     "test:coverage": "npm run test:only -- --coverage",
     "test:watch": "npm run test:coverage --watch",
     "test": "npm run test:coverage",
@@ -103,6 +103,7 @@
     "standard-version": "^6.0.1",
     "style-loader": "^0.23.1",
     "supertest": "^4.0.2",
+    "tcp-port-used": "^1.0.1",
     "url-loader": "^2.0.0",
     "webpack": "^4.33.0",
     "webpack-cli": "^3.3.3",

package.json

@@ -128,8 +128,10 @@ describe('CLI', () => {
     const cliPath = resolve(__dirname, '../../bin/webpack-dev-server.js');
     const examplePath = resolve(__dirname, '../../examples/cli/public');
 
-    const cp = execa('node', [cliPath], { cwd: examplePath });
-    const cp2 = execa('node', [cliPath], { cwd: examplePath });
+    const cp = execa('node', [cliPath, '--colors=false'], { cwd: examplePath });
+    const cp2 = execa('node', [cliPath, '--colors=false'], {
+      cwd: examplePath,
+    });
 
     const runtime = {
       cp: {

test/cli/cli.test.js

@@ -5,6 +5,7 @@ const express = require('express');
 const sockjs = require('sockjs');
 const SockJSClient = require('../../../client-src/clients/SockJSClient');
 const timer = require('../../helpers/timer');
+const port = require('../../ports-map').sockJSClient;
 
 describe('SockJSClient', () => {
   let socketServer;
@@ -15,7 +16,7 @@ describe('SockJSClient', () => {
     const app = new express();
 
     listeningApp = http.createServer(app);
-    listeningApp.listen(8080, 'localhost', () => {
+    listeningApp.listen(port, 'localhost', () => {
       socketServer = sockjs.createServer();
       socketServer.installHandlers(listeningApp, {
         prefix: '/sockjs-node',
@@ -33,7 +34,7 @@ describe('SockJSClient', () => {
         connection.close();
       });
 
-      const client = new SockJSClient('http://localhost:8080/sockjs-node');
+      const client = new SockJSClient(`http://localhost:${port}/sockjs-node`);
       const data = [];
 
       client.onOpen(() => {

test/client/clients/SockJSClient.test.js

@@ -9,6 +9,7 @@ const reloadConfig = require('../fixtures/reload-config/webpack.config');
 const { writeAsync } = require('../helpers/fs');
 const testServer = require('../helpers/test-server');
 const runBrowser = require('../helpers/run-browser');
+const port = require('../ports-map').Client;
 
 const cssFilePath = resolve(__dirname, '../fixtures/reload-config/main.css');
 
@@ -20,7 +21,7 @@ describe('reload', () => {
         'body { background-color: rgb(0, 0, 255); }'
       );
       const options = {
-        port: 9000,
+        port,
         host: '0.0.0.0',
         inline: true,
         hot: true,
@@ -41,7 +42,7 @@ describe('reload', () => {
         const { page, browser } = await runBrowser();
         let refreshed = false;
 
-        page.goto('http://localhost:9000/main');
+        page.goto(`http://localhost:${port}/main`);
         await page.waitForNavigation({ waitUntil: 'load' });
 
         {
@@ -59,7 +60,7 @@ describe('reload', () => {
           if (
             req.isNavigationRequest() &&
             req.frame() === page.mainFrame() &&
-            req.url() === 'http://localhost:9000/main'
+            req.url() === `http://localhost:${port}/main`
           ) {
             refreshed = true;
           }