-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Config validation - part one #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Working on this atm in the |
Released in |
@SpaceK33z With 2.1.0-beta.11 I'm getting the following error:
|
@aaronroberson, you need to update webpack to at minimum |
Good to know, thanks! |
@SpaceK33z as of beta.11 webpack-dev-server "fails" silently for me. I put fails in quotes because there's no real failure other than nothing happens—btw I'm using the node API. The config that goes into webpack() is roughly:
I can share the rest of my config, but ultimately beta.10 worked fine with this setup, and I can't discern if there's any specific config item that should be called out. I know that there's emphasis on providing validation, but I'l literally getting radio silence. Is there anything specific that's changed in this release that I'm not accounting for? |
@emilio-martinez weird. The biggest change is the config validation, but that should always throw an error if something is wrong. Could you try and remove as much options as possible with the error still occurring? The only wrong option I see here is Edit: please open a new issue if you're sure it's a new bug introduce in beta.11, that way I'll not forget it ;). |
@SpaceK33z hmm! Don't know where I got the |
webpack-dev-server should validate it's configuration against a schema, just like webpack v2 does.
The plan is to add a hook to webpack. This hook validates the given schema against the given options. So before we can start on this ticket, webpack needs to provide this hook for us.
Note that this should also work for webpack-dev-middleware.
Part two will be about having even more config validation; e.g. warning if a combination of options doesn't work.
The text was updated successfully, but these errors were encountered: