Skip to content

incomplete css-tutorial? #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomTasche opened this issue Apr 19, 2017 · 3 comments · Fixed by #1140
Closed

incomplete css-tutorial? #1131

TomTasche opened this issue Apr 19, 2017 · 3 comments · Fixed by #1140
Labels

Comments

@TomTasche
Copy link
Contributor

the tutorial for bundling css with webpack (https://webpack.js.org/guides/code-splitting-css/) does not quite tell you all the steps necessary in my opinion. is it just me and i'm missing the point of the tutorial?

if the point of the tutorial is indeed to bundle css so that it is rendered on the website, i'd like to submit a PR which adds the missing steps (installing and using the style-loader-module). thoughts?

@skipjack
Copy link
Collaborator

Could you expand on which parts are unclear or the steps you feel are missing?

I just re-read it, and it does look like some things could be elaborated, but it doesn't seem like any code is missing. Either way, we'd love for you to PR any improvements!

@simon04
Copy link
Collaborator

simon04 commented Apr 19, 2017

@TomTasche Has the incompleteness been resolved with #1130? If so, let's close this issue.

@TomTasche
Copy link
Contributor Author

#1130 did not add the information i was looking for, but it completed the information that is already available in the tutorial

what the tutorial is missing in my opinion is a mention of style-loader. the last paragraph uses extract-text-webpack-plugin which is fine, but before that it is necessary to use style-loader. otherwise css is merely bundled with javascript, but never applied to the website?

i will come up with a PR as suggested by @skipjack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants