Revert "allow disabling search params persistence in pagination"

This reverts commit 4ad131d.

These changes will be handled by
#2859 instead.

Author: emma-sg

frontend/src/components/ui/pagination.ts

@@ -59,12 +59,6 @@ export function calculatePages({
  * </btrix-pagination>
  * ```
  *
- * You can also disable pagination persistence via search params by setting name to `null`:
- * ```ts
- * <btrix-pagination .name=${null} totalCount="11" @page-change=${console.log}>
- * </btrix-pagination>
- * ```
- *
  * @fires page-change {PageChangeEvent}
  */
 @customElement("btrix-pagination")
@@ -163,7 +157,6 @@ export class Pagination extends LitElement {
   ];
 
   searchParams = new SearchParamsController(this, (params) => {
-    if (this.name == null) return;
     const page = parsePage(params.get(this.name));
     if (this._page !== page) {
       this.dispatchEvent(
@@ -192,7 +185,7 @@ export class Pagination extends LitElement {
   }
 
   @property({ type: String })
-  name: string | null = "page";
+  name = "page";
 
   @property({ type: Number })
   totalCount = 0;
@@ -221,15 +214,13 @@ export class Pagination extends LitElement {
       this.calculatePages();
     }
 
-    if (this.name != null) {
-      const parsedPage = parseFloat(
-        this.searchParams.searchParams.get(this.name) ?? "1",
-      );
-      if (parsedPage != this._page) {
-        const page = parsePage(this.searchParams.searchParams.get(this.name));
-        const constrainedPage = Math.max(1, Math.min(this.pages, page));
-        this.onPageChange(constrainedPage, { dispatch: false });
-      }
+    const parsedPage = parseFloat(
+      this.searchParams.searchParams.get(this.name) ?? "1",
+    );
+    if (parsedPage != this._page) {
+      const page = parsePage(this.searchParams.searchParams.get(this.name));
+      const constrainedPage = Math.max(1, Math.min(this.pages, page));
+      this.onPageChange(constrainedPage, { dispatch: false });
     }
 
     // if page is out of bounds, clamp it & dispatch an event to re-fetch data
@@ -418,14 +409,10 @@ export class Pagination extends LitElement {
   }
 
   private setPage(page: number) {
-    if (this.name != null) {
-      if (page === 1) {
-        this.searchParams.delete(this.name);
-      } else {
-        this.searchParams.set(this.name, page.toString());
-      }
+    if (page === 1) {
+      this.searchParams.delete(this.name);
     } else {
-      this._page = page;
+      this.searchParams.set(this.name, page.toString());
     }
   }