Skip to content

[Zig Master]: Update webui-dev/zig-webui and webui-dev/webui build.zig.zon with enum literal and fingerprint #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x546F6D opened this issue Mar 3, 2025 · 13 comments · Fixed by #86

Comments

@0x546F6D
Copy link

0x546F6D commented Mar 3, 2025

implement new package hash format

@jinzhongjia
Copy link
Member

I've noticed the pr, but considering this break change, this results in 0.13 and 0.14 being completely incompatible

@jinzhongjia
Copy link
Member

Maybe after 0.14 is released, zig-webui will also release a version
@AlbertShown what do you think?

@0x546F6D
Copy link
Author

0x546F6D commented Mar 3, 2025

I know.. I probably shouldnt have done my usual monday morning "zigup master" :)
What about a zig-master-dev branch?

@jinzhongjia
Copy link
Member

I understand your needs, do you want an available branch currently?

@jinzhongjia
Copy link
Member

In fact, I have completed the change in this pr. I'll push it.

@0x546F6D
Copy link
Author

0x546F6D commented Mar 3, 2025

I can always git clone and work locally until then, no worries. There are other repos in the same situation.

@jinzhongjia
Copy link
Member

Since the ci daily build will be tested against master, I noticed this problem yesterday

@jinzhongjia
Copy link
Member

@jinzhongjia
Copy link
Member

However, it should be noted that the name of the dependency is replaced by zig_webui

@0x546F6D
Copy link
Author

0x546F6D commented Mar 3, 2025

Thanks a lot, does the build.zig.zon of webui-dev/webui also need to be updated?

@jinzhongjia
Copy link
Member

At present, no need to do this. If need it, I will continue to push it to the branch

@jinzhongjia
Copy link
Member

0.14 has no issue, but has not tagged yet, so not sure if some changes will occur

@jinzhongjia jinzhongjia changed the title Update webui-dev/zig-webui and webui-dev/webui build.zig.zon with enum literal and fingerprint [Zig Master]: Update webui-dev/zig-webui and webui-dev/webui build.zig.zon with enum literal and fingerprint Mar 3, 2025
@AlbertShown
Copy link
Contributor

Maybe after 0.14 is released, zig-webui will also release a version @AlbertShown
what do you think?

Yes, sure, however, I'm working on the WebView CPU issue (Linux/macOS), after that we may even release the webui 2.5.0.

@jinzhongjia jinzhongjia linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants