Skip to content

Windows failing tests (apparent problem with relativeBase) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettz9 opened this issue Dec 30, 2015 · 3 comments
Closed

Windows failing tests (apparent problem with relativeBase) #48

brettz9 opened this issue Dec 30, 2015 · 3 comments

Comments

@brettz9
Copy link
Contributor

brettz9 commented Dec 30, 2015

4 tests are currently failing, all apparently related I think to relativeBase and file path joining being different on Windows.

 1) json-refs #findRefsAt should handle a valid location:
     Error: ENOENT: no such file or directory, open 'c:\wamp\www\json-refs\%5Cwamp%5Cwww%5Cjson-refs%5Ctest%5Cbrowser%5Cdocuments\test-document.yaml'
      at Error (native)

  2) json-refs #resolveRefs should return the expected value:
     Error: ENOENT: no such file or directory, open 'c:\wamp\www\json-refs\%5Cwamp%5Cwww%5Cjson-refs%5Ctest%5Cbrowser%5Cdocuments\nested\test-nested.yaml'
      at Error (native)

  3) json-refs #resolveRefs should support options.subDocPath:
     TypeError: obj must be an Array or an Object
      at findRefs (C:\wamp\www\json-refs\index.js:9:26900)
      at C:\wamp\www\json-refs\index.js:9:30571
      at run (C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\es6.promise.js:107:47)
      at C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\es6.promise.js:118:28
      at flush (C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\_microtask.js:19:5)

  4) json-refs #resolveRefsAt should return the expected value:
     TypeError: obj must be an Array or an Object
      at C:\wamp\www\json-refs\index.js:9:31385
      at run (C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\es6.promise.js:107:47)
      at C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\es6.promise.js:118:28
      at flush (C:\wamp\www\json-refs\node_modules\karma\node_modules\core-js\modules\_microtask.js:19:5)
@whitlockjc
Copy link
Owner

I'll give it a look.

@whitlockjc
Copy link
Owner

I'm working on this now. Once I get this fixed, I'll add a contributing guide (#49) and we should be ready for [email protected]. Do you mind checking that #47 was done as you wanted?

@whitlockjc
Copy link
Owner

I can confirm this on Windows. I'll get a fix out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants