Add a passthrough configuration system

chaomodus · chaomodus · commit 0ffed69aef7c · 2020-02-28T09:15:12.000-08:00
This is an implementation of the strategy 3 from this comment: netbox-community/netbox#1814 (comment) Bug: T209182 Change-Id: Icbdf212b7b1f9ff59fef4f5ecf64bfd9fdc41238 (cherry picked from commit 60c58bd) (cherry picked from commit b46b469)
diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
@@ -576,6 +576,13 @@ def _setting(name, default=None):
     '::1',
 )
 
+# Settings outside of the scope of the above, additional module settings, etc.
+# CAUTION: This unconditionally sets variables from the passthrough dictionary
+# in the settings module and could lead to odd results.
+passthrough_settings = getattr(configuration, 'PASSTHROUGH', {})
+settings_module = sys.modules[__name__]
+for key, value in passthrough_settings.items():
+    setattr(settings_module, key, value)
 
 #
 # NetBox internal settings

Original file line number	Diff line number	Diff line change
`@@ -576,6 +576,13 @@ def _setting(name, default=None):`
`576`	`576`	`'::1',`
`577`	`577`	`)`
`578`	`578`
	`579`	`+# Settings outside of the scope of the above, additional module settings, etc.`
	`580`	`+# CAUTION: This unconditionally sets variables from the passthrough dictionary`
	`581`	`+# in the settings module and could lead to odd results.`
	`582`	`+passthrough_settings = getattr(configuration, 'PASSTHROUGH', {})`
	`583`	`+settings_module = sys.modules[__name__]`
	`584`	`+for key, value in passthrough_settings.items():`
	`585`	`+ setattr(settings_module, key, value)`
`579`	`586`
`580`	`587`	`#`
`581`	`588`	`# NetBox internal settings`