diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
index dc25d841a..d09f2d1b4 100644
--- a/.github/ISSUE_TEMPLATE.md
+++ b/.github/ISSUE_TEMPLATE.md
@@ -79,11 +79,10 @@
Please fill in all the relevant fields by running these commands in terminal.
-->
-1. `npm ls react-scripts-ts` (if you haven’t ejected):
-2. `node -v`:
-3. `npm -v`:
-4. `yarn --version` (if you use Yarn):
-5. `npm ls react-scripts-ts` (if you haven’t ejected):
+1. `node -v`:
+2. `npm -v`:
+3. `yarn --version` (if you use Yarn):
+4. `npm ls react-scripts-ts` (if you haven’t ejected):
Then, specify:
diff --git a/.travis.yml b/.travis.yml
index 167fc436b..0ca362c23 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -16,12 +16,19 @@ cache:
install: true
script:
- 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi'
+ - 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
+ - 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
env:
global:
- USE_YARN=no
matrix:
- TEST_SUITE=simple
- - TEST_SUITE=install
+ - TEST_SUITE=installs
+ - TEST_SUITE=kitchensink
+matrix:
+ include:
+ - node_js: 0.10
+ env: TEST_SUITE=simple
# There's a weird Yarn/Lerna bug related to prerelease versions.
# TODO: reenable after we ship 1.0.
# - node_js: 6
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3a77c54b2..f233de0ad 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,270 @@
+## 1.0.17 (November 3, 2017)
+
+#### :nail_care: Enhancement
+
+* `react-scripts`
+
+ * [#3401](https://github.com/facebookincubator/create-react-app/pull/3401) Stop using a deprecated option. ([@gaearon](https://github.com/gaearon))
+
+#### :memo: Documentation
+
+* `react-scripts`
+
+ * [#3399](https://github.com/facebookincubator/create-react-app/pull/3399) Add link to VS Code troubleshooting guide. ([@auchenberg](https://github.com/auchenberg))
+ * [#3400](https://github.com/facebookincubator/create-react-app/pull/3400) Update VS Code debug configuration. ([@auchenberg](https://github.com/auchenberg))
+
+#### Committers: 3
+
+- Dan Abramov ([gaearon](https://github.com/gaearon))
+- Kenneth Auchenberg ([auchenberg](https://github.com/auchenberg))
+- Loren Sands-Ramshaw ([lorensr](https://github.com/lorensr))
+
+### Migrating from 1.0.16 to 1.0.17
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save --save-exact react-scripts@1.0.17
+```
+
+or
+
+```
+yarn add --exact react-scripts@1.0.17
+```
+
+## 1.0.16 (October 31, 2017) 🎃
+
+#### :bug: Bug Fix
+
+* `react-scripts`
+
+ * [#3374](https://github.com/facebookincubator/create-react-app/pull/3374) Set correct image type and sizes in `manifest.json`. ([@piotr-cz](https://github.com/piotr-cz))
+
+* `react-dev-utils`
+
+ * [#3368](https://github.com/facebookincubator/create-react-app/pull/3368) Fix a crash in development mode in older browsers. ([@felthy](https://github.com/felthy))
+
+#### Committers: 2
+
+- Dan Abramov ([gaearon](https://github.com/gaearon))
+- Piotr ([piotr-cz](https://github.com/piotr-cz))
+
+### Migrating from 1.0.15 to 1.0.16
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save --save-exact react-scripts@1.0.16
+```
+
+or
+
+```
+yarn add --exact react-scripts@1.0.16
+```
+
+## 1.0.15 (October 30, 2017)
+
+#### :bug: Bug Fix
+
+* `react-scripts`
+
+ * [#3287](https://github.com/facebookincubator/create-react-app/pull/3287) Fix favicon sizes value in the project manifest. ([@ryansully](https://github.com/ryansully))
+
+* `react-dev-utils`, `react-scripts`
+
+ * [#3230](https://github.com/facebookincubator/create-react-app/pull/3230) Fix watching for changes in `src/node_modules`. ([@xjlim](https://github.com/xjlim))
+
+#### :nail_care: Enhancement
+
+* `react-scripts`
+
+ * [#3239](https://github.com/facebookincubator/create-react-app/pull/3239) Allow importing `.mjs` files. ([@Timer](https://github.com/Timer))
+ * [#3340](https://github.com/facebookincubator/create-react-app/pull/3340) Polyfill `requestAnimationFrame` in test environment. ([@gaearon](https://github.com/gaearon))
+
+* `babel-preset-react-app`, `react-dev-utils`, `react-error-overlay`, `react-scripts`
+
+ * [#3342](https://github.com/facebookincubator/create-react-app/pull/3342) Bump dependencies. ([@gaearon](https://github.com/gaearon))
+
+* `react-dev-utils`, `react-error-overlay`
+
+ * [#3100](https://github.com/facebookincubator/create-react-app/pull/3100) Add click-to-open support for build errors. ([@tharakawj](https://github.com/tharakawj))
+
+* `create-react-app`
+
+ * [#3355](https://github.com/facebookincubator/create-react-app/pull/3355) Add preflight CWD check for npm to detect bad Windows setups. ([@gaearon](https://github.com/gaearon))
+
+#### :memo: Documentation
+
+* User Guide
+
+ * [#2957](https://github.com/facebookincubator/create-react-app/pull/2957) Use `npm-run-all` to build Sass and JS. ([@shime](https://github.com/shime))
+ * [#3108](https://github.com/facebookincubator/create-react-app/pull/3108) Update the Service Worker opt-out documentation. ([@captDaylight](https://github.com/captDaylight))
+ * [#3286](https://github.com/facebookincubator/create-react-app/pull/3286) Add documentation for Enzyme 3 integration. ([@ryansully](https://github.com/ryansully))
+ * [#3328](https://github.com/facebookincubator/create-react-app/pull/3328) Recommend react-snap as an alternative to react-snapshot. ([@aaronshaf](https://github.com/aaronshaf))
+ * [#3279](https://github.com/facebookincubator/create-react-app/pull/3279) Add jest coverage configuration docs. ([@mattphillips](https://github.com/mattphillips))
+ * [#3303](https://github.com/facebookincubator/create-react-app/pull/3303) Update link to Jest Expect docs. ([@jbranchaud](https://github.com/jbranchaud))
+ * [#3289](https://github.com/facebookincubator/create-react-app/pull/3289) Fix dead link to Jest "expect" docs. ([@alexkrolick](https://github.com/alexkrolick))
+ * [#3265](https://github.com/facebookincubator/create-react-app/pull/3265) Add external links to deployment services. ([@aericson](https://github.com/aericson))
+ * [#3075](https://github.com/facebookincubator/create-react-app/pull/3075) Minor docs change to highlight dev proxy behaviour. ([@davidjb](https://github.com/davidjb))
+ * [#3185](https://github.com/facebookincubator/create-react-app/pull/3185) Correct manual proxy documentation. ([@robertpanzer](https://github.com/robertpanzer))
+
+* README
+
+ * [#3227](https://github.com/facebookincubator/create-react-app/pull/3227) Fix package management link in README for issue #3218. ([@nishina555](https://github.com/nishina555))
+ * [#3211](https://github.com/facebookincubator/create-react-app/pull/3211) Improve grammar in README. ([@Mohamed3on](https://github.com/Mohamed3on))
+
+#### :house: Internal
+
+* Other
+
+ * [#3345](https://github.com/facebookincubator/create-react-app/pull/3345) Stop using `npm link` in tests. ([@Timer](https://github.com/Timer))
+
+* `react-error-overlay`
+
+ * [#3122](https://github.com/facebookincubator/create-react-app/pull/3122) Fix for add .gitattributes file #3080. ([@ijajmulani](https://github.com/ijajmulani))
+ * [#3267](https://github.com/facebookincubator/create-react-app/pull/3267) Use production React version for bundled overlay. ([@Timer](https://github.com/Timer))
+ * [#3264](https://github.com/facebookincubator/create-react-app/pull/3264) Add warning when using `react-error-overlay` in production. ([@Timer](https://github.com/Timer))
+ * [#3263](https://github.com/facebookincubator/create-react-app/pull/3263) `react-error-overlay` has no dependencies now (it's bundled). ([@Timer](https://github.com/Timer))
+ * [#3142](https://github.com/facebookincubator/create-react-app/pull/3142) Make error overlay run in the context of the iframe. ([@tharakawj](https://github.com/tharakawj))
+
+* `react-scripts`
+
+ * [#3150](https://github.com/facebookincubator/create-react-app/pull/3150) Remove an useless negation in `registerServiceWorker.js`. ([@dunglas](https://github.com/dunglas))
+ * [#3158](https://github.com/facebookincubator/create-react-app/pull/3158) Remove `output.path` from dev webpack config. ([@nikolas](https://github.com/nikolas))
+ * [#3281](https://github.com/facebookincubator/create-react-app/pull/3281) Add a workaround for Uglify incompatiblity with Safari 10.0 in the future. ([@satyavh](https://github.com/satyavh))
+ * [#3146](https://github.com/facebookincubator/create-react-app/pull/3146) Fix `reason-react` support. ([@lpalmes](https://github.com/lpalmes))
+ * [#3236](https://github.com/facebookincubator/create-react-app/pull/3236) Update `style-loader` and disable inclusion of its HMR code in builds. ([@insin](https://github.com/insin))
+ * [#3246](https://github.com/facebookincubator/create-react-app/pull/3246) Update `url-loader` to 0.6.2 for mime ReDoS vulnerability. ([@d3viant0ne](https://github.com/d3viant0ne))
+ * [#2914](https://github.com/facebookincubator/create-react-app/pull/2914) `<!doctype html>` -> `<!DOCTYPE html>`. ([@Hurtak](https://github.com/Hurtak))
+
+#### Committers: 24
+
+- Aaron Shafovaloff ([aaronshaf](https://github.com/aaronshaf))
+- Alex ([alexkrolick](https://github.com/alexkrolick))
+- André Ericson ([aericson](https://github.com/aericson))
+- Dan Abramov ([gaearon](https://github.com/gaearon))
+- David Beitey ([davidjb](https://github.com/davidjb))
+- Hrvoje Šimić ([shime](https://github.com/shime))
+- IJAJ MULANI ([ijajmulani](https://github.com/ijajmulani))
+- Joe Haddad ([Timer](https://github.com/Timer))
+- Joe Lim ([xjlim](https://github.com/xjlim))
+- Jonny Buchanan ([insin](https://github.com/insin))
+- Josh Branchaud ([jbranchaud](https://github.com/jbranchaud))
+- Joshua Wiens ([d3viant0ne](https://github.com/d3viant0ne))
+- Kévin Dunglas ([dunglas](https://github.com/dunglas))
+- Lorenzo Palmes ([lpalmes](https://github.com/lpalmes))
+- Matt Phillips ([mattphillips](https://github.com/mattphillips))
+- Mohamed Oun ([Mohamed3on](https://github.com/Mohamed3on))
+- Nik Nyby ([nikolas](https://github.com/nikolas))
+- Petr Huřťák ([Hurtak](https://github.com/Hurtak))
+- Robert Panzer ([robertpanzer](https://github.com/robertpanzer))
+- Ryan Sullivan ([ryansully](https://github.com/ryansully))
+- Satya van Heummen ([satyavh](https://github.com/satyavh))
+- Tharaka Wijebandara ([tharakawj](https://github.com/tharakawj))
+- Toshiharu Nishina ([nishina555](https://github.com/nishina555))
+- [captDaylight](https://github.com/captDaylight)
+
+### Migrating from 1.0.14 to 1.0.15
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save --save-exact react-scripts@1.0.15
+```
+
+or
+
+```
+yarn add --exact react-scripts@1.0.15
+```
+
+## 1.0.14 (September 26, 2017)
+
+#### :bug: Bug Fix
+
+* `react-dev-utils`
+
+ * [#3098](https://github.com/facebookincubator/create-react-app/pull/3098) Always reload the page on next compile after a runtime error. ([@Timer](https://github.com/Timer))
+
+* `react-error-overlay`
+
+ * [#3079](https://github.com/facebookincubator/create-react-app/pull/3079) Fix code context on Windows. ([@Timer](https://github.com/Timer))
+
+#### :nail_care: Enhancement
+
+* `react-dev-utils`
+
+ * [#3077](https://github.com/facebookincubator/create-react-app/pull/3077) Auto-detect running editor on Linux for error overlay. ([@gulderov](https://github.com/gulderov))
+
+ * [#3131](https://github.com/facebookincubator/create-react-app/pull/3131) Display process pid in already running message. ([@Pajn](https://github.com/Pajn))
+
+#### :memo: Documentation
+
+* Other
+
+ * [#3163](https://github.com/facebookincubator/create-react-app/pull/3163) Add link to active CSS modules discussion. ([@NeekSandhu](https://github.com/NeekSandhu))
+
+* `react-scripts`
+
+ * [#2908](https://github.com/facebookincubator/create-react-app/pull/2908) Note that class fields have progressed to stage 3. ([@rickbeerendonk](https://github.com/rickbeerendonk))
+
+ * [#3160](https://github.com/facebookincubator/create-react-app/pull/3160) Update unclear wording in webpack configuration (file loader section). ([@kristiehoward](https://github.com/kristiehoward))
+
+* `eslint-config-react-app`
+
+ * [#3072](https://github.com/facebookincubator/create-react-app/pull/3072) Update eslint versions for install instructions. ([@jdcrensh](https://github.com/jdcrensh))
+
+#### :house: Internal
+
+* `react-scripts`
+
+ * [#3157](https://github.com/facebookincubator/create-react-app/pull/3157) Update `webpack-dev-server` to `2.8.2`. ([@nikolas](https://github.com/nikolas))
+
+ * [#2989](https://github.com/facebookincubator/create-react-app/pull/2989) Update install template to match accessibility guidelines. ([@davidleger95](https://github.com/davidleger95))
+
+* `react-error-overlay`
+
+ * [#3065](https://github.com/facebookincubator/create-react-app/pull/3065) Updated `react-error-overlay` to latest Flow (`0.54.0`). ([@duvet86](https://github.com/duvet86))
+
+ * [#3102](https://github.com/facebookincubator/create-react-app/pull/3102) Clean target directory before compiling overlay. ([@Timer](https://github.com/Timer))
+
+* `create-react-app`, `react-dev-utils`, `react-error-overlay`, `react-scripts`
+
+ * [#3058](https://github.com/facebookincubator/create-react-app/pull/3058) Re-run prettier for all files and pin the version. ([@viankakrisna](https://github.com/viankakrisna))
+
+ * [#3107](https://github.com/facebookincubator/create-react-app/pull/3107) Run CI on `npm@^4`. ([@viankakrisna](https://github.com/viankakrisna))
+
+#### Committers: 12
+
+- Ade Viankakrisna Fadlil ([viankakrisna](https://github.com/viankakrisna))
+- David Leger ([davidleger95](https://github.com/davidleger95))
+- Joe Haddad ([Timer](https://github.com/Timer))
+- Jon Crenshaw ([jdcrensh](https://github.com/jdcrensh))
+- Kristie Howard ([kristiehoward](https://github.com/kristiehoward))
+- Luca ([duvet86](https://github.com/duvet86))
+- Neek Sandhu ([NeekSandhu](https://github.com/NeekSandhu))
+- Nik Nyby ([nikolas](https://github.com/nikolas))
+- Rasmus Eneman ([Pajn](https://github.com/Pajn))
+- Rick Beerendonk ([rickbeerendonk](https://github.com/rickbeerendonk))
+- Sophie Alpert ([sophiebits](https://github.com/sophiebits))
+- [gulderov](https://github.com/gulderov)
+
+### Migrating from 1.0.13 to 1.0.14
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save --save-exact react-scripts@1.0.14
+```
+
+or
+
+```
+yarn add --exact react-scripts@1.0.14
+```
+
## 1.0.13 (September 2, 2017)
#### :bug: Bug Fix
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 68a9c4e09..86b392f2f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -108,9 +108,9 @@ More detailed information are in the dedicated [README](/packages/react-scripts/
* Add a four-space indented paragraph after each non-trivial list item, explaining what changed and why. For each breaking change also write who it affects and instructions for migrating existing code.
* Maybe add some newlines here and there. Preview the result on GitHub to get a feel for it. Changelog generator output is a bit too terse for my taste, so try to make it visually pleasing and well grouped.
6. Make sure to include “Migrating from ...” instructions for the previous release. Often you can copy and paste them.
-7. After merging the changelog update, create a GitHub Release with the same text. See previous Releases for inspiration.
-8. **Do not run `npm publish`. Instead, run `npm run publish`.**
-9. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
+7. **Do not run `npm publish`. Instead, run `npm run publish`.**
+8. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
+9. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration.
Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --tag next` instead of `npm run publish`.
diff --git a/LICENSE b/LICENSE
index a6b451216..188fb2b0b 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,30 +1,21 @@
-BSD License
+MIT License
-For create-react-app software
+Copyright (c) 2013-present, Facebook, Inc.
-Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
-Redistribution and use in source and binary forms, with or without modification,
-are permitted provided that the following conditions are met:
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
- * Redistributions of source code must retain the above copyright notice, this
- list of conditions and the following disclaimer.
-
- * Redistributions in binary form must reproduce the above copyright notice,
- this list of conditions and the following disclaimer in the documentation
- and/or other materials provided with the distribution.
-
- * Neither the name Facebook nor the names of its contributors may be used to
- endorse or promote products derived from this software without specific
- prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
-ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
diff --git a/README.md b/README.md
index fddffcbdd..60d848e1b 100644
--- a/README.md
+++ b/README.md
@@ -119,4 +119,4 @@ To fix this, create a new file *in the root of the project* called `tsconfig.tes
* Remove hidden character from `tsconfig.json`
### 1.0.2
-* Copy `typescriptTransform.js` when running `npm run eject`
+* Copy `typescriptTransform.js` when running `npm run eject`
\ No newline at end of file
diff --git a/appveyor.cleanup-cache.txt b/appveyor.cleanup-cache.txt
index 19d0b989b..ea6d1b9c0 100644
--- a/appveyor.cleanup-cache.txt
+++ b/appveyor.cleanup-cache.txt
@@ -3,3 +3,4 @@ http://help.appveyor.com/discussions/questions/1310-delete-cache
----
Just testing if this works.
+lalala.
diff --git a/appveyor.yml b/appveyor.yml
index e00da3943..5d957aa7e 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -2,11 +2,11 @@ image: Visual Studio 2017
environment:
matrix:
- - nodejs_version: 7
+ - nodejs_version: 8
test_suite: "simple"
- - nodejs_version: 7
+ - nodejs_version: 8
test_suite: "installs"
- - nodejs_version: 7
+ - nodejs_version: 8
test_suite: "kitchensink"
- nodejs_version: 6
test_suite: "simple"
@@ -28,8 +28,6 @@ platform:
- x64
install:
- # TODO: Remove after https://github.com/appveyor/ci/issues/1426 is fixed
- - set PATH=C:\Program Files\Git\mingw64\bin;%PATH%
- ps: Install-Product node $env:nodejs_version $env:platform
build: off
@@ -41,4 +39,4 @@ skip_commits:
test_script:
- node --version
- npm --version
- - sh tasks/e2e-%test_suite%.sh
+ - bash tasks/e2e-%test_suite%.sh
diff --git a/package.json b/package.json
index 4beaa5f8c..d623871ff 100644
--- a/package.json
+++ b/package.json
@@ -14,16 +14,16 @@
"precommit": "lint-staged"
},
"devDependencies": {
- "@types/jest": "^20.0.4",
- "@types/node": "^7.0.21",
- "@types/react": "^15.6.1",
- "@types/react-dom": "^15.5.0",
+ "@types/jest": "^21.1.5",
+ "@types/node": "^8.0.47",
+ "@types/react": "^16.0.20",
+ "@types/react-dom": "^16.0.2",
"eslint": "^4.4.1",
"husky": "^0.13.2",
"lerna": "^2.0.0",
"lerna-changelog": "^0.6.0",
"lint-staged": "^3.3.1",
- "prettier": "^1.5.2"
+ "prettier": "1.6.1"
},
"lint-staged": {
"*.js": [
diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js
index f6102dc05..0d961af6f 100644
--- a/packages/babel-preset-react-app/index.js
+++ b/packages/babel-preset-react-app/index.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json
index dce674298..f020f99e0 100644
--- a/packages/babel-preset-react-app/package.json
+++ b/packages/babel-preset-react-app/package.json
@@ -1,9 +1,9 @@
{
"name": "babel-preset-react-app",
- "version": "3.0.2",
+ "version": "3.1.0",
"description": "Babel preset used by Create React App",
"repository": "facebookincubator/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
@@ -11,17 +11,17 @@
"index.js"
],
"dependencies": {
- "babel-plugin-dynamic-import-node": "1.0.2",
+ "babel-plugin-dynamic-import-node": "1.1.0",
"babel-plugin-syntax-dynamic-import": "6.18.0",
"babel-plugin-transform-class-properties": "6.24.1",
- "babel-plugin-transform-object-rest-spread": "6.23.0",
+ "babel-plugin-transform-object-rest-spread": "6.26.0",
"babel-plugin-transform-react-constant-elements": "6.23.0",
"babel-plugin-transform-react-jsx": "6.24.1",
"babel-plugin-transform-react-jsx-self": "6.22.0",
"babel-plugin-transform-react-jsx-source": "6.22.0",
- "babel-plugin-transform-regenerator": "6.24.1",
+ "babel-plugin-transform-regenerator": "6.26.0",
"babel-plugin-transform-runtime": "6.23.0",
- "babel-preset-env": "1.5.2",
+ "babel-preset-env": "1.6.1",
"babel-preset-react": "6.24.1"
},
"peerDependencies": {
diff --git a/packages/create-react-app/createReactApp.js b/packages/create-react-app/createReactApp.js
index 4a1b7901d..9ff7c08cf 100755
--- a/packages/create-react-app/createReactApp.js
+++ b/packages/create-react-app/createReactApp.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -160,8 +158,13 @@ function createApp(name, verbose, version, template) {
path.join(root, 'package.json'),
JSON.stringify(packageJson, null, 2)
);
+
+ const useYarn = shouldUseYarn();
const originalDirectory = process.cwd();
process.chdir(root);
+ if (!useYarn && !checkThatNpmCanReadCwd()) {
+ process.exit(1);
+ }
if (!semver.satisfies(process.version, '>=6.0.0')) {
console.log(
@@ -174,7 +177,6 @@ function createApp(name, verbose, version, template) {
version = 'react-scripts@0.9.x';
}
- const useYarn = shouldUseYarn();
if (!useYarn) {
const npmInfo = checkNpmVersion();
if (!npmInfo.hasMinNpm) {
@@ -202,7 +204,7 @@ function shouldUseYarn() {
}
}
-function install(useYarn, dependencies, verbose, isOnline) {
+function install(root, useYarn, dependencies, verbose, isOnline) {
return new Promise((resolve, reject) => {
let command;
let args;
@@ -214,6 +216,14 @@ function install(useYarn, dependencies, verbose, isOnline) {
}
[].push.apply(args, dependencies);
+ // Explicitly set cwd() to work around issues like
+ // https://github.com/facebookincubator/create-react-app/issues/3326.
+ // Unfortunately we can only do this for Yarn because npm support for
+ // equivalent --prefix flag doesn't help with this issue.
+ // This is why for npm, we run checkThatNpmCanReadCwd() early instead.
+ args.push('--cwd');
+ args.push(root);
+
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'));
console.log(chalk.yellow('Falling back to the local Yarn cache.'));
@@ -277,7 +287,7 @@ function run(
);
console.log();
- return install(useYarn, allDependencies, verbose, isOnline).then(
+ return install(root, useYarn, allDependencies, verbose, isOnline).then(
() => packageName
);
})
@@ -455,7 +465,9 @@ function checkNpmVersion() {
let hasMinNpm = false;
let npmVersion = null;
try {
- npmVersion = execSync('npm --version').toString().trim();
+ npmVersion = execSync('npm --version')
+ .toString()
+ .trim();
hasMinNpm = semver.gte(npmVersion, '3.0.0');
} catch (err) {
// ignore
@@ -606,6 +618,67 @@ function isSafeToCreateProjectIn(root, name) {
return false;
}
+function checkThatNpmCanReadCwd() {
+ const cwd = process.cwd();
+ let childOutput = null;
+ try {
+ // Note: intentionally using spawn over exec since
+ // the problem doesn't reproduce otherwise.
+ // `npm config list` is the only reliable way I could find
+ // to reproduce the wrong path. Just printing process.cwd()
+ // in a Node process was not enough.
+ childOutput = spawn.sync('npm', ['config', 'list']).output.join('');
+ } catch (err) {
+ // Something went wrong spawning node.
+ // Not great, but it means we can't do this check.
+ // We might fail later on, but let's continue.
+ return true;
+ }
+ if (typeof childOutput !== 'string') {
+ return true;
+ }
+ const lines = childOutput.split('\n');
+ // `npm config list` output includes the following line:
+ // "; cwd = C:\path\to\current\dir" (unquoted)
+ // I couldn't find an easier way to get it.
+ const prefix = '; cwd = ';
+ const line = lines.find(line => line.indexOf(prefix) === 0);
+ if (typeof line !== 'string') {
+ // Fail gracefully. They could remove it.
+ return true;
+ }
+ const npmCWD = line.substring(prefix.length);
+ if (npmCWD === cwd) {
+ return true;
+ }
+ console.error(
+ chalk.red(
+ `Could not start an npm process in the right directory.\n\n` +
+ `The current directory is: ${chalk.bold(cwd)}\n` +
+ `However, a newly started npm process runs in: ${chalk.bold(
+ npmCWD
+ )}\n\n` +
+ `This is probably caused by a misconfigured system terminal shell.`
+ )
+ );
+ if (process.platform === 'win32') {
+ console.error(
+ chalk.red(`On Windows, this can usually be fixed by running:\n\n`) +
+ ` ${chalk.cyan(
+ 'reg'
+ )} delete "HKCU\\Software\\Microsoft\\Command Processor" /v AutoRun /f\n` +
+ ` ${chalk.cyan(
+ 'reg'
+ )} delete "HKLM\\Software\\Microsoft\\Command Processor" /v AutoRun /f\n\n` +
+ chalk.red(`Try to run the above two lines in the terminal.\n`) +
+ chalk.red(
+ `To learn more about this problem, read: https://blogs.msdn.microsoft.com/oldnewthing/20071121-00/?p=24433/`
+ )
+ );
+ }
+ return false;
+}
+
function checkIfOnline(useYarn) {
if (!useYarn) {
// Don't ping the Yarn registry.
diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js
index 4df90f53f..a09363660 100755
--- a/packages/create-react-app/index.js
+++ b/packages/create-react-app/index.js
@@ -2,11 +2,9 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/packages/create-react-app/package.json b/packages/create-react-app/package.json
index 42ee3497e..569985f5c 100644
--- a/packages/create-react-app/package.json
+++ b/packages/create-react-app/package.json
@@ -1,12 +1,12 @@
{
"name": "create-react-app",
- "version": "1.4.0",
+ "version": "1.4.3",
"keywords": [
"react"
],
"description": "Create React apps with no build configuration.",
"repository": "facebookincubator/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"engines": {
"node": ">=4"
},
diff --git a/packages/eslint-config-react-app/README.md b/packages/eslint-config-react-app/README.md
index 0679552a2..6918cda52 100644
--- a/packages/eslint-config-react-app/README.md
+++ b/packages/eslint-config-react-app/README.md
@@ -19,7 +19,7 @@ If you want to use this ESLint configuration in a project not built with Create
First, install this package, ESLint and the necessary plugins.
```sh
- npm install --save-dev eslint-config-react-app babel-eslint@7.2.3 eslint@3.19.0 eslint-plugin-flowtype@2.33.0 eslint-plugin-import@2.2.0 eslint-plugin-jsx-a11y@5.0.1 eslint-plugin-react@7.0.1
+ npm install --save-dev eslint-config-react-app babel-eslint@^7.2.3 eslint@^4.1.1 eslint-plugin-flowtype@^2.34.1 eslint-plugin-import@^2.6.0 eslint-plugin-jsx-a11y@^5.1.1 eslint-plugin-react@^7.1.0
```
Then create a file named `.eslintrc` with following contents in the root folder of your project:
diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js
index 4e94e650c..adcdb86bc 100644
--- a/packages/eslint-config-react-app/index.js
+++ b/packages/eslint-config-react-app/index.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/eslint-config-react-app/package.json b/packages/eslint-config-react-app/package.json
index 375c9f54b..a10ef6799 100644
--- a/packages/eslint-config-react-app/package.json
+++ b/packages/eslint-config-react-app/package.json
@@ -1,9 +1,9 @@
{
"name": "eslint-config-react-app",
- "version": "2.0.0",
+ "version": "2.0.1",
"description": "ESLint configuration used by Create React App",
"repository": "facebookincubator/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
diff --git a/packages/react-dev-utils/FileSizeReporter.js b/packages/react-dev-utils/FileSizeReporter.js
index f25e47378..01ce52c6b 100644
--- a/packages/react-dev-utils/FileSizeReporter.js
+++ b/packages/react-dev-utils/FileSizeReporter.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/InterpolateHtmlPlugin.js b/packages/react-dev-utils/InterpolateHtmlPlugin.js
index ac1d3e996..9233bdefa 100644
--- a/packages/react-dev-utils/InterpolateHtmlPlugin.js
+++ b/packages/react-dev-utils/InterpolateHtmlPlugin.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// This Webpack plugin lets us interpolate custom variables into `index.html`.
diff --git a/packages/react-dev-utils/ModuleScopePlugin.js b/packages/react-dev-utils/ModuleScopePlugin.js
index 3a10904d3..101a30a1f 100644
--- a/packages/react-dev-utils/ModuleScopePlugin.js
+++ b/packages/react-dev-utils/ModuleScopePlugin.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js b/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js
index 91b089c05..ae11cdc90 100644
--- a/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js
+++ b/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// This Webpack plugin ensures `npm install <library>` forces a project rebuild.
diff --git a/packages/react-dev-utils/WebpackDevServerUtils.js b/packages/react-dev-utils/WebpackDevServerUtils.js
index bb4a8c790..c2d038654 100644
--- a/packages/react-dev-utils/WebpackDevServerUtils.js
+++ b/packages/react-dev-utils/WebpackDevServerUtils.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/__tests__/.eslintrc b/packages/react-dev-utils/__tests__/.eslintrc
new file mode 100644
index 000000000..55f121d15
--- /dev/null
+++ b/packages/react-dev-utils/__tests__/.eslintrc
@@ -0,0 +1,5 @@
+{
+ "env": {
+ "jest": true
+ }
+}
diff --git a/packages/react-dev-utils/__tests__/ignoredFiles.test.js b/packages/react-dev-utils/__tests__/ignoredFiles.test.js
new file mode 100644
index 000000000..6feed9797
--- /dev/null
+++ b/packages/react-dev-utils/__tests__/ignoredFiles.test.js
@@ -0,0 +1,55 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+const ignoredFiles = require('../ignoredFiles');
+
+describe('ignore watch files regex', () => {
+ it('normal file', () => {
+ const appSrc = '/root/src/';
+ const isIgnored = ignoredFiles(appSrc).test('/foo');
+ const isIgnoredInSrc = ignoredFiles(appSrc).test('/root/src/foo');
+
+ expect(isIgnored).toBe(false);
+ expect(isIgnoredInSrc).toBe(false);
+ });
+
+ it('node modules', () => {
+ const appSrc = '/root/src/';
+ const isIgnored = ignoredFiles(appSrc).test('/root/node_modules/foo');
+
+ expect(isIgnored).toBe(true);
+ });
+
+ it('node modules inside source directory', () => {
+ const appSrc = '/root/src/';
+ const isIgnored = ignoredFiles(appSrc).test('/root/src/node_modules/foo');
+ const isIgnoredMoreThanOneLevel = ignoredFiles(appSrc).test(
+ '/root/src/bar/node_modules/foo'
+ );
+
+ expect(isIgnored).toBe(false);
+ expect(isIgnoredMoreThanOneLevel).toBe(false);
+ });
+
+ it('path contains source directory', () => {
+ const appSrc = '/root/src/';
+ const isIgnored = ignoredFiles(appSrc).test(
+ '/bar/root/src/node_modules/foo'
+ );
+
+ expect(isIgnored).toBe(true);
+ });
+
+ it('path starts with source directory', () => {
+ const appSrc = '/root/src/';
+ const isIgnored = ignoredFiles(appSrc).test('/root/src2/node_modules/foo');
+
+ expect(isIgnored).toBe(true);
+ });
+});
diff --git a/packages/react-dev-utils/checkRequiredFiles.js b/packages/react-dev-utils/checkRequiredFiles.js
index 55139b0b8..9799cf6b5 100644
--- a/packages/react-dev-utils/checkRequiredFiles.js
+++ b/packages/react-dev-utils/checkRequiredFiles.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/clearConsole.js b/packages/react-dev-utils/clearConsole.js
index 05ab28c44..6e3b3c9ce 100644
--- a/packages/react-dev-utils/clearConsole.js
+++ b/packages/react-dev-utils/clearConsole.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/crossSpawn.js b/packages/react-dev-utils/crossSpawn.js
index 8424dcf09..b772086f2 100644
--- a/packages/react-dev-utils/crossSpawn.js
+++ b/packages/react-dev-utils/crossSpawn.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/errorOverlayMiddleware.js b/packages/react-dev-utils/errorOverlayMiddleware.js
index b2a857d6e..b756b0ef6 100644
--- a/packages/react-dev-utils/errorOverlayMiddleware.js
+++ b/packages/react-dev-utils/errorOverlayMiddleware.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/eslintFormatter.js b/packages/react-dev-utils/eslintFormatter.js
index b7756b7a2..a269ccc82 100644
--- a/packages/react-dev-utils/eslintFormatter.js
+++ b/packages/react-dev-utils/eslintFormatter.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js
index 1f22a0059..7aea5582c 100644
--- a/packages/react-dev-utils/formatWebpackMessages.js
+++ b/packages/react-dev-utils/formatWebpackMessages.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/getProcessForPort.js b/packages/react-dev-utils/getProcessForPort.js
index 428dc62cf..932f3e5bf 100644
--- a/packages/react-dev-utils/getProcessForPort.js
+++ b/packages/react-dev-utils/getProcessForPort.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -48,9 +46,11 @@ function getProcessCommand(processId, processDirectory) {
execOptions
);
+ command = command.replace(/\n$/, '');
+
if (isProcessAReactApp(command)) {
const packageName = getPackageNameInDirectory(processDirectory);
- return packageName ? packageName + '\n' : command;
+ return packageName ? packageName : command;
} else {
return command;
}
@@ -68,7 +68,12 @@ function getProcessForPort(port) {
var processId = getProcessIdOnPort(port);
var directory = getDirectoryOfProcessById(processId);
var command = getProcessCommand(processId, directory);
- return chalk.cyan(command) + chalk.blue(' in ') + chalk.cyan(directory);
+ return (
+ chalk.cyan(command) +
+ chalk.grey(' (pid ' + processId + ')\n') +
+ chalk.blue(' in ') +
+ chalk.cyan(directory)
+ );
} catch (e) {
return null;
}
diff --git a/packages/react-dev-utils/ignoredFiles.js b/packages/react-dev-utils/ignoredFiles.js
new file mode 100644
index 000000000..50348ea6b
--- /dev/null
+++ b/packages/react-dev-utils/ignoredFiles.js
@@ -0,0 +1,19 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+const path = require('path');
+
+module.exports = function ignoredFiles(appSrc) {
+ return new RegExp(
+ `^(?!${path
+ .normalize(appSrc + '/')
+ .replace(/[\\]+/g, '/')}).+/node_modules/`,
+ 'g'
+ );
+};
diff --git a/packages/react-dev-utils/inquirer.js b/packages/react-dev-utils/inquirer.js
index 9dbc08026..6b8eca9ea 100644
--- a/packages/react-dev-utils/inquirer.js
+++ b/packages/react-dev-utils/inquirer.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/launchEditor.js b/packages/react-dev-utils/launchEditor.js
index e1ea29c88..ba16827e6 100644
--- a/packages/react-dev-utils/launchEditor.js
+++ b/packages/react-dev-utils/launchEditor.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -43,7 +41,7 @@ const COMMON_EDITORS_OSX = {
'/Applications/CLion.app/Contents/MacOS/clion':
'/Applications/CLion.app/Contents/MacOS/clion',
'/Applications/IntelliJ IDEA.app/Contents/MacOS/idea':
- '/Applications/IntelliJ IDEA.app/Contents/MacOS/idea',
+ '/Applications/IntelliJ IDEA.app/Contents/MacOS/idea',
'/Applications/PhpStorm.app/Contents/MacOS/phpstorm':
'/Applications/PhpStorm.app/Contents/MacOS/phpstorm',
'/Applications/PyCharm.app/Contents/MacOS/pycharm':
@@ -53,7 +51,21 @@ const COMMON_EDITORS_OSX = {
'/Applications/RubyMine.app/Contents/MacOS/rubymine':
'/Applications/RubyMine.app/Contents/MacOS/rubymine',
'/Applications/WebStorm.app/Contents/MacOS/webstorm':
- '/Applications/WebStorm.app/Contents/MacOS/webstorm',
+ '/Applications/WebStorm.app/Contents/MacOS/webstorm',
+};
+
+const COMMON_EDITORS_LINUX = {
+ atom: 'atom',
+ Brackets: 'brackets',
+ code: 'code',
+ emacs: 'emacs',
+ 'idea.sh': 'idea',
+ 'phpstorm.sh': 'phpstorm',
+ 'pycharm.sh': 'pycharm',
+ 'rubymine.sh': 'rubymine',
+ sublime_text: 'sublime_text',
+ vim: 'vim',
+ 'webstorm.sh': 'webstorm',
};
const COMMON_EDITORS_WIN = [
@@ -144,8 +156,9 @@ function guessEditor() {
return shellQuote.parse(process.env.REACT_EDITOR);
}
- // Using `ps x` on OSX or `Get-Process` on Windows we can find out which editor is currently running.
- // Potentially we could use similar technique for Linux
+ // We can find out which editor is currently running by:
+ // `ps x` on macOS and Linux
+ // `Get-Process` on Windows
try {
if (process.platform === 'darwin') {
const output = child_process.execSync('ps x').toString();
@@ -176,6 +189,20 @@ function guessEditor() {
return [fullProcessPath];
}
}
+ } else if (process.platform === 'linux') {
+ // --no-heading No header line
+ // x List all processes owned by you
+ // -o comm Need only names column
+ const output = child_process
+ .execSync('ps x --no-heading -o comm --sort=comm')
+ .toString();
+ const processNames = Object.keys(COMMON_EDITORS_LINUX);
+ for (let i = 0; i < processNames.length; i++) {
+ const processName = processNames[i];
+ if (output.indexOf(processName) !== -1) {
+ return [COMMON_EDITORS_LINUX[processName]];
+ }
+ }
}
} catch (error) {
// Ignore...
diff --git a/packages/react-dev-utils/launchEditorEndpoint.js b/packages/react-dev-utils/launchEditorEndpoint.js
index e21870be9..99b5935d9 100644
--- a/packages/react-dev-utils/launchEditorEndpoint.js
+++ b/packages/react-dev-utils/launchEditorEndpoint.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/noopServiceWorkerMiddleware.js b/packages/react-dev-utils/noopServiceWorkerMiddleware.js
index b6cee7350..41566dd7f 100644
--- a/packages/react-dev-utils/noopServiceWorkerMiddleware.js
+++ b/packages/react-dev-utils/noopServiceWorkerMiddleware.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/openBrowser.js b/packages/react-dev-utils/openBrowser.js
index 4f5700125..cb9f32c6a 100644
--- a/packages/react-dev-utils/openBrowser.js
+++ b/packages/react-dev-utils/openBrowser.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/openChrome.applescript b/packages/react-dev-utils/openChrome.applescript
index 0f5602721..3b1b5a29d 100644
--- a/packages/react-dev-utils/openChrome.applescript
+++ b/packages/react-dev-utils/openChrome.applescript
@@ -1,10 +1,8 @@
(*
Copyright (c) 2015-present, Facebook, Inc.
-All rights reserved.
-This source code is licensed under the BSD-style license found in the
--- LICENSE file in the root directory of this source tree. An additional grant
-of patent rights can be found in the PATENTS file in the same directory.
+This source code is licensed under the MIT license found in the
+LICENSE file in the root directory of this source tree.
*)
property targetTab: null
diff --git a/packages/react-dev-utils/package.json b/packages/react-dev-utils/package.json
index ec8b44292..54606f33f 100644
--- a/packages/react-dev-utils/package.json
+++ b/packages/react-dev-utils/package.json
@@ -1,9 +1,9 @@
{
"name": "react-dev-utils",
- "version": "4.0.1",
+ "version": "4.2.1",
"description": "Webpack utilities used by Create React App",
"repository": "facebookincubator/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
@@ -21,6 +21,7 @@
"printBuildError.js",
"formatWebpackMessages.js",
"getProcessForPort.js",
+ "ignoredFiles.js",
"inquirer.js",
"InterpolateHtmlPlugin.js",
"launchEditor.js",
@@ -35,23 +36,29 @@
"webpackHotDevClient.js"
],
"dependencies": {
- "address": "1.0.2",
- "babel-code-frame": "6.22.0",
+ "address": "1.0.3",
+ "babel-code-frame": "6.26.0",
"chalk": "1.1.3",
"cross-spawn": "5.1.0",
"detect-port-alt": "1.1.3",
"escape-string-regexp": "1.0.5",
- "filesize": "3.5.10",
+ "filesize": "3.5.11",
"global-modules": "1.0.0",
"gzip-size": "3.0.0",
- "inquirer": "3.2.1",
+ "inquirer": "3.3.0",
"is-root": "1.0.0",
"opn": "5.1.0",
- "react-error-overlay": "^2.0.1",
+ "react-error-overlay": "^3.0.0",
"recursive-readdir": "2.2.1",
"shell-quote": "1.6.1",
"sockjs-client": "1.1.4",
"strip-ansi": "3.0.1",
"text-table": "0.2.0"
+ },
+ "devDependencies": {
+ "jest": "20.0.4"
+ },
+ "scripts": {
+ "test": "jest"
}
}
diff --git a/packages/react-dev-utils/printBuildError.js b/packages/react-dev-utils/printBuildError.js
index eadfff471..26e291356 100644
--- a/packages/react-dev-utils/printBuildError.js
+++ b/packages/react-dev-utils/printBuildError.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/printHostingInstructions.js b/packages/react-dev-utils/printHostingInstructions.js
index 2ef25767a..4a080dba2 100644
--- a/packages/react-dev-utils/printHostingInstructions.js
+++ b/packages/react-dev-utils/printHostingInstructions.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-dev-utils/webpackHotDevClient.js b/packages/react-dev-utils/webpackHotDevClient.js
index 18a6a4a0a..296e38046 100644
--- a/packages/react-dev-utils/webpackHotDevClient.js
+++ b/packages/react-dev-utils/webpackHotDevClient.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -25,13 +23,27 @@ var launchEditorEndpoint = require('./launchEditorEndpoint');
var formatWebpackMessages = require('./formatWebpackMessages');
var ErrorOverlay = require('react-error-overlay');
+ErrorOverlay.setEditorHandler(function editorHandler(errorLocation) {
+ // Keep this sync with errorOverlayMiddleware.js
+ fetch(
+ launchEditorEndpoint +
+ '?fileName=' +
+ window.encodeURIComponent(errorLocation.fileName) +
+ '&lineNumber=' +
+ window.encodeURIComponent(errorLocation.lineNumber || 1)
+ );
+});
+
+// We need to keep track of if there has been a runtime error.
+// Essentially, we cannot guarantee application state was not corrupted by the
+// runtime error. To prevent confusing behavior, we forcibly reload the entire
+// application. This is handled below when we are notified of a compile (code
+// change).
+// See https://github.com/facebookincubator/create-react-app/issues/3096
+var hadRuntimeError = false;
ErrorOverlay.startReportingRuntimeErrors({
- launchEditorEndpoint: launchEditorEndpoint,
onError: function() {
- // TODO: why do we need this?
- if (module.hot && typeof module.hot.decline === 'function') {
- module.hot.decline();
- }
+ hadRuntimeError = true;
},
filename: '/static/js/bundle.js',
});
@@ -227,7 +239,7 @@ function tryApplyUpdates(onHotUpdateSuccess) {
}
function handleApplyUpdates(err, updatedModules) {
- if (err || !updatedModules) {
+ if (err || !updatedModules || hadRuntimeError) {
window.location.reload();
return;
}
diff --git a/packages/react-error-overlay/.gitattributes b/packages/react-error-overlay/.gitattributes
new file mode 100644
index 000000000..cbdcbbc25
--- /dev/null
+++ b/packages/react-error-overlay/.gitattributes
@@ -0,0 +1 @@
+*.js text eol=lf
diff --git a/packages/react-error-overlay/build.js b/packages/react-error-overlay/build.js
new file mode 100644
index 000000000..592da141f
--- /dev/null
+++ b/packages/react-error-overlay/build.js
@@ -0,0 +1,95 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+const webpack = require('webpack');
+const chalk = require('chalk');
+const webpackConfig = require('./webpack.config.js');
+const iframeWebpackConfig = require('./webpack.config.iframe.js');
+const rimraf = require('rimraf');
+const chokidar = require('chokidar');
+
+const args = process.argv.slice(2);
+const watchMode = args[0] === '--watch' || args[0] === '-w';
+
+const isCI =
+ process.env.CI &&
+ (typeof process.env.CI !== 'string' ||
+ process.env.CI.toLowerCase() !== 'false');
+
+function build(config, name, callback) {
+ console.log(chalk.cyan('Compiling ' + name));
+ webpack(config).run((error, stats) => {
+ if (error) {
+ console.log(chalk.red('Failed to compile.'));
+ console.log(error.message || error);
+ console.log();
+ }
+
+ if (stats.compilation.errors.length) {
+ console.log(chalk.red('Failed to compile.'));
+ console.log(stats.toString({ all: false, errors: true }));
+ }
+
+ if (stats.compilation.warnings.length) {
+ console.log(chalk.yellow('Compiled with warnings.'));
+ console.log(stats.toString({ all: false, warnings: true }));
+ }
+
+ // Fail the build if running in a CI server
+ if (
+ error ||
+ stats.compilation.errors.length ||
+ stats.compilation.warnings.length
+ ) {
+ isCI && process.exit(1);
+ return;
+ }
+
+ console.log(
+ stats.toString({ colors: true, modules: false, version: false })
+ );
+ console.log();
+
+ callback(stats);
+ });
+}
+
+function runBuildSteps() {
+ build(iframeWebpackConfig, 'iframeScript.js', () => {
+ build(webpackConfig, 'index.js', () => {
+ console.log(chalk.bold.green('Compiled successfully!\n\n'));
+ });
+ });
+}
+
+function setupWatch() {
+ const watcher = chokidar.watch('./src', {
+ ignoreInitial: true,
+ });
+
+ watcher.on('change', runBuildSteps);
+ watcher.on('add', runBuildSteps);
+
+ watcher.on('ready', () => {
+ runBuildSteps();
+ });
+
+ process.on('SIGINT', function() {
+ watcher.close();
+ process.exit(0);
+ });
+
+ watcher.on('error', error => {
+ console.error('Watcher failure', error);
+ process.exit(1);
+ });
+}
+
+// Clean up lib folder
+rimraf('lib/', () => {
+ console.log('Cleaned up the lib folder.\n');
+ watchMode ? setupWatch() : runBuildSteps();
+});
diff --git a/packages/react-error-overlay/package.json b/packages/react-error-overlay/package.json
index b3b9365ae..d4e528ea6 100644
--- a/packages/react-error-overlay/package.json
+++ b/packages/react-error-overlay/package.json
@@ -1,17 +1,17 @@
{
"name": "react-error-overlay",
- "version": "2.0.1",
+ "version": "3.0.0",
"description": "An overlay for displaying stack frames.",
"main": "lib/index.js",
"scripts": {
"prepublishOnly": "npm run build:prod && npm test",
- "start": "cross-env NODE_ENV=development npm run build -- --watch",
- "test": "flow && jest",
- "build": "babel src/ -d lib/",
- "build:prod": "cross-env NODE_ENV=production babel src/ -d lib/"
+ "start": "cross-env NODE_ENV=development node build.js --watch",
+ "test": "flow && cross-env NODE_ENV=test jest",
+ "build": "cross-env NODE_ENV=development node build.js",
+ "build:prod": "cross-env NODE_ENV=production node build.js"
},
"repository": "facebookincubator/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
@@ -27,33 +27,38 @@
],
"author": "Joe Haddad <timer150@gmail.com>",
"files": [
- "lib/",
- "middleware.js"
+ "lib/index.js"
],
- "dependencies": {
- "anser": "1.4.1",
- "babel-code-frame": "6.22.0",
- "babel-runtime": "6.26.0",
- "html-entities": "1.2.1",
- "react": "^15 || ^16",
- "react-dom": "^15 || ^16",
- "settle-promise": "1.0.0",
- "source-map": "0.5.6"
- },
"devDependencies": {
- "babel-cli": "6.24.1",
+ "anser": "1.4.4",
+ "babel-code-frame": "6.26.0",
+ "babel-core": "^6.26.0",
"babel-eslint": "7.2.3",
- "babel-preset-react-app": "^3.0.2",
+ "babel-loader": "^7.1.2",
+ "babel-preset-react-app": "^3.1.0",
+ "babel-runtime": "6.26.0",
+ "chalk": "^2.1.0",
+ "chokidar": "^1.7.0",
"cross-env": "5.0.5",
"eslint": "4.4.1",
- "eslint-config-react-app": "^2.0.0",
+ "eslint-config-react-app": "^2.0.1",
"eslint-plugin-flowtype": "2.35.0",
"eslint-plugin-import": "2.7.0",
"eslint-plugin-jsx-a11y": "5.1.1",
"eslint-plugin-react": "7.1.0",
- "flow-bin": "0.52.0",
+ "flow-bin": "^0.54.0",
+ "html-entities": "1.2.1",
"jest": "20.0.4",
- "jest-fetch-mock": "1.2.1"
+ "jest-fetch-mock": "1.2.1",
+ "object-assign": "4.1.1",
+ "promise": "8.0.1",
+ "raw-loader": "^0.5.1",
+ "react": "^16.0.0",
+ "react-dom": "^16.0.0",
+ "rimraf": "^2.6.1",
+ "settle-promise": "1.0.0",
+ "source-map": "0.5.6",
+ "webpack": "^3.6.0"
},
"jest": {
"setupFiles": [
diff --git a/packages/react-error-overlay/src/__tests__/extract-source-map.js b/packages/react-error-overlay/src/__tests__/extract-source-map.js
index 85c30accd..b47f5ab5f 100644
--- a/packages/react-error-overlay/src/__tests__/extract-source-map.js
+++ b/packages/react-error-overlay/src/__tests__/extract-source-map.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { extractSourceMapUrl } from '../utils/getSourceMap';
diff --git a/packages/react-error-overlay/src/__tests__/get-source-map.js b/packages/react-error-overlay/src/__tests__/get-source-map.js
index 299069266..27c6d5f78 100644
--- a/packages/react-error-overlay/src/__tests__/get-source-map.js
+++ b/packages/react-error-overlay/src/__tests__/get-source-map.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { getSourceMap } from '../utils/getSourceMap';
diff --git a/packages/react-error-overlay/src/__tests__/lines-around.js b/packages/react-error-overlay/src/__tests__/lines-around.js
index 0317bd47b..64595df30 100644
--- a/packages/react-error-overlay/src/__tests__/lines-around.js
+++ b/packages/react-error-overlay/src/__tests__/lines-around.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { getLinesAround } from '../utils/getLinesAround';
diff --git a/packages/react-error-overlay/src/__tests__/mapper.js b/packages/react-error-overlay/src/__tests__/mapper.js
index 169bf6c59..bd733487f 100644
--- a/packages/react-error-overlay/src/__tests__/mapper.js
+++ b/packages/react-error-overlay/src/__tests__/mapper.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { map } from '../utils/mapper';
diff --git a/packages/react-error-overlay/src/__tests__/parser/chrome.js b/packages/react-error-overlay/src/__tests__/parser/chrome.js
index caf95a6fc..651f584cc 100644
--- a/packages/react-error-overlay/src/__tests__/parser/chrome.js
+++ b/packages/react-error-overlay/src/__tests__/parser/chrome.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { parse } from '../../utils/parser';
diff --git a/packages/react-error-overlay/src/__tests__/parser/firefox.js b/packages/react-error-overlay/src/__tests__/parser/firefox.js
index 4f1d19ac2..8aa0f4d6c 100644
--- a/packages/react-error-overlay/src/__tests__/parser/firefox.js
+++ b/packages/react-error-overlay/src/__tests__/parser/firefox.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { parse } from '../../utils/parser';
diff --git a/packages/react-error-overlay/src/__tests__/parser/generic.js b/packages/react-error-overlay/src/__tests__/parser/generic.js
index b58c537d3..32bade931 100644
--- a/packages/react-error-overlay/src/__tests__/parser/generic.js
+++ b/packages/react-error-overlay/src/__tests__/parser/generic.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { parse } from '../../utils/parser';
diff --git a/packages/react-error-overlay/src/__tests__/parser/react.js b/packages/react-error-overlay/src/__tests__/parser/react.js
index 907fae239..e7dcc07cb 100644
--- a/packages/react-error-overlay/src/__tests__/parser/react.js
+++ b/packages/react-error-overlay/src/__tests__/parser/react.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { parse } from '../../utils/parser';
diff --git a/packages/react-error-overlay/src/__tests__/parser/safari.js b/packages/react-error-overlay/src/__tests__/parser/safari.js
index 69ecf6c78..74d169d99 100644
--- a/packages/react-error-overlay/src/__tests__/parser/safari.js
+++ b/packages/react-error-overlay/src/__tests__/parser/safari.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { parse } from '../../utils/parser';
diff --git a/packages/react-error-overlay/src/__tests__/script-lines.js b/packages/react-error-overlay/src/__tests__/script-lines.js
index e26e8d4f8..ec5ff0b0f 100644
--- a/packages/react-error-overlay/src/__tests__/script-lines.js
+++ b/packages/react-error-overlay/src/__tests__/script-lines.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { ScriptLine } from '../utils/stack-frame';
diff --git a/packages/react-error-overlay/src/__tests__/setupJest.js b/packages/react-error-overlay/src/__tests__/setupJest.js
index 496826f2c..91757b455 100644
--- a/packages/react-error-overlay/src/__tests__/setupJest.js
+++ b/packages/react-error-overlay/src/__tests__/setupJest.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
global.fetch = require('jest-fetch-mock');
diff --git a/packages/react-error-overlay/src/__tests__/stack-frame.js b/packages/react-error-overlay/src/__tests__/stack-frame.js
index 5a015260a..af1f05e0a 100644
--- a/packages/react-error-overlay/src/__tests__/stack-frame.js
+++ b/packages/react-error-overlay/src/__tests__/stack-frame.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { StackFrame } from '../utils/stack-frame';
diff --git a/packages/react-error-overlay/src/__tests__/unmapper.js b/packages/react-error-overlay/src/__tests__/unmapper.js
index fd162ccac..c9dc32a53 100644
--- a/packages/react-error-overlay/src/__tests__/unmapper.js
+++ b/packages/react-error-overlay/src/__tests__/unmapper.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { unmap } from '../utils/unmapper';
diff --git a/packages/react-error-overlay/src/components/CloseButton.js b/packages/react-error-overlay/src/components/CloseButton.js
index 503b1198c..ed7006ea3 100644
--- a/packages/react-error-overlay/src/components/CloseButton.js
+++ b/packages/react-error-overlay/src/components/CloseButton.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/components/CodeBlock.js b/packages/react-error-overlay/src/components/CodeBlock.js
index 478f0111b..3165bb3b0 100644
--- a/packages/react-error-overlay/src/components/CodeBlock.js
+++ b/packages/react-error-overlay/src/components/CodeBlock.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/components/Collapsible.js b/packages/react-error-overlay/src/components/Collapsible.js
index 92f1de429..016f3c7a7 100644
--- a/packages/react-error-overlay/src/components/Collapsible.js
+++ b/packages/react-error-overlay/src/components/Collapsible.js
@@ -1,16 +1,16 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
import React, { Component } from 'react';
import { black } from '../styles';
+import type { Element as ReactElement } from 'react';
+
const _collapsibleStyle = {
color: black,
cursor: 'pointer',
@@ -35,7 +35,15 @@ const collapsibleExpandedStyle = {
marginBottom: '0.6em',
};
-class Collapsible extends Component {
+type Props = {|
+ children: ReactElement<any>[],
+|};
+
+type State = {|
+ collapsed: boolean,
+|};
+
+class Collapsible extends Component<Props, State> {
state = {
collapsed: true,
};
diff --git a/packages/react-error-overlay/src/components/ErrorOverlay.js b/packages/react-error-overlay/src/components/ErrorOverlay.js
index 446105dad..da4154002 100644
--- a/packages/react-error-overlay/src/components/ErrorOverlay.js
+++ b/packages/react-error-overlay/src/components/ErrorOverlay.js
@@ -1,16 +1,16 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
import React, { Component } from 'react';
import { black } from '../styles';
+import type { Node as ReactNode } from 'react';
+
const overlayStyle = {
position: 'relative',
display: 'inline-flex',
@@ -31,10 +31,19 @@ const overlayStyle = {
color: black,
};
-class ErrorOverlay extends Component {
+type Props = {|
+ children: ReactNode,
+ shortcutHandler?: (eventKey: string) => void,
+|};
+
+type State = {|
+ collapsed: boolean,
+|};
+
+class ErrorOverlay extends Component<Props, State> {
iframeWindow: window = null;
- getIframeWindow = (element: HTMLDivElement) => {
+ getIframeWindow = (element: ?HTMLDivElement) => {
if (element) {
const document = element.ownerDocument;
this.iframeWindow = document.defaultView;
diff --git a/packages/react-error-overlay/src/components/Footer.js b/packages/react-error-overlay/src/components/Footer.js
index 68eb84656..bef53f6c1 100644
--- a/packages/react-error-overlay/src/components/Footer.js
+++ b/packages/react-error-overlay/src/components/Footer.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/components/Header.js b/packages/react-error-overlay/src/components/Header.js
index a2f40973d..7b45ceef5 100644
--- a/packages/react-error-overlay/src/components/Header.js
+++ b/packages/react-error-overlay/src/components/Header.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -29,11 +27,7 @@ type HeaderPropType = {|
|};
function Header(props: HeaderPropType) {
- return (
- <div style={headerStyle}>
- {props.headerText}
- </div>
- );
+ return <div style={headerStyle}>{props.headerText}</div>;
}
export default Header;
diff --git a/packages/react-error-overlay/src/components/NavigationBar.js b/packages/react-error-overlay/src/components/NavigationBar.js
index 4eba743ce..6fb7b14ab 100644
--- a/packages/react-error-overlay/src/components/NavigationBar.js
+++ b/packages/react-error-overlay/src/components/NavigationBar.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/containers/CompileErrorContainer.js b/packages/react-error-overlay/src/containers/CompileErrorContainer.js
index a3e89fe59..9d1e399fd 100644
--- a/packages/react-error-overlay/src/containers/CompileErrorContainer.js
+++ b/packages/react-error-overlay/src/containers/CompileErrorContainer.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -14,14 +12,34 @@ import Footer from '../components/Footer';
import Header from '../components/Header';
import CodeBlock from '../components/CodeBlock';
import generateAnsiHTML from '../utils/generateAnsiHTML';
+import parseCompileError from '../utils/parseCompileError';
+import type { ErrorLocation } from '../utils/parseCompileError';
-class CompileErrorContainer extends PureComponent {
+const codeAnchorStyle = {
+ cursor: 'pointer',
+};
+
+type Props = {|
+ error: string,
+ editorHandler: (errorLoc: ErrorLocation) => void,
+|};
+
+class CompileErrorContainer extends PureComponent<Props, void> {
render() {
- const { error } = this.props;
+ const { error, editorHandler } = this.props;
+ const errLoc: ?ErrorLocation = parseCompileError(error);
+ const canOpenInEditor = errLoc !== null && editorHandler !== null;
return (
<ErrorOverlay>
<Header headerText="Failed to compile" />
- <CodeBlock main={true} codeHTML={generateAnsiHTML(error)} />
+ <a
+ onClick={
+ canOpenInEditor && errLoc ? () => editorHandler(errLoc) : null
+ }
+ style={canOpenInEditor ? codeAnchorStyle : null}
+ >
+ <CodeBlock main={true} codeHTML={generateAnsiHTML(error)} />
+ </a>
<Footer line1="This error occurred during the build time and cannot be dismissed." />
</ErrorOverlay>
);
diff --git a/packages/react-error-overlay/src/containers/RuntimeError.js b/packages/react-error-overlay/src/containers/RuntimeError.js
index c64824137..1db2aba79 100644
--- a/packages/react-error-overlay/src/containers/RuntimeError.js
+++ b/packages/react-error-overlay/src/containers/RuntimeError.js
@@ -1,24 +1,24 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
import React from 'react';
import Header from '../components/Header';
import StackTrace from './StackTrace';
+
import type { StackFrame } from '../utils/stack-frame';
+import type { ErrorLocation } from '../utils/parseCompileError';
const wrapperStyle = {
display: 'flex',
flexDirection: 'column',
};
-type ErrorRecord = {|
+export type ErrorRecord = {|
error: Error,
unhandledRejection: boolean,
contextSize: number,
@@ -27,10 +27,10 @@ type ErrorRecord = {|
type Props = {|
errorRecord: ErrorRecord,
- launchEditorEndpoint: ?string,
+ editorHandler: (errorLoc: ErrorLocation) => void,
|};
-function RuntimeError({ errorRecord, launchEditorEndpoint }: Props) {
+function RuntimeError({ errorRecord, editorHandler }: Props) {
const { error, unhandledRejection, contextSize, stackFrames } = errorRecord;
const errorName = unhandledRejection
? 'Unhandled Rejection (' + error.name + ')'
@@ -59,7 +59,7 @@ function RuntimeError({ errorRecord, launchEditorEndpoint }: Props) {
stackFrames={stackFrames}
errorName={errorName}
contextSize={contextSize}
- launchEditorEndpoint={launchEditorEndpoint}
+ editorHandler={editorHandler}
/>
</div>
);
diff --git a/packages/react-error-overlay/src/containers/RuntimeErrorContainer.js b/packages/react-error-overlay/src/containers/RuntimeErrorContainer.js
index 9c41aa381..91d4a4f54 100644
--- a/packages/react-error-overlay/src/containers/RuntimeErrorContainer.js
+++ b/packages/react-error-overlay/src/containers/RuntimeErrorContainer.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -15,7 +13,20 @@ import NavigationBar from '../components/NavigationBar';
import RuntimeError from './RuntimeError';
import Footer from '../components/Footer';
-class RuntimeErrorContainer extends PureComponent {
+import type { ErrorRecord } from './RuntimeError';
+import type { ErrorLocation } from '../utils/parseCompileError';
+
+type Props = {|
+ errorRecords: ErrorRecord[],
+ close: () => void,
+ editorHandler: (errorLoc: ErrorLocation) => void,
+|};
+
+type State = {|
+ currentIndex: number,
+|};
+
+class RuntimeErrorContainer extends PureComponent<Props, State> {
state = {
currentIndex: 0,
};
@@ -54,16 +65,17 @@ class RuntimeErrorContainer extends PureComponent {
return (
<ErrorOverlay shortcutHandler={this.shortcutHandler}>
<CloseButton close={close} />
- {totalErrors > 1 &&
+ {totalErrors > 1 && (
<NavigationBar
currentError={this.state.currentIndex + 1}
totalErrors={totalErrors}
previous={this.previous}
next={this.next}
- />}
+ />
+ )}
<RuntimeError
errorRecord={errorRecords[this.state.currentIndex]}
- launchEditorEndpoint={this.props.launchEditorEndpoint}
+ editorHandler={this.props.editorHandler}
/>
<Footer
line1="This screen is visible only in development. It will not appear if the app crashes in production."
diff --git a/packages/react-error-overlay/src/containers/StackFrame.js b/packages/react-error-overlay/src/containers/StackFrame.js
index c95ce003f..9ae910434 100644
--- a/packages/react-error-overlay/src/containers/StackFrame.js
+++ b/packages/react-error-overlay/src/containers/StackFrame.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -13,6 +11,9 @@ import CodeBlock from './StackFrameCodeBlock';
import { getPrettyURL } from '../utils/getPrettyURL';
import { darkGray } from '../styles';
+import type { StackFrame as StackFrameType } from '../utils/stack-frame';
+import type { ErrorLocation } from '../utils/parseCompileError';
+
const linkStyle = {
fontSize: '0.9em',
marginBottom: '0.9em',
@@ -43,7 +44,19 @@ const toggleStyle = {
lineHeight: '1.5',
};
-class StackFrame extends Component {
+type Props = {|
+ frame: StackFrameType,
+ contextSize: number,
+ critical: boolean,
+ showCode: boolean,
+ editorHandler: (errorLoc: ErrorLocation) => void,
+|};
+
+type State = {|
+ compiled: boolean,
+|};
+
+class StackFrame extends Component<Props, State> {
state = {
compiled: false,
};
@@ -54,45 +67,35 @@ class StackFrame extends Component {
}));
};
- canOpenInEditor() {
- if (!this.props.launchEditorEndpoint) {
- return;
- }
- const { _originalFileName: sourceFileName } = this.props.frame;
+ getErrorLocation(): ErrorLocation | null {
+ const {
+ _originalFileName: fileName,
+ _originalLineNumber: lineNumber,
+ } = this.props.frame;
// Unknown file
- if (!sourceFileName) {
- return false;
+ if (!fileName) {
+ return null;
}
// e.g. "/path-to-my-app/webpack/bootstrap eaddeb46b67d75e4dfc1"
- const isInternalWebpackBootstrapCode =
- sourceFileName.trim().indexOf(' ') !== -1;
+ const isInternalWebpackBootstrapCode = fileName.trim().indexOf(' ') !== -1;
if (isInternalWebpackBootstrapCode) {
- return false;
+ return null;
}
// Code is in a real file
- return true;
+ return { fileName, lineNumber: lineNumber || 1 };
}
- openInEditor = () => {
- if (!this.canOpenInEditor()) {
+ editorHandler = () => {
+ const errorLoc = this.getErrorLocation();
+ if (!errorLoc) {
return;
}
- const {
- _originalFileName: sourceFileName,
- _originalLineNumber: sourceLineNumber,
- } = this.props.frame;
- // Keep this in sync with react-error-overlay/middleware.js
- fetch(
- `${this.props.launchEditorEndpoint}?fileName=` +
- window.encodeURIComponent(sourceFileName) +
- '&lineNumber=' +
- window.encodeURIComponent(sourceLineNumber || 1)
- ).then(() => {}, () => {});
+ this.props.editorHandler(errorLoc);
};
- onKeyDown = (e: SyntheticKeyboardEvent) => {
+ onKeyDown = (e: SyntheticKeyboardEvent<>) => {
if (e.key === 'Enter') {
- this.openInEditor();
+ this.editorHandler();
}
};
@@ -152,26 +155,25 @@ class StackFrame extends Component {
}
}
- const canOpenInEditor = this.canOpenInEditor();
+ const canOpenInEditor =
+ this.getErrorLocation() !== null && this.props.editorHandler !== null;
return (
<div>
- <div>
- {functionName}
- </div>
+ <div>{functionName}</div>
<div style={linkStyle}>
<a
style={canOpenInEditor ? anchorStyle : null}
- onClick={canOpenInEditor ? this.openInEditor : null}
+ onClick={canOpenInEditor ? this.editorHandler : null}
onKeyDown={canOpenInEditor ? this.onKeyDown : null}
tabIndex={canOpenInEditor ? '0' : null}
>
{url}
</a>
</div>
- {codeBlockProps &&
+ {codeBlockProps && (
<span>
<a
- onClick={canOpenInEditor ? this.openInEditor : null}
+ onClick={canOpenInEditor ? this.editorHandler : null}
style={canOpenInEditor ? codeAnchorStyle : null}
>
<CodeBlock {...codeBlockProps} />
@@ -179,7 +181,8 @@ class StackFrame extends Component {
<button style={toggleStyle} onClick={this.toggleCompiled}>
{'View ' + (compiled ? 'source' : 'compiled')}
</button>
- </span>}
+ </span>
+ )}
</div>
);
}
diff --git a/packages/react-error-overlay/src/containers/StackFrameCodeBlock.js b/packages/react-error-overlay/src/containers/StackFrameCodeBlock.js
index 2ed685cff..9bd36e019 100644
--- a/packages/react-error-overlay/src/containers/StackFrameCodeBlock.js
+++ b/packages/react-error-overlay/src/containers/StackFrameCodeBlock.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -21,12 +19,16 @@ import codeFrame from 'babel-code-frame';
type StackFrameCodeBlockPropsType = {|
lines: ScriptLine[],
lineNum: number,
- columnNum: number,
+ columnNum: ?number,
contextSize: number,
main: boolean,
|};
-function StackFrameCodeBlock(props: StackFrameCodeBlockPropsType) {
+// Exact type workaround for spread operator.
+// See: https://github.com/facebook/flow/issues/2405
+type Exact<T> = $Shape<T>;
+
+function StackFrameCodeBlock(props: Exact<StackFrameCodeBlockPropsType>) {
const { lines, lineNum, columnNum, contextSize, main } = props;
const sourceCode = [];
let whiteSpace = Infinity;
diff --git a/packages/react-error-overlay/src/containers/StackTrace.js b/packages/react-error-overlay/src/containers/StackTrace.js
index 4cb20bce1..abec286a3 100644
--- a/packages/react-error-overlay/src/containers/StackTrace.js
+++ b/packages/react-error-overlay/src/containers/StackTrace.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -14,6 +12,9 @@ import Collapsible from '../components/Collapsible';
import { isInternalFile } from '../utils/isInternalFile';
import { isBultinErrorName } from '../utils/isBultinErrorName';
+import type { StackFrame as StackFrameType } from '../utils/stack-frame';
+import type { ErrorLocation } from '../utils/parseCompileError';
+
const traceStyle = {
fontSize: '1em',
flex: '0 1 auto',
@@ -21,14 +22,16 @@ const traceStyle = {
overflow: 'auto',
};
-class StackTrace extends Component {
+type Props = {|
+ stackFrames: StackFrameType[],
+ errorName: string,
+ contextSize: number,
+ editorHandler: (errorLoc: ErrorLocation) => void,
+|};
+
+class StackTrace extends Component<Props> {
renderFrames() {
- const {
- stackFrames,
- errorName,
- contextSize,
- launchEditorEndpoint,
- } = this.props;
+ const { stackFrames, errorName, contextSize, editorHandler } = this.props;
const renderedFrames = [];
let hasReachedAppCode = false,
currentBundle = [],
@@ -52,7 +55,7 @@ class StackTrace extends Component {
contextSize={contextSize}
critical={index === 0}
showCode={!shouldCollapse}
- launchEditorEndpoint={launchEditorEndpoint}
+ editorHandler={editorHandler}
/>
);
const lastElement = index === stackFrames.length - 1;
@@ -84,11 +87,7 @@ class StackTrace extends Component {
}
render() {
- return (
- <div style={traceStyle}>
- {this.renderFrames()}
- </div>
- );
+ return <div style={traceStyle}>{this.renderFrames()}</div>;
}
}
diff --git a/packages/react-error-overlay/src/effects/proxyConsole.js b/packages/react-error-overlay/src/effects/proxyConsole.js
index ec50ae2ca..db270e9dd 100644
--- a/packages/react-error-overlay/src/effects/proxyConsole.js
+++ b/packages/react-error-overlay/src/effects/proxyConsole.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/effects/stackTraceLimit.js b/packages/react-error-overlay/src/effects/stackTraceLimit.js
index ea109cd98..a30ba856f 100644
--- a/packages/react-error-overlay/src/effects/stackTraceLimit.js
+++ b/packages/react-error-overlay/src/effects/stackTraceLimit.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/effects/unhandledError.js b/packages/react-error-overlay/src/effects/unhandledError.js
index 12f256c0e..d34253f75 100644
--- a/packages/react-error-overlay/src/effects/unhandledError.js
+++ b/packages/react-error-overlay/src/effects/unhandledError.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/effects/unhandledRejection.js b/packages/react-error-overlay/src/effects/unhandledRejection.js
index 638729e8d..e7292e9a0 100644
--- a/packages/react-error-overlay/src/effects/unhandledRejection.js
+++ b/packages/react-error-overlay/src/effects/unhandledRejection.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/iframeScript.js b/packages/react-error-overlay/src/iframeScript.js
new file mode 100644
index 000000000..3da820264
--- /dev/null
+++ b/packages/react-error-overlay/src/iframeScript.js
@@ -0,0 +1,62 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import './utils/pollyfills.js';
+import React from 'react';
+import ReactDOM from 'react-dom';
+import CompileErrorContainer from './containers/CompileErrorContainer';
+import RuntimeErrorContainer from './containers/RuntimeErrorContainer';
+import { overlayStyle } from './styles';
+import { applyStyles } from './utils/dom/css';
+
+let iframeRoot = null;
+
+function render({
+ currentBuildError,
+ currentRuntimeErrorRecords,
+ dismissRuntimeErrors,
+ editorHandler,
+}) {
+ if (currentBuildError) {
+ return (
+ <CompileErrorContainer
+ error={currentBuildError}
+ editorHandler={editorHandler}
+ />
+ );
+ }
+ if (currentRuntimeErrorRecords.length > 0) {
+ return (
+ <RuntimeErrorContainer
+ errorRecords={currentRuntimeErrorRecords}
+ close={dismissRuntimeErrors}
+ editorHandler={editorHandler}
+ />
+ );
+ }
+ return null;
+}
+
+window.updateContent = function updateContent(errorOverlayProps) {
+ let renderedElement = render(errorOverlayProps);
+
+ if (renderedElement === null) {
+ ReactDOM.unmountComponentAtNode(iframeRoot);
+ return false;
+ }
+ // Update the overlay
+ ReactDOM.render(renderedElement, iframeRoot);
+ return true;
+};
+
+document.body.style.margin = '0';
+// Keep popup within body boundaries for iOS Safari
+document.body.style['max-width'] = '100vw';
+iframeRoot = document.createElement('div');
+applyStyles(iframeRoot, overlayStyle);
+document.body.appendChild(iframeRoot);
+window.parent.__REACT_ERROR_OVERLAY_GLOBAL_HOOK__.iframeReady();
diff --git a/packages/react-error-overlay/src/index.js b/packages/react-error-overlay/src/index.js
index 168baa7ef..b09af07ee 100644
--- a/packages/react-error-overlay/src/index.js
+++ b/packages/react-error-overlay/src/index.js
@@ -1,38 +1,47 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
-import React from 'react';
-import ReactDOM from 'react-dom';
-import CompileErrorContainer from './containers/CompileErrorContainer';
-import RuntimeErrorContainer from './containers/RuntimeErrorContainer';
import { listenToRuntimeErrors } from './listenToRuntimeErrors';
-import { iframeStyle, overlayStyle } from './styles';
+import { iframeStyle } from './styles';
import { applyStyles } from './utils/dom/css';
+// Importing iframe-bundle generated in the pre build step as
+// a text using webpack raw-loader. See webpack.config.js file.
+// $FlowFixMe
+import iframeScript from 'iframeScript';
+
import type { ErrorRecord } from './listenToRuntimeErrors';
+import type { ErrorLocation } from './utils/parseCompileError';
type RuntimeReportingOptions = {|
onError: () => void,
- launchEditorEndpoint: string,
filename?: string,
|};
+type EditorHandler = (errorLoc: ErrorLocation) => void;
+
let iframe: null | HTMLIFrameElement = null;
let isLoadingIframe: boolean = false;
+var isIframeReady: boolean = false;
-let renderedElement: null | React.Element<any> = null;
+let editorHandler: null | EditorHandler = null;
let currentBuildError: null | string = null;
let currentRuntimeErrorRecords: Array<ErrorRecord> = [];
let currentRuntimeErrorOptions: null | RuntimeReportingOptions = null;
let stopListeningToRuntimeErrors: null | (() => void) = null;
+export function setEditorHandler(handler: EditorHandler | null) {
+ editorHandler = handler;
+ if (iframe) {
+ update();
+ }
+}
+
export function reportBuildError(error: string) {
currentBuildError = error;
update();
@@ -47,6 +56,13 @@ export function startReportingRuntimeErrors(options: RuntimeReportingOptions) {
if (stopListeningToRuntimeErrors !== null) {
throw new Error('Already listening');
}
+ if (options.launchEditorEndpoint) {
+ console.warn(
+ 'Warning: `startReportingRuntimeErrors` doesn’t accept ' +
+ '`launchEditorEndpoint` argument anymore. Use `listenToOpenInEditor` ' +
+ 'instead with your own implementation to open errors in editor '
+ );
+ }
currentRuntimeErrorOptions = options;
listenToRuntimeErrors(errorRecord => {
try {
@@ -71,7 +87,7 @@ function handleRuntimeError(errorRecord) {
update();
}
-function dismissRuntimeErrors() {
+export function dismissRuntimeErrors() {
currentRuntimeErrorRecords = [];
update();
}
@@ -89,15 +105,14 @@ export function stopReportingRuntimeErrors() {
}
function update() {
- renderedElement = render();
// Loading iframe can be either sync or async depending on the browser.
if (isLoadingIframe) {
// Iframe is loading.
// First render will happen soon--don't need to do anything.
return;
}
- if (iframe) {
- // Iframe has already loaded.
+ if (isIframeReady) {
+ // Iframe is ready.
// Just update it.
updateIframeContent();
return;
@@ -109,58 +124,53 @@ function update() {
loadingIframe.onload = function() {
const iframeDocument = loadingIframe.contentDocument;
if (iframeDocument != null && iframeDocument.body != null) {
- iframeDocument.body.style.margin = '0';
- // Keep popup within body boundaries for iOS Safari
- iframeDocument.body.style['max-width'] = '100vw';
- const iframeRoot = iframeDocument.createElement('div');
- applyStyles(iframeRoot, overlayStyle);
- iframeDocument.body.appendChild(iframeRoot);
-
- // Ready! Now we can update the UI.
iframe = loadingIframe;
- isLoadingIframe = false;
- updateIframeContent();
+ const script = loadingIframe.contentWindow.document.createElement(
+ 'script'
+ );
+ script.type = 'text/javascript';
+ script.innerHTML = iframeScript;
+ iframeDocument.body.appendChild(script);
}
};
const appDocument = window.document;
appDocument.body.appendChild(loadingIframe);
}
-function render() {
- if (currentBuildError) {
- return <CompileErrorContainer error={currentBuildError} />;
- }
- if (currentRuntimeErrorRecords.length > 0) {
- if (!currentRuntimeErrorOptions) {
- throw new Error('Expected options to be injected.');
- }
- return (
- <RuntimeErrorContainer
- errorRecords={currentRuntimeErrorRecords}
- close={dismissRuntimeErrors}
- launchEditorEndpoint={currentRuntimeErrorOptions.launchEditorEndpoint}
- />
- );
+function updateIframeContent() {
+ if (!currentRuntimeErrorOptions) {
+ throw new Error('Expected options to be injected.');
}
- return null;
-}
-function updateIframeContent() {
- if (iframe === null) {
+ if (!iframe) {
throw new Error('Iframe has not been created yet.');
}
- const iframeBody = iframe.contentDocument.body;
- if (!iframeBody) {
- throw new Error('Expected iframe to have a body.');
- }
- const iframeRoot = iframeBody.firstChild;
- if (renderedElement === null) {
- // Destroy iframe and force it to be recreated on next error
+
+ const isRendered = iframe.contentWindow.updateContent({
+ currentBuildError,
+ currentRuntimeErrorRecords,
+ dismissRuntimeErrors,
+ editorHandler,
+ });
+
+ if (!isRendered) {
window.document.body.removeChild(iframe);
- ReactDOM.unmountComponentAtNode(iframeRoot);
iframe = null;
- return;
+ isIframeReady = false;
}
- // Update the overlay
- ReactDOM.render(renderedElement, iframeRoot);
+}
+
+window.__REACT_ERROR_OVERLAY_GLOBAL_HOOK__ =
+ window.__REACT_ERROR_OVERLAY_GLOBAL_HOOK__ || {};
+window.__REACT_ERROR_OVERLAY_GLOBAL_HOOK__.iframeReady = function iframeReady() {
+ isIframeReady = true;
+ isLoadingIframe = false;
+ updateIframeContent();
+};
+
+if (process.env.NODE_ENV === 'production') {
+ console.warn(
+ 'react-error-overlay is not meant for use in production. You should ' +
+ 'ensure it is not included in your build to reduce bundle size.'
+ );
}
diff --git a/packages/react-error-overlay/src/listenToRuntimeErrors.js b/packages/react-error-overlay/src/listenToRuntimeErrors.js
index 341200afa..8146b377c 100644
--- a/packages/react-error-overlay/src/listenToRuntimeErrors.js
+++ b/packages/react-error-overlay/src/listenToRuntimeErrors.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/styles.js b/packages/react-error-overlay/src/styles.js
index d6557c5d9..077406285 100644
--- a/packages/react-error-overlay/src/styles.js
+++ b/packages/react-error-overlay/src/styles.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/dom/absolutifyCaret.js b/packages/react-error-overlay/src/utils/dom/absolutifyCaret.js
index d92167530..f0f87e495 100644
--- a/packages/react-error-overlay/src/utils/dom/absolutifyCaret.js
+++ b/packages/react-error-overlay/src/utils/dom/absolutifyCaret.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/dom/css.js b/packages/react-error-overlay/src/utils/dom/css.js
index 60b214b07..4f2dbf53c 100644
--- a/packages/react-error-overlay/src/utils/dom/css.js
+++ b/packages/react-error-overlay/src/utils/dom/css.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/generateAnsiHTML.js b/packages/react-error-overlay/src/utils/generateAnsiHTML.js
index 509daddc2..306165e85 100644
--- a/packages/react-error-overlay/src/utils/generateAnsiHTML.js
+++ b/packages/react-error-overlay/src/utils/generateAnsiHTML.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/getLinesAround.js b/packages/react-error-overlay/src/utils/getLinesAround.js
index 7cb2ea5c5..4a7ffc341 100644
--- a/packages/react-error-overlay/src/utils/getLinesAround.js
+++ b/packages/react-error-overlay/src/utils/getLinesAround.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/getPrettyURL.js b/packages/react-error-overlay/src/utils/getPrettyURL.js
index 47b834d08..1aa5dc779 100644
--- a/packages/react-error-overlay/src/utils/getPrettyURL.js
+++ b/packages/react-error-overlay/src/utils/getPrettyURL.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/getSourceMap.js b/packages/react-error-overlay/src/utils/getSourceMap.js
index 1d8405519..269f0bb71 100644
--- a/packages/react-error-overlay/src/utils/getSourceMap.js
+++ b/packages/react-error-overlay/src/utils/getSourceMap.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -77,7 +75,10 @@ class SourceMap {
}
}
-function extractSourceMapUrl(fileUri: string, fileContents: string) {
+function extractSourceMapUrl(
+ fileUri: string,
+ fileContents: string
+): Promise<string> {
const regex = /\/\/[#@] ?sourceMappingURL=([^\s'"]+)\s*$/gm;
let match = null;
for (;;) {
diff --git a/packages/react-error-overlay/src/utils/getStackFrames.js b/packages/react-error-overlay/src/utils/getStackFrames.js
index e5a407310..9721e316c 100644
--- a/packages/react-error-overlay/src/utils/getStackFrames.js
+++ b/packages/react-error-overlay/src/utils/getStackFrames.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/isBultinErrorName.js b/packages/react-error-overlay/src/utils/isBultinErrorName.js
index cf732b838..570f72cfe 100644
--- a/packages/react-error-overlay/src/utils/isBultinErrorName.js
+++ b/packages/react-error-overlay/src/utils/isBultinErrorName.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/isInternalFile.js b/packages/react-error-overlay/src/utils/isInternalFile.js
index c78bbe3ed..97dbeaae5 100644
--- a/packages/react-error-overlay/src/utils/isInternalFile.js
+++ b/packages/react-error-overlay/src/utils/isInternalFile.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/mapper.js b/packages/react-error-overlay/src/utils/mapper.js
index 656c216c1..92407be53 100644
--- a/packages/react-error-overlay/src/utils/mapper.js
+++ b/packages/react-error-overlay/src/utils/mapper.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/parseCompileError.js b/packages/react-error-overlay/src/utils/parseCompileError.js
new file mode 100644
index 000000000..2c9b6e60e
--- /dev/null
+++ b/packages/react-error-overlay/src/utils/parseCompileError.js
@@ -0,0 +1,57 @@
+// @flow
+import Anser from 'anser';
+
+export type ErrorLocation = {|
+ fileName: string,
+ lineNumber: number,
+|};
+
+const filePathRegex = /^\.(\/[^/\n ]+)+\.[^/\n ]+$/;
+
+const lineNumberRegexes = [
+ // Babel syntax errors
+ // Based on syntax error formating of babylon parser
+ // https://github.com/babel/babylon/blob/v7.0.0-beta.22/src/parser/location.js#L19
+ /^.*\((\d+):(\d+)\)$/,
+
+ // ESLint errors
+ // Based on eslintFormatter in react-dev-utils
+ /^Line (\d+):.+$/,
+];
+
+// Based on error formatting of webpack
+// https://github.com/webpack/webpack/blob/v3.5.5/lib/Stats.js#L183-L217
+function parseCompileError(message: string): ?ErrorLocation {
+ const lines: Array<string> = message.split('\n');
+ let fileName: string = '';
+ let lineNumber: number = 0;
+
+ for (let i = 0; i < lines.length; i++) {
+ const line: string = Anser.ansiToText(lines[i]).trim();
+ if (!line) {
+ continue;
+ }
+
+ if (!fileName && line.match(filePathRegex)) {
+ fileName = line;
+ }
+
+ let k = 0;
+ while (k < lineNumberRegexes.length) {
+ const match: ?Array<string> = line.match(lineNumberRegexes[k]);
+ if (match) {
+ lineNumber = parseInt(match[1], 10);
+ break;
+ }
+ k++;
+ }
+
+ if (fileName && lineNumber) {
+ break;
+ }
+ }
+
+ return fileName && lineNumber ? { fileName, lineNumber } : null;
+}
+
+export default parseCompileError;
diff --git a/packages/react-error-overlay/src/utils/parser.js b/packages/react-error-overlay/src/utils/parser.js
index 1cbee1d1c..2e8afaa8b 100644
--- a/packages/react-error-overlay/src/utils/parser.js
+++ b/packages/react-error-overlay/src/utils/parser.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -13,13 +11,16 @@ import StackFrame from './stack-frame';
const regexExtractLocation = /\(?(.+?)(?::(\d+))?(?::(\d+))?\)?$/;
function extractLocation(token: string): [string, number, number] {
- return regexExtractLocation.exec(token).slice(1).map(v => {
- const p = Number(v);
- if (!isNaN(p)) {
- return p;
- }
- return v;
- });
+ return regexExtractLocation
+ .exec(token)
+ .slice(1)
+ .map(v => {
+ const p = Number(v);
+ if (!isNaN(p)) {
+ return p;
+ }
+ return v;
+ });
}
const regexValidFrame_Chrome = /^\s*(at|in)\s.+(:\d+)/;
@@ -55,7 +56,10 @@ function parseStack(stack: string[]): StackFrame[] {
if (e.indexOf('(at ') !== -1) {
e = e.replace(/\(at /, '(');
}
- const data = e.trim().split(/\s+/g).slice(1);
+ const data = e
+ .trim()
+ .split(/\s+/g)
+ .slice(1);
const last = data.pop();
return new StackFrame(data.join(' ') || null, ...extractLocation(last));
}
diff --git a/packages/react-error-overlay/src/utils/pollyfills.js b/packages/react-error-overlay/src/utils/pollyfills.js
new file mode 100644
index 000000000..ddd5aeb96
--- /dev/null
+++ b/packages/react-error-overlay/src/utils/pollyfills.js
@@ -0,0 +1,18 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+if (typeof Promise === 'undefined') {
+ // Rejection tracking prevents a common issue where React gets into an
+ // inconsistent state due to an error, but it gets swallowed by a Promise,
+ // and the user has no idea what causes React's erratic future behavior.
+ require('promise/lib/rejection-tracking').enable();
+ window.Promise = require('promise/lib/es6-extensions.js');
+}
+
+// Object.assign() is commonly used with React.
+// It will use the native implementation if it's present and isn't buggy.
+Object.assign = require('object-assign');
diff --git a/packages/react-error-overlay/src/utils/stack-frame.js b/packages/react-error-overlay/src/utils/stack-frame.js
index 49f9da7fa..41defc061 100644
--- a/packages/react-error-overlay/src/utils/stack-frame.js
+++ b/packages/react-error-overlay/src/utils/stack-frame.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
diff --git a/packages/react-error-overlay/src/utils/unmapper.js b/packages/react-error-overlay/src/utils/unmapper.js
index 60b2bee43..c61fad4fb 100644
--- a/packages/react-error-overlay/src/utils/unmapper.js
+++ b/packages/react-error-overlay/src/utils/unmapper.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
@@ -56,7 +54,11 @@ async function unmap(
}
let { fileName } = frame;
if (fileName) {
- fileName = path.normalize(fileName);
+ // The web version of this module only provides POSIX support, so Windows
+ // paths like C:\foo\\baz\..\\bar\ cannot be normalized.
+ // A simple solution to this is to replace all `\` with `/`, then
+ // normalize afterwards.
+ fileName = path.normalize(fileName.replace(/[\\]+/g, '/'));
}
if (fileName == null) {
return frame;
@@ -64,6 +66,7 @@ async function unmap(
const fN: string = fileName;
const source = map
.getSources()
+ // Prepare path for normalization; see comment above for reasoning.
.map(s => s.replace(/[\\]+/g, '/'))
.filter(p => {
p = path.normalize(p);
diff --git a/packages/react-error-overlay/src/utils/warnings.js b/packages/react-error-overlay/src/utils/warnings.js
index bcc54ceb7..4a99190ac 100644
--- a/packages/react-error-overlay/src/utils/warnings.js
+++ b/packages/react-error-overlay/src/utils/warnings.js
@@ -1,17 +1,18 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
/* @flow */
import type { ReactFrame } from '../effects/proxyConsole';
function stripInlineStacktrace(message: string): string {
- return message.split('\n').filter(line => !line.match(/^\s*in/)).join('\n'); // " in Foo"
+ return message
+ .split('\n')
+ .filter(line => !line.match(/^\s*in/))
+ .join('\n'); // " in Foo"
}
function massage(
diff --git a/packages/react-error-overlay/webpack.config.iframe.js b/packages/react-error-overlay/webpack.config.iframe.js
new file mode 100644
index 000000000..c80b15afa
--- /dev/null
+++ b/packages/react-error-overlay/webpack.config.iframe.js
@@ -0,0 +1,48 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+'use strict';
+
+const path = require('path');
+const webpack = require('webpack');
+
+module.exports = {
+ entry: './src/iframeScript.js',
+ output: {
+ path: path.join(__dirname, './lib'),
+ filename: 'iframe-bundle.js',
+ },
+ module: {
+ rules: [
+ {
+ test: /\.js$/,
+ include: path.resolve(__dirname, './src'),
+ use: 'babel-loader',
+ },
+ ],
+ },
+ plugins: [
+ new webpack.DefinePlugin({
+ // We set process.env.NODE_ENV to 'production' so that React is built
+ // in production mode.
+ 'process.env': { NODE_ENV: '"production"' },
+ // This prevents our bundled React from accidentally hijacking devtools.
+ __REACT_DEVTOOLS_GLOBAL_HOOK__: '({})',
+ }),
+ // This code is embedded as a string, so it would never be optimized
+ // elsewhere.
+ new webpack.optimize.UglifyJsPlugin({
+ compress: {
+ warnings: false,
+ comparisons: false,
+ },
+ output: {
+ comments: false,
+ ascii_only: false,
+ },
+ }),
+ ],
+};
diff --git a/packages/react-error-overlay/webpack.config.js b/packages/react-error-overlay/webpack.config.js
new file mode 100644
index 000000000..bc8b363f7
--- /dev/null
+++ b/packages/react-error-overlay/webpack.config.js
@@ -0,0 +1,37 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+'use strict';
+
+const path = require('path');
+
+module.exports = {
+ entry: './src/index.js',
+ output: {
+ path: path.join(__dirname, './lib'),
+ filename: 'index.js',
+ library: 'ReactErrorOverlay',
+ libraryTarget: 'umd',
+ },
+ module: {
+ rules: [
+ {
+ test: /iframe-bundle\.js$/,
+ use: 'raw-loader',
+ },
+ {
+ test: /\.js$/,
+ include: path.resolve(__dirname, './src'),
+ use: 'babel-loader',
+ },
+ ],
+ },
+ resolve: {
+ alias: {
+ iframeScript$: path.resolve(__dirname, './lib/iframe-bundle.js'),
+ },
+ },
+};
diff --git a/packages/react-scripts/bin/react-scripts-ts.js b/packages/react-scripts/bin/react-scripts-ts.js
index bc7f8f7dc..a4d1b11b1 100755
--- a/packages/react-scripts/bin/react-scripts-ts.js
+++ b/packages/react-scripts/bin/react-scripts-ts.js
@@ -1,11 +1,9 @@
#!/usr/bin/env node
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js
index ebef79ed9..fa42747f6 100644
--- a/packages/react-scripts/config/env.js
+++ b/packages/react-scripts/config/env.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/config/jest/babelTransform.js b/packages/react-scripts/config/jest/babelTransform.js
new file mode 100644
index 000000000..02742e90c
--- /dev/null
+++ b/packages/react-scripts/config/jest/babelTransform.js
@@ -0,0 +1,15 @@
+// @remove-file-on-eject
+/**
+ * Copyright (c) 2014-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+'use strict';
+
+const babelJest = require('babel-jest');
+
+module.exports = babelJest.createTransformer({
+ presets: [require.resolve('babel-preset-react-app')],
+ babelrc: false,
+});
diff --git a/packages/react-scripts/config/jest/cssTransform.js b/packages/react-scripts/config/jest/cssTransform.js
index 0a9849f1f..99a8cb269 100644
--- a/packages/react-scripts/config/jest/cssTransform.js
+++ b/packages/react-scripts/config/jest/cssTransform.js
@@ -1,10 +1,9 @@
// @remove-on-eject-begin
/**
- * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
+ * Copyright (c) 2014-present, Facebook, Inc.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/config/jest/fileTransform.js b/packages/react-scripts/config/jest/fileTransform.js
index 89027bdc7..8f9b843ab 100644
--- a/packages/react-scripts/config/jest/fileTransform.js
+++ b/packages/react-scripts/config/jest/fileTransform.js
@@ -1,10 +1,9 @@
// @remove-on-eject-begin
/**
- * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
+ * Copyright (c) 2014-present, Facebook, Inc.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/config/paths.js b/packages/react-scripts/config/paths.js
index e860d9b04..c397bb431 100644
--- a/packages/react-scripts/config/paths.js
+++ b/packages/react-scripts/config/paths.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/config/polyfills.js b/packages/react-scripts/config/polyfills.js
index 14031a168..8d97fb4ac 100644
--- a/packages/react-scripts/config/polyfills.js
+++ b/packages/react-scripts/config/polyfills.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
@@ -24,3 +22,9 @@ require('whatwg-fetch');
// Object.assign() is commonly used with React.
// It will use the native implementation if it's present and isn't buggy.
Object.assign = require('object-assign');
+
+// In tests, polyfill requestAnimationFrame since jsdom doesn't provide it yet.
+// We don't polyfill it in the browser--this is user's responsibility.
+if (process.env.NODE_ENV === 'test') {
+ require('raf').polyfill(global);
+}
diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js
index 07c0a3adf..f24e0ac46 100644
--- a/packages/react-scripts/config/webpack.config.dev.js
+++ b/packages/react-scripts/config/webpack.config.dev.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
@@ -62,8 +60,6 @@ module.exports = {
// changing JS code would still trigger a refresh.
],
output: {
- // Next line is not used in dev but WebpackDevServer crashes without it:
- path: paths.appBuild,
// Add /* filename */ comments to generated require()s in the output.
pathinfo: true,
// This does not produce a real file. It's just the virtual path that is
@@ -93,17 +89,7 @@ module.exports = {
// https://github.com/facebookincubator/create-react-app/issues/290
// `web` extension prefixes have been added for better support
// for React Native Web.
- extensions: [
- '.web.ts',
- '.ts',
- '.web.tsx',
- '.tsx',
- '.web.js',
- '.js',
- '.json',
- '.web.jsx',
- '.jsx',
- ],
+ extensions: ['.web.ts', '.ts', '.web.tsx', '.tsx', '.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],
alias: {
// @remove-on-eject-begin
// Resolve Babel runtime relative to react-scripts.
@@ -170,6 +156,22 @@ module.exports = {
include: paths.appSrc,
loader: require.resolve('ts-loader'),
},
+ // Process JS with Babel.
+ {
+ test: /\.(js|jsx|mjs)$/,
+ include: paths.appSrc,
+ loader: require.resolve('babel-loader'),
+ options: {
+ // @remove-on-eject-begin
+ babelrc: false,
+ presets: [require.resolve('babel-preset-react-app')],
+ // @remove-on-eject-end
+ // This is a feature of `babel-loader` for webpack (not Babel itself).
+ // It enables caching results in ./node_modules/.cache/babel-loader/
+ // directory for faster rebuilds.
+ cacheDirectory: true,
+ },
+ },
// "postcss" loader applies autoprefixer to our CSS.
// "css" loader resolves paths in CSS and adds assets as dependencies.
// "style" loader turns CSS into JS modules that inject <style> tags.
@@ -210,7 +212,7 @@ module.exports = {
// "file" loader makes sure those assets get served by WebpackDevServer.
// When you `import` an asset, you get its (virtual) filename.
// In production, they would get copied to the `build` folder.
- // This loader don't uses a "test" so it will catch all modules
+ // This loader doesn't use a "test" so it will catch all modules
// that fall through the other loaders.
{
// Exclude `js` files to keep "css" loader working as it injects
diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js
index 9582ee731..a9d9e13e0 100644
--- a/packages/react-scripts/config/webpack.config.prod.js
+++ b/packages/react-scripts/config/webpack.config.prod.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
@@ -97,17 +95,7 @@ module.exports = {
// https://github.com/facebookincubator/create-react-app/issues/290
// `web` extension prefixes have been added for better support
// for React Native Web.
- extensions: [
- '.web.ts',
- '.ts',
- '.web.tsx',
- '.tsx',
- '.web.js',
- '.js',
- '.json',
- '.web.jsx',
- '.jsx',
- ],
+ extensions: ['.web.ts', '.ts', '.web.tsx', '.tsx', '.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],
alias: {
// @remove-on-eject-begin
// Resolve Babel runtime relative to react-scripts.
@@ -139,7 +127,7 @@ module.exports = {
// { parser: { requireEnsure: false } },
// First, run the linter.
- // It's important to do this before Typescript runs.
+ // It's important to do this before Babel processes the JS.
{
test: /\.(ts|tsx)$/,
loader: require.resolve('tslint-loader'),
@@ -173,6 +161,19 @@ module.exports = {
include: paths.appSrc,
loader: require.resolve('ts-loader')
},
+ // Process JS with Babel.
+ {
+ test: /\.(js|jsx|mjs)$/,
+ include: paths.appSrc,
+ loader: require.resolve('babel-loader'),
+ options: {
+ // @remove-on-eject-begin
+ babelrc: false,
+ presets: [require.resolve('babel-preset-react-app')],
+ // @remove-on-eject-end
+ compact: true,
+ },
+ },
// The notation here is somewhat confusing.
// "postcss" loader applies autoprefixer to our CSS.
// "css" loader resolves paths in CSS and adds assets as dependencies.
@@ -190,7 +191,12 @@ module.exports = {
loader: ExtractTextPlugin.extract(
Object.assign(
{
- fallback: require.resolve('style-loader'),
+ fallback: {
+ loader: require.resolve('style-loader'),
+ options: {
+ hmr: false,
+ },
+ },
use: [
{
loader: require.resolve('css-loader'),
@@ -229,7 +235,7 @@ module.exports = {
},
// "file" loader makes sure assets end up in the `build` folder.
// When you `import` an asset, you get its filename.
- // This loader don't uses a "test" so it will catch all modules
+ // This loader doesn't use a "test" so it will catch all modules
// that fall through the other loaders.
{
loader: require.resolve('file-loader'),
@@ -287,6 +293,9 @@ module.exports = {
// https://github.com/mishoo/UglifyJS2/issues/2011
comparisons: false,
},
+ mangle: {
+ safari10: true,
+ },
output: {
comments: false,
// Turned on because emoji and regex is not minified properly using default
diff --git a/packages/react-scripts/config/webpackDevServer.config.js b/packages/react-scripts/config/webpackDevServer.config.js
index 9c3889aba..3c9c6cf0c 100644
--- a/packages/react-scripts/config/webpackDevServer.config.js
+++ b/packages/react-scripts/config/webpackDevServer.config.js
@@ -1,17 +1,16 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
const errorOverlayMiddleware = require('react-dev-utils/errorOverlayMiddleware');
const noopServiceWorkerMiddleware = require('react-dev-utils/noopServiceWorkerMiddleware');
+const ignoredFiles = require('react-dev-utils/ignoredFiles');
const config = require('./webpack.config.dev');
const paths = require('./paths');
@@ -74,8 +73,10 @@ module.exports = function(proxy, allowedHost) {
quiet: true,
// Reportedly, this avoids CPU overload on some systems.
// https://github.com/facebookincubator/create-react-app/issues/293
+ // src/node_modules is not ignored to support absolute imports
+ // https://github.com/facebookincubator/create-react-app/issues/1065
watchOptions: {
- ignored: /node_modules/,
+ ignored: ignoredFiles(paths.appSrc),
},
// Enable HTTPS if the HTTPS environment variable is set to 'true'
https: protocol === 'https',
@@ -88,7 +89,7 @@ module.exports = function(proxy, allowedHost) {
},
public: allowedHost,
proxy,
- setup(app) {
+ before(app) {
// This lets us open files from the runtime error overlay.
app.use(errorOverlayMiddleware());
// This service worker file is effectively a 'no-op' that will reset any
diff --git a/packages/react-scripts/fixtures/kitchensink/integration/env.test.js b/packages/react-scripts/fixtures/kitchensink/integration/env.test.js
index a7d4ff2a2..5138bc513 100644
--- a/packages/react-scripts/fixtures/kitchensink/integration/env.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/integration/env.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { expect } from 'chai';
diff --git a/packages/react-scripts/fixtures/kitchensink/integration/initDOM.js b/packages/react-scripts/fixtures/kitchensink/integration/initDOM.js
index b865b5641..3d0eb7a1c 100644
--- a/packages/react-scripts/fixtures/kitchensink/integration/initDOM.js
+++ b/packages/react-scripts/fixtures/kitchensink/integration/initDOM.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
const fs = require('fs');
diff --git a/packages/react-scripts/fixtures/kitchensink/integration/syntax.test.js b/packages/react-scripts/fixtures/kitchensink/integration/syntax.test.js
index fc2a717be..82e2c9e0d 100644
--- a/packages/react-scripts/fixtures/kitchensink/integration/syntax.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/integration/syntax.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { expect } from 'chai';
diff --git a/packages/react-scripts/fixtures/kitchensink/integration/webpack.test.js b/packages/react-scripts/fixtures/kitchensink/integration/webpack.test.js
index e3845e79e..1fe5c9f64 100644
--- a/packages/react-scripts/fixtures/kitchensink/integration/webpack.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/integration/webpack.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import { expect } from 'chai';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/App.js b/packages/react-scripts/fixtures/kitchensink/src/App.js
index cb342b062..5fe13accf 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/App.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/App.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component, createElement } from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/absoluteLoad.js b/packages/react-scripts/fixtures/kitchensink/src/absoluteLoad.js
index 0d01bc0a2..5c4f7842e 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/absoluteLoad.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/absoluteLoad.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
export default () => [
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.js
index 03d638471..c601d2efd 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.js
@@ -1,15 +1,13 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
-export default () =>
+export default () => (
<span>
<span id="feature-file-env-original-1">
{process.env.REACT_APP_ORIGINAL_1}
@@ -21,7 +19,6 @@ export default () =>
{process.env.REACT_APP_DEVELOPMENT}
{process.env.REACT_APP_PRODUCTION}
</span>
- <span id="feature-file-env-x">
- {process.env.REACT_APP_X}
- </span>
- </span>;
+ <span id="feature-file-env-x">{process.env.REACT_APP_X}</span>
+ </span>
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.test.js
index 5a0fed4c6..8c628d215 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/FileEnvVariables.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js
index 6d2437a64..f14c5d24f 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -33,11 +31,7 @@ export default class extends Component {
render() {
return (
<div id="feature-node-path">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js
index 7e076dade..1de025d2f 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.js
index af87748e6..f3df96a35 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.js
@@ -1,15 +1,12 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
-export default () =>
- <span id="feature-public-url">
- {process.env.PUBLIC_URL}.
- </span>;
+export default () => (
+ <span id="feature-public-url">{process.env.PUBLIC_URL}.</span>
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.test.js
index c9e1be0e9..bda2e051f 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/PublicUrl.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.js
index 400dfc013..2543779ac 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.js
@@ -1,15 +1,14 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
-export default () =>
+export default () => (
<span id="feature-shell-env-variables">
{process.env.REACT_APP_SHELL_ENV_MESSAGE}.
- </span>;
+ </span>
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.test.js
index 137076975..c1f5001cd 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/env/ShellEnvVariables.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js
index de0576549..be605a01c 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -38,11 +36,7 @@ export default class extends Component {
<div id="feature-array-destructuring">
{this.state.users.map(user => {
const [id, name] = user;
- return (
- <div key={id}>
- {name}
- </div>
- );
+ return <div key={id}>{name}</div>;
})}
</div>
);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js
index 42dde0f1c..e6ab4c9f2 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js
index ebf90ef6e..be696ffa2 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-array-spread">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js
index 9ed7633ea..4827bc222 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js
index c91da311d..ae135133b 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-async-await">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js
index 027139817..b056cb705 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js
index 58ae10763..b1a063cf0 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -29,11 +27,7 @@ export default class extends Component {
render() {
return (
<div id="feature-class-properties">
- {this.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js
index 5b038e76d..3ba3074a3 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js
index fcbf721e8..ad27b8bb2 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,9 @@ export default class extends Component {
render() {
return (
<div id="feature-computed-properties">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.user_name}
- </div>
- )}
+ {this.state.users.map(user => (
+ <div key={user.id}>{user.user_name}</div>
+ ))}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js
index 91b697fe0..0442a6bc1 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js
index ab648255a..9d894de13 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -53,11 +51,11 @@ export default class extends Component {
return (
<div id="feature-custom-interpolation">
- {this.state.users.map(user =>
+ {this.state.users.map(user => (
<div key={user.id} style={veryInlineStyle}>
{user.name}
</div>
- )}
+ ))}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js
index ac468db76..854f3cebd 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js
index 6ebabaec7..d86a989cc 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-default-parameters">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js
index 26d5184eb..71c255200 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js
index aa8c9d7db..a69167d44 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -43,11 +41,7 @@ export default class extends Component {
render() {
return (
<div id="feature-destructuring-and-await">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js
index c7d74d801..ec9a9a9e1 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js
index 44b2776e1..7ad8fc8fa 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -43,11 +41,7 @@ export default class extends Component {
render() {
return (
<div id="feature-generators">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js
index 3bbe2d4f7..5b59d6664 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js
index 8a7b1095f..be519175f 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -43,11 +41,7 @@ export default class extends Component {
<div id="feature-object-destructuring">
{this.state.users.map(user => {
const { id, name } = user;
- return (
- <div key={id}>
- {name}
- </div>
- );
+ return <div key={id}>{name}</div>;
})}
</div>
);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js
index 503b2cb11..ea2b4bdc7 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js
index 5ff4e10ac..3c62e38c9 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,11 @@ export default class extends Component {
render() {
return (
<div id="feature-object-spread">
- {this.state.users.map(user =>
+ {this.state.users.map(user => (
<div key={user.id}>
{user.name}: {user.age}
</div>
- )}
+ ))}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js
index 09a92ce05..0f2aefd4e 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js
index 31ef2c9eb..f7fd34f0a 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -42,11 +40,7 @@ export default class extends Component {
render() {
return (
<div id="feature-promises">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js
index 88ba04fe3..ee2ce709f 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js
index 9e3e3fbab..3f22cc816 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-rest-and-default">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.test.js
index e48b7dc59..36fc91d4c 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.js
index 98a0e7edc..8e8c0b8b2 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-rest-parameters">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.test.js
index c1eb90e0d..9be970124 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.js
index b69f7ede8..9788ee5dc 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React, { Component } from 'react';
@@ -41,11 +39,7 @@ export default class extends Component {
render() {
return (
<div id="feature-template-interpolation">
- {this.state.users.map(user =>
- <div key={user.id}>
- {user.name}
- </div>
- )}
+ {this.state.users.map(user => <div key={user.id}>{user.name}</div>)}
</div>
);
}
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.test.js
index ff32baaed..10082088d 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.js
index ab7c9a2d8..868a886a2 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.test.js
index e315ee33b..7d85a6024 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/CssInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.js
index 8598d8d06..1a57bc36d 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.js
@@ -1,14 +1,13 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
import tiniestCat from './assets/tiniest-cat.jpg';
-export default () =>
- <img id="feature-image-inclusion" src={tiniestCat} alt="tiniest cat" />;
+export default () => (
+ <img id="feature-image-inclusion" src={tiniestCat} alt="tiniest cat" />
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.test.js
index 042d2da30..ffe9cafbc 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/ImageInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.js
index 66425c66c..653c3e744 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.js
@@ -1,16 +1,11 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
import { abstract } from './assets/abstract.json';
-export default () =>
- <summary id="feature-json-inclusion">
- {abstract}
- </summary>;
+export default () => <summary id="feature-json-inclusion">{abstract}</summary>;
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.test.js
index ee150f629..42f458df1 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/JsonInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.js
index 395ebd7ed..98ead2dec 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
@@ -16,9 +14,5 @@ export default () => {
if (!test() || v !== '2.0.0') {
throw new Error('Functionality test did not pass.');
}
- return (
- <p id="feature-linked-modules">
- {v}
- </p>
- );
+ return <p id="feature-linked-modules">{v}</p>;
};
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.test.js
index aa1e911ae..b850c2aa8 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/LinkedModules.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
index 086885db2..0eb794244 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
@@ -14,7 +12,8 @@ const text = aFileWithoutExt.includes('base64')
? atob(aFileWithoutExt.split('base64,')[1]).trim()
: aFileWithoutExt;
-export default () =>
+export default () => (
<a id="feature-no-ext-inclusion" href={text}>
aFileWithoutExt
- </a>;
+ </a>
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.test.js
index a08b5d21b..0d83b5f0c 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.js
index 8876021ae..c519423e6 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.test.js
index 585c6c19d..4b6a9a686 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/SvgInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
index c41a1e0c0..bdb81f178 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
@@ -14,7 +12,8 @@ const text = aFileWithExtUnknown.includes('base64')
? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
: aFileWithExtUnknown;
-export default () =>
+export default () => (
<a id="feature-unknown-ext-inclusion" href={text}>
aFileWithExtUnknown
- </a>;
+ </a>
+);
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.test.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.test.js
index 73a8016e1..538240dae 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.test.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.test.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/index.js b/packages/react-scripts/fixtures/kitchensink/src/index.js
index 46fb0dd2e..5268eacec 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/index.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/index.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
import React from 'react';
diff --git a/packages/react-scripts/fixtures/kitchensink/src/index.tsx b/packages/react-scripts/fixtures/kitchensink/src/index.tsx
new file mode 100644
index 000000000..d02ac72c0
--- /dev/null
+++ b/packages/react-scripts/fixtures/kitchensink/src/index.tsx
@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import * as React from 'react';
+import * as ReactDOM from 'react-dom';
+import App from './App';
+
+ReactDOM.render(<App />, document.getElementById('root'));
diff --git a/packages/react-scripts/fixtures/kitchensink/src/subfolder/lol.js b/packages/react-scripts/fixtures/kitchensink/src/subfolder/lol.js
index 979cb3e72..7eecce497 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/subfolder/lol.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/subfolder/lol.js
@@ -1,10 +1,8 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
module.exports = function() {
diff --git a/packages/react-scripts/fixtures/kitchensink/tsconfig.json b/packages/react-scripts/fixtures/kitchensink/tsconfig.json
new file mode 100644
index 000000000..5bbdba390
--- /dev/null
+++ b/packages/react-scripts/fixtures/kitchensink/tsconfig.json
@@ -0,0 +1,31 @@
+{
+ "compilerOptions": {
+ "outDir": "build/dist",
+ "module": "esnext",
+ "target": "es5",
+ "lib": ["es6", "dom"],
+ "sourceMap": true,
+ "allowJs": true,
+ "jsx": "react",
+ "moduleResolution": "node",
+ "rootDir": "src",
+ "forceConsistentCasingInFileNames": true,
+ "noImplicitReturns": true,
+ "noImplicitThis": true,
+ "noImplicitAny": true,
+ "strictNullChecks": true,
+ "suppressImplicitAnyIndexErrors": true,
+ "noUnusedLocals": true
+ },
+ "exclude": [
+ "node_modules",
+ "build",
+ "scripts",
+ "acceptance-tests",
+ "webpack",
+ "jest",
+ "src/setupTests.ts",
+ "config",
+ "integration"
+ ]
+}
diff --git a/packages/react-scripts/fixtures/kitchensink/tsconfig.test.json b/packages/react-scripts/fixtures/kitchensink/tsconfig.test.json
new file mode 100644
index 000000000..65ffdd493
--- /dev/null
+++ b/packages/react-scripts/fixtures/kitchensink/tsconfig.test.json
@@ -0,0 +1,6 @@
+{
+ "extends": "./tsconfig.json",
+ "compilerOptions": {
+ "module": "commonjs"
+ }
+}
\ No newline at end of file
diff --git a/packages/react-scripts/fixtures/kitchensink/tslint.json b/packages/react-scripts/fixtures/kitchensink/tslint.json
new file mode 100644
index 000000000..eb5d66a02
--- /dev/null
+++ b/packages/react-scripts/fixtures/kitchensink/tslint.json
@@ -0,0 +1,99 @@
+{
+ "extends": ["tslint-react"],
+ "rules": {
+ "align": [
+ true,
+ "parameters",
+ "arguments",
+ "statements"
+ ],
+ "ban": false,
+ "class-name": true,
+ "comment-format": [
+ true,
+ "check-space"
+ ],
+ "curly": true,
+ "eofline": false,
+ "forin": true,
+ "indent": [ true, "spaces" ],
+ "interface-name": [true, "never-prefix"],
+ "jsdoc-format": true,
+ "jsx-no-lambda": false,
+ "jsx-no-multiline-js": false,
+ "label-position": true,
+ "max-line-length": [ true, 120 ],
+ "member-ordering": [
+ true,
+ "public-before-private",
+ "static-before-instance",
+ "variables-before-functions"
+ ],
+ "no-any": true,
+ "no-arg": true,
+ "no-bitwise": true,
+ "no-console": [
+ true,
+ "log",
+ "error",
+ "debug",
+ "info",
+ "time",
+ "timeEnd",
+ "trace"
+ ],
+ "no-consecutive-blank-lines": true,
+ "no-construct": true,
+ "no-debugger": true,
+ "no-duplicate-variable": true,
+ "no-empty": true,
+ "no-eval": true,
+ "no-shadowed-variable": true,
+ "no-string-literal": true,
+ "no-switch-case-fall-through": true,
+ "no-trailing-whitespace": false,
+ "no-unused-expression": true,
+ "no-use-before-declare": true,
+ "one-line": [
+ true,
+ "check-catch",
+ "check-else",
+ "check-open-brace",
+ "check-whitespace"
+ ],
+ "quotemark": [true, "single", "jsx-double"],
+ "radix": true,
+ "semicolon": [true, "always"],
+ "switch-default": true,
+
+ "trailing-comma": [false],
+
+ "triple-equals": [ true, "allow-null-check" ],
+ "typedef": [
+ true,
+ "parameter",
+ "property-declaration"
+ ],
+ "typedef-whitespace": [
+ true,
+ {
+ "call-signature": "nospace",
+ "index-signature": "nospace",
+ "parameter": "nospace",
+ "property-declaration": "nospace",
+ "variable-declaration": "nospace"
+ }
+ ],
+ "variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore", "allow-pascal-case"],
+ "whitespace": [
+ true,
+ "check-branch",
+ "check-decl",
+ "check-module",
+ "check-operator",
+ "check-separator",
+ "check-type",
+ "check-typecast"
+ ]
+ }
+}
diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json
index 01bb852f5..3930fbafd 100644
--- a/packages/react-scripts/package.json
+++ b/packages/react-scripts/package.json
@@ -3,7 +3,7 @@
"version": "2.8.0",
"description": "Configuration and scripts for Create React App.",
"repository": "wmonk/create-react-app",
- "license": "BSD-3-Clause",
+ "license": "MIT",
"engines": {
"node": ">=6"
},
@@ -21,39 +21,46 @@
"react-scripts-ts": "./bin/react-scripts-ts.js"
},
"dependencies": {
- "autoprefixer": "7.1.2",
+ "autoprefixer": "7.1.6",
+ "babel-core": "6.26.0",
+ "babel-eslint": "7.2.3",
+ "babel-jest": "20.0.3",
+ "babel-loader": "7.1.2",
+ "babel-preset-react-app": "^3.1.0",
+ "babel-runtime": "6.26.0",
"case-sensitive-paths-webpack-plugin": "2.1.1",
"chalk": "1.1.3",
- "css-loader": "0.28.4",
+ "css-loader": "0.28.7",
"dotenv": "4.0.0",
- "extract-text-webpack-plugin": "3.0.0",
- "file-loader": "0.11.2",
+ "extract-text-webpack-plugin": "3.0.2",
+ "file-loader": "1.1.5",
"fs-extra": "3.0.1",
"html-webpack-plugin": "2.29.0",
"jest": "20.0.4",
"object-assign": "4.1.1",
"postcss-flexbugs-fixes": "3.2.0",
- "postcss-loader": "2.0.6",
+ "postcss-loader": "2.0.8",
"promise": "8.0.1",
- "react-dev-utils": "^4.0.1",
- "style-loader": "0.18.2",
- "ts-jest": "^20.0.7",
- "ts-loader": "^2.3.7",
- "tslint": "^5.7.0",
+ "raf": "3.4.0",
+ "react-dev-utils": "^4.2.1",
+ "style-loader": "0.19.0",
+ "sw-precache-webpack-plugin": "0.11.4",
+ "url-loader": "0.6.2",
+ "webpack": "3.8.1",
+ "webpack-dev-server": "2.9.4",
+ "webpack-manifest-plugin": "1.3.2",
+ "whatwg-fetch": "2.0.3",
+ "ts-jest": "^21.1.4",
+ "ts-loader": "^3.1.1",
+ "tslint": "^5.8.0",
"tslint-loader": "^3.5.3",
"tslint-react": "^3.2.0",
- "typescript": "~2.5.3",
- "source-map-loader": "^0.2.1",
- "sw-precache-webpack-plugin": "0.11.4",
- "url-loader": "0.5.9",
- "webpack": "3.5.1",
- "webpack-dev-server": "2.7.1",
- "webpack-manifest-plugin": "1.2.1",
- "whatwg-fetch": "2.0.3"
+ "typescript": "~2.6.1",
+ "source-map-loader": "^0.2.3"
},
"devDependencies": {
- "react": "^15.5.4",
- "react-dom": "^15.5.4"
+ "react": "^16.0.0",
+ "react-dom": "^16.0.0"
},
"optionalDependencies": {
"fsevents": "1.1.2"
diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js
index 7691bfd52..56f11918e 100644
--- a/packages/react-scripts/scripts/build.js
+++ b/packages/react-scripts/scripts/build.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
@@ -74,7 +72,7 @@ measureFileSizesBeforeBuild(paths.appBuild)
);
console.log(
'To ignore, add ' +
- chalk.cyan('// eslint-disable-next-line') +
+ chalk.cyan('// tslint-disable-next-line') +
' to the line before.\n'
);
} else {
diff --git a/packages/react-scripts/scripts/eject.js b/packages/react-scripts/scripts/eject.js
index 3d8d258cc..2b859694f 100644
--- a/packages/react-scripts/scripts/eject.js
+++ b/packages/react-scripts/scripts/eject.js
@@ -1,11 +1,9 @@
// @remove-file-on-eject
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -167,9 +165,11 @@ inquirer
// Sort the deps
const unsortedDependencies = appPackage.dependencies;
appPackage.dependencies = {};
- Object.keys(unsortedDependencies).sort().forEach(key => {
- appPackage.dependencies[key] = unsortedDependencies[key];
- });
+ Object.keys(unsortedDependencies)
+ .sort()
+ .forEach(key => {
+ appPackage.dependencies[key] = unsortedDependencies[key];
+ });
console.log();
console.log(cyan('Updating the scripts'));
diff --git a/packages/react-scripts/scripts/init.js b/packages/react-scripts/scripts/init.js
index 77aa58539..3a822ac76 100644
--- a/packages/react-scripts/scripts/init.js
+++ b/packages/react-scripts/scripts/init.js
@@ -1,11 +1,9 @@
// @remove-file-on-eject
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -101,6 +99,7 @@ module.exports = function(
command = 'npm';
args = ['install', '--save', verbose && '--verbose'].filter(e => e);
}
+ args.push('react', 'react-dom');
// Install dev dependencies
const types = [
@@ -141,9 +140,7 @@ module.exports = function(
console.log(`Installing react and react-dom using ${command}...`);
console.log();
- const proc = spawn.sync(command, args.concat(['react', 'react-dom']), {
- stdio: 'inherit',
- });
+ const proc = spawn.sync(command, args, { stdio: 'inherit' });
if (proc.status !== 0) {
console.error(`\`${command} ${args.join(' ')}\` failed`);
return;
diff --git a/packages/react-scripts/scripts/start.js b/packages/react-scripts/scripts/start.js
index b86943b4d..8df052d3b 100644
--- a/packages/react-scripts/scripts/start.js
+++ b/packages/react-scripts/scripts/start.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/scripts/test.js b/packages/react-scripts/scripts/test.js
index e9adb48f0..b30113fe6 100644
--- a/packages/react-scripts/scripts/test.js
+++ b/packages/react-scripts/scripts/test.js
@@ -1,11 +1,9 @@
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
// @remove-on-eject-end
'use strict';
diff --git a/packages/react-scripts/scripts/utils/createJestConfig.js b/packages/react-scripts/scripts/utils/createJestConfig.js
index c5886ce0c..367353468 100644
--- a/packages/react-scripts/scripts/utils/createJestConfig.js
+++ b/packages/react-scripts/scripts/utils/createJestConfig.js
@@ -1,11 +1,9 @@
// @remove-file-on-eject
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';
@@ -13,7 +11,7 @@ const fs = require('fs');
const chalk = require('chalk');
const paths = require('../../config/paths');
-module.exports = (resolve, rootDir) => {
+module.exports = (resolve, rootDir, isEjecting) => {
// Use this instead of `paths.testsSetup` to avoid putting
// an absolute filename into configuration after ejecting.
const setupTestsFile = fs.existsSync(paths.testsSetup)
@@ -23,38 +21,41 @@ module.exports = (resolve, rootDir) => {
// TODO: I don't know if it's safe or not to just use / as path separator
// in Jest configs. We need help from somebody with Windows to determine this.
const config = {
- mapCoverage: true,
- collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}'],
+ collectCoverageFrom: ['src/**/*.{js,jsx,mjs,ts,tsx}'],
setupFiles: [resolve('config/polyfills.js')],
setupTestFrameworkScriptFile: setupTestsFile,
testMatch: [
- '<rootDir>/src/**/__tests__/**/*.ts?(x)',
- '<rootDir>/src/**/?(*.)(spec|test).ts?(x)',
+ '<rootDir>/src/**/__tests__/**/*.{js,jsx,mjs,ts,tsx}',
+ '<rootDir>/src/**/?(*.)(spec|test).{js,jsx,mjs,ts,tsx}',
],
testEnvironment: 'node',
testURL: 'http://localhost',
transform: {
+ '^.+\\.(js|jsx|mjs)$': isEjecting
+ ? '<rootDir>/node_modules/babel-jest'
+ : resolve('config/jest/babelTransform.js'),
'^.+\\.css$': resolve('config/jest/cssTransform.js'),
'^.+\\.tsx?$': resolve('config/jest/typescriptTransform.js'),
- '^(?!.*\\.(js|jsx|css|json)$)': resolve('config/jest/fileTransform.js'),
+ '^(?!.*\\.(js|jsx|mjs|css|json)$)': resolve(
+ 'config/jest/fileTransform.js'
+ ),
},
- transformIgnorePatterns: [
- '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx)$',
- ],
+ transformIgnorePatterns: ['[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx|mjs)$'],
moduleNameMapper: {
'^react-native$': 'react-native-web',
},
moduleFileExtensions: [
- 'web.ts',
- 'ts',
- 'web.tsx',
- 'tsx',
'web.js',
+ 'mjs',
'js',
+ 'json',
'web.jsx',
'jsx',
- 'json',
- 'node'
+ 'node',
+ 'web.ts',
+ 'ts',
+ 'web.tsx',
+ 'tsx'
],
globals: {
'ts-jest': {
diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md
index c55ccdf94..b8c0b74df 100644
--- a/packages/react-scripts/template/README.md
+++ b/packages/react-scripts/template/README.md
@@ -199,12 +199,12 @@ In addition to [ES6](https://github.com/lukehoban/es6features) syntax features,
* [Async/await](https://github.com/tc39/ecmascript-asyncawait) (ES2017).
* [Object Rest/Spread Properties](https://github.com/sebmarkbage/ecmascript-rest-spread) (stage 3 proposal).
* [Dynamic import()](https://github.com/tc39/proposal-dynamic-import) (stage 3 proposal)
-* [Class Fields and Static Properties](https://github.com/tc39/proposal-class-public-fields) (stage 2 proposal).
+* [Class Fields and Static Properties](https://github.com/tc39/proposal-class-public-fields) (part of stage 3 proposal).
* [JSX](https://facebook.github.io/react/docs/introducing-jsx.html) and [Flow](https://flowtype.org/) syntax.
Learn more about [different proposal stages](https://babeljs.io/docs/plugins/#presets-stage-x-experimental-presets-).
-While we recommend to use experimental proposals with some caution, Facebook heavily uses these features in the product code, so we intend to provide [codemods](https://medium.com/@cpojer/effective-javascript-codemods-5a6686bb46fb) if any of these proposals change in the future.
+While we recommend using experimental proposals with some caution, Facebook heavily uses these features in the product code, so we intend to provide [codemods](https://medium.com/@cpojer/effective-javascript-codemods-5a6686bb46fb) if any of these proposals change in the future.
Note that **the project only includes a few ES6 [polyfills](https://en.wikipedia.org/wiki/Polyfill)**:
@@ -262,7 +262,6 @@ Then add the block below to your `launch.json` file and put it inside the `.vsco
"request": "launch",
"url": "http://localhost:3000",
"webRoot": "${workspaceRoot}/src",
- "userDataDir": "${workspaceRoot}/.vscode/chrome",
"sourceMapPathOverrides": {
"webpack:///src/*": "${webRoot}/*"
}
@@ -273,6 +272,8 @@ Then add the block below to your `launch.json` file and put it inside the `.vsco
Start your app by running `npm start`, and start debugging in VS Code by pressing `F5` or by clicking the green debug icon. You can now write code, set breakpoints, make changes to the code, and debug your newly modified code—all from your editor.
+Having problems with VS Code Debugging? Please see their [troubleshooting guide](https://github.com/Microsoft/vscode-chrome-debug/blob/master/README.md#troubleshooting).
+
### WebStorm
You would need to have [WebStorm](https://www.jetbrains.com/webstorm/) and [JetBrains IDE Support](https://chrome.google.com/webstore/detail/jetbrains-ide-support/hmhgeddbohgjknpmjagkdomcpobmllji) Chrome extension installed.
@@ -599,7 +600,8 @@ Then we can change `start` and `build` scripts to include the CSS preprocessor c
- "build": "react-scripts build",
+ "start-js": "react-scripts start",
+ "start": "npm-run-all -p watch-css start-js",
-+ "build": "npm run build-css && react-scripts build",
++ "build-js": "react-scripts build",
++ "build": "npm-run-all build-css build-js",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
}
@@ -910,7 +912,7 @@ REACT_APP_SECRET_CODE=abcdef
`.env` files **should be** checked into source control (with the exclusion of `.env*.local`).
-#### What other `.env` files are can be used?
+#### What other `.env` files can be used?
>Note: this feature is **available with `react-scripts@1.0.0` and higher**.
@@ -983,7 +985,7 @@ To tell the development server to proxy any unknown requests to your API server
"proxy": "http://localhost:4000",
```
-This way, when you `fetch('/api/todos')` in development, the development server will recognize that it’s not a static asset, and will proxy your request to `http://localhost:4000/api/todos` as a fallback. The development server will only attempt to send requests without a `text/html` accept header to the proxy.
+This way, when you `fetch('/api/todos')` in development, the development server will recognize that it’s not a static asset, and will proxy your request to `http://localhost:4000/api/todos` as a fallback. The development server will **only** attempt to send requests without `text/html` in its `Accept` header to the proxy.
Conveniently, this avoids [CORS issues](http://stackoverflow.com/questions/21854516/understanding-ajax-cors-and-security-considerations) and error messages like this in development:
@@ -1049,7 +1051,7 @@ You may also specify any configuration value [`http-proxy-middleware`](https://g
All requests matching this path will be proxies, no exceptions. This includes requests for `text/html`, which the standard `proxy` option does not proxy.
If you need to specify multiple proxies, you may do so by specifying additional entries.
-You may also narrow down matches using `*` and/or `**`, to match the path exactly or any subpath.
+Matches are regular expressions, so that you can use a regexp to match multiple paths.
```js
{
// ...
@@ -1070,12 +1072,12 @@ You may also narrow down matches using `*` and/or `**`, to match the path exactl
// ...
},
// Matches /bar/abc.html but not /bar/sub/def.html
- "/bar/*.html": {
+ "/bar/[^/]*[.]html": {
"target": "<url_3>",
// ...
},
// Matches /baz/abc.html and /baz/sub/def.html
- "/baz/**/*.html": {
+ "/baz/.*/.*[.]html": {
"target": "<url_4>"
// ...
}
@@ -1156,7 +1158,7 @@ If you use a Node server, you can even share the route matching logic between th
## Pre-Rendering into Static HTML Files
-If you’re hosting your `build` with a static hosting provider you can use [react-snapshot](https://www.npmjs.com/package/react-snapshot) to generate HTML pages for each route, or relative link, in your application. These pages will then seamlessly become active, or “hydrated”, when the JavaScript bundle has loaded.
+If you’re hosting your `build` with a static hosting provider you can use [react-snapshot](https://www.npmjs.com/package/react-snapshot) or [react-snap](https://github.com/stereobooster/react-snap) to generate HTML pages for each route, or relative link, in your application. These pages will then seamlessly become active, or “hydrated”, when the JavaScript bundle has loaded.
There are also opportunities to use this outside of static hosting, to take the pressure off the server when generating and caching routes.
@@ -1235,8 +1237,8 @@ it('sums numbers', () => {
});
```
-All `expect()` matchers supported by Jest are [extensively documented here](http://facebook.github.io/jest/docs/expect.html).<br>
-You can also use [`jest.fn()` and `expect(fn).toBeCalled()`](http://facebook.github.io/jest/docs/expect.html#tohavebeencalled) to create “spies” or mock functions.
+All `expect()` matchers supported by Jest are [extensively documented here](https://facebook.github.io/jest/docs/en/expect.html#content).<br>
+You can also use [`jest.fn()` and `expect(fn).toBeCalled()`](https://facebook.github.io/jest/docs/en/expect.html#tohavebeencalled) to create “spies” or mock functions.
### Testing Components
@@ -1262,16 +1264,28 @@ When you encounter bugs caused by changing components, you will gain a deeper in
If you’d like to test components in isolation from the child components they render, we recommend using [`shallow()` rendering API](http://airbnb.io/enzyme/docs/api/shallow.html) from [Enzyme](http://airbnb.io/enzyme/). To install it, run:
```sh
-npm install --save enzyme react-test-renderer
+npm install --save enzyme enzyme-adapter-react-16 react-test-renderer
```
Alternatively you may use `yarn`:
```sh
-yarn add enzyme react-test-renderer
+yarn add enzyme enzyme-adapter-react-16 react-test-renderer
+```
+
+As of Enzyme 3, you will need to install Enzyme along with an Adapter corresponding to the version of React you are using. (The examples above use the adapter for React 16.)
+
+The adapter will also need to be configured in your [global setup file](#initializing-test-environment):
+
+#### `src/setupTests.js`
+```js
+import { configure } from 'enzyme';
+import Adapter from 'enzyme-adapter-react-16';
+
+configure({ adapter: new Adapter() });
```
-You can write a smoke test with it too:
+Now you can write a smoke test with it:
```js
import React from 'react';
@@ -1302,7 +1316,7 @@ it('renders welcome message', () => {
});
```
-All Jest matchers are [extensively documented here](http://facebook.github.io/jest/docs/expect.html).<br>
+All Jest matchers are [extensively documented here](http://facebook.github.io/jest/docs/en/expect.html).<br>
Nevertheless you can use a third-party assertion library like [Chai](http://chaijs.com/) if you want to, as described below.
Additionally, you might find [jest-enzyme](https://github.com/blainekasten/enzyme-matchers) helpful to simplify your tests with readable matchers. The above `contains` code can be written simpler with jest-enzyme.
@@ -1374,6 +1388,41 @@ Run `npm test -- --coverage` (note extra `--` in the middle) to include a covera
Note that tests run much slower with coverage so it is recommended to run it separately from your normal workflow.
+#### Configuration
+
+The default Jest coverage configuration can be overriden by adding any of the following supported keys to a Jest config in your package.json.
+
+Supported overrides:
+ - [`collectCoverageFrom`](https://facebook.github.io/jest/docs/en/configuration.html#collectcoveragefrom-array)
+ - [`coverageReporters`](https://facebook.github.io/jest/docs/en/configuration.html#coveragereporters-array-string)
+ - [`coverageThreshold`](https://facebook.github.io/jest/docs/en/configuration.html#coveragethreshold-object)
+ - [`snapshotSerializers`](https://facebook.github.io/jest/docs/en/configuration.html#snapshotserializers-array-string)
+
+Example package.json:
+
+```json
+{
+ "name": "your-package",
+ "jest": {
+ "collectCoverageFrom" : [
+ "src/**/*.{js,jsx}",
+ "!<rootDir>/node_modules/",
+ "!<rootDir>/path/to/dir/"
+ ],
+ "coverageThreshold": {
+ "global": {
+ "branches": 90,
+ "functions": 90,
+ "lines": 90,
+ "statements": 90
+ }
+ },
+ "coverageReporters": ["text"],
+ "snapshotSerializers": ["my-serializer-module"]
+ }
+}
+```
+
### Continuous Integration
By default `npm test` runs the watcher with interactive CLI. However, you can force it to run tests once and finish the process by setting an environment variable called `CI`.
@@ -1567,7 +1616,7 @@ By default, the production build is a fully functional, offline-first
Progressive Web Apps are faster and more reliable than traditional web pages, and provide an engaging mobile experience:
* All static site assets are cached so that your page loads fast on subsequent visits, regardless of network connectivity (such as 2G or 3G). Updates are downloaded in the background.
- * Your app will work regardless of network state, even if offline. This means your users will be able to use your app at 10,000 feet and on the Subway.
+ * Your app will work regardless of network state, even if offline. This means your users will be able to use your app at 10,000 feet and on the subway.
* On mobile devices, your app can be added directly to the user's home screen, app icon and all. You can also re-engage users using web **push notifications**. This eliminates the need for the app store.
The [`sw-precache-webpack-plugin`](https://github.com/goldhand/sw-precache-webpack-plugin)
@@ -1581,14 +1630,18 @@ that your web app is reliably fast, even on a slow or unreliable network.
### Opting Out of Caching
If you would prefer not to enable service workers prior to your initial
-production deployment, then remove the call to `serviceWorkerRegistration.register()`
+production deployment, then remove the call to `registerServiceWorker()`
from [`src/index.js`](src/index.js).
If you had previously enabled service workers in your production deployment and
have decided that you would like to disable them for all your existing users,
-you can swap out the call to `serviceWorkerRegistration.register()` in
-[`src/index.js`](src/index.js) with a call to `serviceWorkerRegistration.unregister()`.
-After the user visits a page that has `serviceWorkerRegistration.unregister()`,
+you can swap out the call to `registerServiceWorker()` in
+[`src/index.js`](src/index.js) first by modifying the service worker import:
+```javascript
+import { unregister } from './registerServiceWorker';
+```
+and then call `unregister()` instead.
+After the user visits a page that has `unregister()`,
the service worker will be uninstalled. Note that depending on how `/service-worker.js` is served,
it may take up to 24 hours for the cache to be invalidated.
@@ -1784,6 +1837,12 @@ service worker navigation routing can be configured or disabled by
and [`navigateFallbackWhitelist`](https://github.com/GoogleChrome/sw-precache#navigatefallbackwhitelist-arrayregexp)
options of the `SWPreachePlugin` [configuration](../config/webpack.config.prod.js).
+When users install your app to the homescreen of their device the default configuration will make a shortcut to `/index.html`. This may not work for client-side routers which expect the app to be served from `/`. Edit the web app manifest at [`public/manifest.json`](public/manifest.json) and change `start_url` to match the required URL scheme, for example:
+
+```js
+ "start_url": ".",
+```
+
### Building for Relative Paths
By default, Create React App produces a build assuming your app is hosted at the server root.<br>
@@ -1816,11 +1875,11 @@ If you are not using the HTML5 `pushState` history API or not using client-side
This will make sure that all the asset paths are relative to `index.html`. You will then be able to move your app from `http://mywebsite.com` to `http://mywebsite.com/relativepath` or even `http://mywebsite.com/relative/path` without having to rebuild it.
-### Azure
+### [Azure](https://azure.microsoft.com/)
-See [this](https://medium.com/@to_pe/deploying-create-react-app-on-microsoft-azure-c0f6686a4321) blog post on how to deploy your React app to [Microsoft Azure](https://azure.microsoft.com/).
+See [this](https://medium.com/@to_pe/deploying-create-react-app-on-microsoft-azure-c0f6686a4321) blog post on how to deploy your React app to Microsoft Azure.
-### Firebase
+### [Firebase](https://firebase.google.com/)
Install the Firebase CLI if you haven’t already by running `npm install -g firebase-tools`. Sign up for a [Firebase account](https://console.firebase.google.com/) and create a new project. Run `firebase login` and login with your previous created Firebase account.
@@ -1881,7 +1940,7 @@ Now, after you create a production build with `npm run build`, you can deploy it
For more information see [Add Firebase to your JavaScript Project](https://firebase.google.com/docs/web/setup).
-### GitHub Pages
+### [GitHub Pages](https://pages.github.com/)
>Note: this feature is available with `react-scripts@0.2.0` and higher.
@@ -1951,7 +2010,7 @@ GitHub Pages doesn’t support routers that use the HTML5 `pushState` history AP
* You could switch from using HTML5 history API to routing with hashes. If you use React Router, you can switch to `hashHistory` for this effect, but the URL will be longer and more verbose (for example, `http://user.github.io/todomvc/#/todos/42?_k=yknaj`). [Read more](https://reacttraining.com/react-router/web/api/Router) about different history implementations in React Router.
* Alternatively, you can use a trick to teach GitHub Pages to handle 404 by redirecting to your `index.html` page with a special redirect parameter. You would need to add a `404.html` file with the redirection code to the `build` folder before deploying your project, and you’ll need to add code handling the redirect parameter to `index.html`. You can find a detailed explanation of this technique [in this guide](https://github.com/rafrex/spa-github-pages).
-### Heroku
+### [Heroku](https://www.heroku.com/)
Use the [Heroku Buildpack for Create React App](https://github.com/mars/create-react-app-buildpack).<br>
You can find instructions in [Deploying React with Zero Configuration](https://blog.heroku.com/deploying-react-with-zero-configuration).
@@ -1989,7 +2048,7 @@ remote: npm ERR! argv "/tmp/build_a2875fc163b209225122d68916f1d4df/.heroku/node/
In this case, ensure that the file is there with the proper lettercase and that’s not ignored on your local `.gitignore` or `~/.gitignore_global`.
-### Netlify
+### [Netlify](https://www.netlify.com/)
**To do a manual deploy to Netlify’s CDN:**
@@ -2018,9 +2077,9 @@ To support `pushState`, make sure to create a `public/_redirects` file with the
When you build the project, Create React App will place the `public` folder contents into the build output.
-### Now
+### [Now](https://zeit.co/now)
-[now](https://zeit.co/now) offers a zero-configuration single-command deployment. You can use `now` to deploy your app for free.
+Now offers a zero-configuration single-command deployment. You can use `now` to deploy your app for free.
1. Install the `now` command-line tool either via the recommended [desktop tool](https://zeit.co/download) or via node with `npm install -g now`.
@@ -2038,11 +2097,11 @@ When you build the project, Create React App will place the `public` folder cont
Details are available in [this article.](https://zeit.co/blog/unlimited-static)
-### S3 and CloudFront
+### [S3](https://aws.amazon.com/s3) and [CloudFront](https://aws.amazon.com/cloudfront/)
-See this [blog post](https://medium.com/@omgwtfmarc/deploying-create-react-app-to-s3-or-cloudfront-48dae4ce0af) on how to deploy your React app to Amazon Web Services [S3](https://aws.amazon.com/s3) and [CloudFront](https://aws.amazon.com/cloudfront/).
+See this [blog post](https://medium.com/@omgwtfmarc/deploying-create-react-app-to-s3-or-cloudfront-48dae4ce0af) on how to deploy your React app to Amazon Web Services S3 and CloudFront.
-### Surge
+### [Surge](https://surge.sh/)
Install the Surge CLI if you haven’t already by running `npm install -g surge`. Run the `surge` command and log in you or create a new account.
@@ -2151,14 +2210,20 @@ This will only work for locales that have been explicitly imported before.
### `npm run build` fails to minify
-You may occasionally find a package you depend on needs compiled or ships code for a non-browser environment.<br>
-This is considered poor practice in the ecosystem and does not have an escape hatch in Create React App.<br>
+Some third-party packages don't compile their code to ES5 before publishing to npm. This often causes problems in the ecosystem because neither browsers (except for most modern versions) nor some tools currently support all ES6 features. We recommend to publish code on npm as ES5 at least for a few more years.
+
<br>
To resolve this:
-1. Open an issue on the dependency's issue tracker and ask that the package be published pre-compiled (retaining ES6 Modules).
-2. Fork the package and publish a corrected version yourself.
+
+1. Open an issue on the dependency's issue tracker and ask that the package be published pre-compiled.
+ * Note: Create React App can consume both CommonJS and ES modules. For Node.js compatibility, it is recommended that the main entry point is CommonJS. However, they can optionally provide an ES module entry point with the `module` field in `package.json`. Note that **even if a library provides an ES Modules version, it should still precompile other ES6 features to ES5 if it intends to support older browsers**.
+
+2. Fork the package and publish a corrected version yourself.
+
3. If the dependency is small enough, copy it to your `src/` folder and treat it as application code.
+In the future, we might start automatically compiling incompatible third-party modules, but it is not currently supported. This approach would also slow down the production builds.
+
## Something Missing?
If you have ideas for more “How To” recipes that should be on this page, [let us know](https://github.com/facebookincubator/create-react-app/issues) or [contribute some!](https://github.com/facebookincubator/create-react-app/edit/master/packages/react-scripts/template/README.md)
diff --git a/packages/react-scripts/template/public/index.html b/packages/react-scripts/template/public/index.html
index 7bee02710..ed0ebafa1 100644
--- a/packages/react-scripts/template/public/index.html
+++ b/packages/react-scripts/template/public/index.html
@@ -1,4 +1,4 @@
-<!doctype html>
+<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
diff --git a/packages/react-scripts/template/public/manifest.json b/packages/react-scripts/template/public/manifest.json
index be607e417..ef19ec243 100644
--- a/packages/react-scripts/template/public/manifest.json
+++ b/packages/react-scripts/template/public/manifest.json
@@ -4,8 +4,8 @@
"icons": [
{
"src": "favicon.ico",
- "sizes": "192x192",
- "type": "image/png"
+ "sizes": "64x64 32x32 24x24 16x16",
+ "type": "image/x-icon"
}
],
"start_url": "./index.html",
diff --git a/packages/react-scripts/template/src/App.css b/packages/react-scripts/template/src/App.css
index 15adfdc71..c5c6e8a68 100644
--- a/packages/react-scripts/template/src/App.css
+++ b/packages/react-scripts/template/src/App.css
@@ -14,6 +14,10 @@
color: white;
}
+.App-title {
+ font-size: 1.5em;
+}
+
.App-intro {
font-size: large;
}
diff --git a/packages/react-scripts/template/src/App.tsx b/packages/react-scripts/template/src/App.tsx
index a8de509cd..2ff997f72 100644
--- a/packages/react-scripts/template/src/App.tsx
+++ b/packages/react-scripts/template/src/App.tsx
@@ -1,9 +1,10 @@
import * as React from 'react';
+import { Component } from 'react';
import './App.css';
const logo = require('./logo.svg');
-class App extends React.Component {
+class App extends Component {
render() {
return (
<div className="App">
diff --git a/packages/react-scripts/template/src/index.tsx b/packages/react-scripts/template/src/index.tsx
index 1c66245ab..85ef4a64a 100644
--- a/packages/react-scripts/template/src/index.tsx
+++ b/packages/react-scripts/template/src/index.tsx
@@ -1,8 +1,8 @@
import * as React from 'react';
import * as ReactDOM from 'react-dom';
+import './index.css';
import App from './App';
import registerServiceWorker from './registerServiceWorker';
-import './index.css';
ReactDOM.render(
<App />,
diff --git a/packages/react-scripts/template/src/registerServiceWorker.ts b/packages/react-scripts/template/src/registerServiceWorker.ts
index 11c4bc72c..42f2f8073 100644
--- a/packages/react-scripts/template/src/registerServiceWorker.ts
+++ b/packages/react-scripts/template/src/registerServiceWorker.ts
@@ -1,14 +1,15 @@
-// tslint:disable:no-console
// In production, we register a service worker to serve assets from local cache.
// This lets the app load faster on subsequent visits in production, and gives
// it offline capabilities. However, it also means that developers (and users)
-// will only see deployed updates on the 'N+1' visit to a page, since previously
+// will only see deployed updates on the "N+1" visit to a page, since previously
// cached resources are updated in the background.
// To learn more about the benefits of this model, read https://goo.gl/KwvDNy.
// This link also includes instructions on opting out of this behavior.
+/* tslint:disable:no-console */
+
const isLocalhost = Boolean(
window.location.hostname === 'localhost' ||
// [::1] is the IPv6 localhost address.
@@ -22,10 +23,7 @@ const isLocalhost = Boolean(
export default function register() {
if (process.env.NODE_ENV === 'production' && 'serviceWorker' in navigator) {
// The URL constructor is available in all browsers that support SW.
- const publicUrl = new URL(
- process.env.PUBLIC_URL!,
- window.location.toString()
- );
+ const publicUrl = new URL(process.env.PUBLIC_URL!, window.location.toString());
if (publicUrl.origin !== window.location.origin) {
// Our service worker won't work if PUBLIC_URL is on a different origin
// from what our page is served on. This might happen if a CDN is used to
@@ -36,12 +34,12 @@ export default function register() {
window.addEventListener('load', () => {
const swUrl = `${process.env.PUBLIC_URL}/service-worker.js`;
- if (!isLocalhost) {
- // Is not local host. Just register service worker
- registerValidSW(swUrl);
- } else {
+ if (isLocalhost) {
// This is running on localhost. Lets check if a service worker still exists or not.
checkValidServiceWorker(swUrl);
+ } else {
+ // Is not local host. Just register service worker
+ registerValidSW(swUrl);
}
});
}
@@ -52,25 +50,23 @@ function registerValidSW(swUrl: string) {
.register(swUrl)
.then(registration => {
registration.onupdatefound = () => {
- const installingWorker = registration.installing;
- if (installingWorker) {
- installingWorker.onstatechange = () => {
- if (installingWorker.state === 'installed') {
- if (navigator.serviceWorker.controller) {
- // At this point, the old content will have been purged and
- // the fresh content will have been added to the cache.
- // It's the perfect time to display a 'New content is
- // available; please refresh.' message in your web app.
- console.log('New content is available; please refresh.');
- } else {
- // At this point, everything has been precached.
- // It's the perfect time to display a
- // 'Content is cached for offline use.' message.
- console.log('Content is cached for offline use.');
- }
+ const installingWorker = registration.installing!;
+ installingWorker.onstatechange = () => {
+ if (installingWorker.state === 'installed') {
+ if (navigator.serviceWorker.controller) {
+ // At this point, the old content will have been purged and
+ // the fresh content will have been added to the cache.
+ // It's the perfect time to display a "New content is
+ // available; please refresh." message in your web app.
+ console.log('New content is available; please refresh.');
+ } else {
+ // At this point, everything has been precached.
+ // It's the perfect time to display a
+ // "Content is cached for offline use." message.
+ console.log('Content is cached for offline use.');
}
- };
- }
+ }
+ };
};
})
.catch(error => {
diff --git a/packages/react-scripts/template/tsconfig.json b/packages/react-scripts/template/tsconfig.json
index 859735414..58294bb97 100644
--- a/packages/react-scripts/template/tsconfig.json
+++ b/packages/react-scripts/template/tsconfig.json
@@ -24,6 +24,7 @@
"acceptance-tests",
"webpack",
"jest",
- "src/setupTests.ts"
+ "src/setupTests.ts",
+ "config"
]
}
diff --git a/tasks/cra.sh b/tasks/cra.sh
index c94559406..7929cdbf5 100755
--- a/tasks/cra.sh
+++ b/tasks/cra.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# Copyright (c) 2015-present, Facebook, Inc.
-# All rights reserved.
#
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree. An additional grant
-# of patent rights can be found in the PATENTS file in the same directory.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
# ******************************************************************************
# This creates an app with the global CLI and `react-scripts` from the source.
diff --git a/tasks/e2e-installs.sh b/tasks/e2e-installs.sh
index 588642632..f352a5448 100755
--- a/tasks/e2e-installs.sh
+++ b/tasks/e2e-installs.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# Copyright (c) 2015-present, Facebook, Inc.
-# All rights reserved.
#
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree. An additional grant
-# of patent rights can be found in the PATENTS file in the same directory.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
# ******************************************************************************
# This is an end-to-end test intended to run on CI.
diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh
index ebbac271e..547821b65 100755
--- a/tasks/e2e-kitchensink.sh
+++ b/tasks/e2e-kitchensink.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# Copyright (c) 2015-present, Facebook, Inc.
-# All rights reserved.
#
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree. An additional grant
-# of patent rights can be found in the PATENTS file in the same directory.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
# ******************************************************************************
# This is an end-to-end kitchensink test intended to run on CI.
@@ -46,6 +44,31 @@ function create_react_app {
node "$temp_cli_path"/node_modules/create-react-app/index.js "$@"
}
+function install_package {
+ local pkg=$(basename $1)
+
+ # Clean target (for safety)
+ rm -rf node_modules/$pkg/
+ rm -rf node_modules/**/$pkg/
+
+ # Copy package into node_modules/ ignoring installed deps
+ # rsync -a ${1%/} node_modules/ --exclude node_modules
+ cp -R ${1%/} node_modules/
+ rm -rf node_modules/$pkg/node_modules/
+
+ # Install `dependencies`
+ cd node_modules/$pkg/
+ if [ "$USE_YARN" = "yes" ]
+ then
+ yarn install --production
+ else
+ npm install --only=production
+ fi
+ # Remove our packages to ensure side-by-side versions are used (which we link)
+ rm -rf node_modules/{babel-preset-react-app,eslint-config-react-app,react-dev-utils,react-error-overlay,react-scripts}
+ cd ../..
+}
+
# Check for the existence of one or more files.
function exists {
for f in $*; do
@@ -164,10 +187,13 @@ npm install test-integrity@^2.0.1
cd "$temp_app_path/test-kitchensink"
# Link to our preset
-npm link "$root_path"/packages/babel-preset-react-app
+install_package "$root_path"/packages/babel-preset-react-app
+# Link to error overlay package because now it's a dependency
+# of react-dev-utils and not react-scripts
+install_package "$root_path"/packages/react-error-overlay
# Link to test module
-npm link "$temp_module_path/node_modules/test-integrity"
+install_package "$temp_module_path/node_modules/test-integrity"
# Test the build
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
@@ -192,14 +218,7 @@ PORT=3001 \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
NODE_PATH=src \
nohup npm start &>$tmp_server_log &
-while true
-do
- if grep -q 'You can now view' $tmp_server_log; then
- break
- else
- sleep 1
- fi
-done
+grep -q 'You can now view' <(tail -f $tmp_server_log)
E2E_URL="http://localhost:3001" \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true NODE_PATH=src \
@@ -218,20 +237,25 @@ E2E_FILE=./build/index.html \
# Finally, let's check that everything still works after ejecting.
# ******************************************************************************
-# Unlink our preset
-npm unlink "$root_path"/packages/babel-preset-react-app
-
# Eject...
echo yes | npm run eject
+# Ensure Yarn is ran after eject; at the time of this commit, we don't run Yarn
+# after ejecting. Soon, we may only skip Yarn on Windows. Let's try to remove
+# this in the near future.
+if hash yarnpkg 2>/dev/null
+then
+ yarn install --check-files
+fi
+
# ...but still link to the local packages
-npm link "$root_path"/packages/babel-preset-react-app
-npm link "$root_path"/packages/eslint-config-react-app
-npm link "$root_path"/packages/react-dev-utils
-npm link "$root_path"/packages/react-scripts
+install_package "$root_path"/packages/babel-preset-react-app
+install_package "$root_path"/packages/eslint-config-react-app
+install_package "$root_path"/packages/react-error-overlay
+install_package "$root_path"/packages/react-dev-utils
# Link to test module
-npm link "$temp_module_path/node_modules/test-integrity"
+install_package "$temp_module_path/node_modules/test-integrity"
# Test the build
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
@@ -256,14 +280,7 @@ PORT=3002 \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
NODE_PATH=src \
nohup npm start &>$tmp_server_log &
-while true
-do
- if grep -q 'You can now view' $tmp_server_log; then
- break
- else
- sleep 1
- fi
-done
+grep -q 'You can now view' <(tail -f $tmp_server_log)
E2E_URL="http://localhost:3002" \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true NODE_PATH=src \
diff --git a/tasks/e2e-simple.sh b/tasks/e2e-simple.sh
index 2918fc0f5..68e385b9d 100755
--- a/tasks/e2e-simple.sh
+++ b/tasks/e2e-simple.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# Copyright (c) 2015-present, Facebook, Inc.
-# All rights reserved.
#
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree. An additional grant
-# of patent rights can be found in the PATENTS file in the same directory.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
# ******************************************************************************
# This is an end-to-end test intended to run on CI.
@@ -45,6 +43,31 @@ function create_react_app {
node "$temp_cli_path"/node_modules/create-react-app/index.js "$@"
}
+function install_package {
+ local pkg=$(basename $1)
+
+ # Clean target (for safety)
+ rm -rf node_modules/$pkg/
+ rm -rf node_modules/**/$pkg/
+
+ # Copy package into node_modules/ ignoring installed deps
+ # rsync -a ${1%/} node_modules/ --exclude node_modules
+ cp -R ${1%/} node_modules/
+ rm -rf node_modules/$pkg/node_modules/
+
+ # Install `dependencies`
+ cd node_modules/$pkg/
+ if [ "$USE_YARN" = "yes" ]
+ then
+ yarn install --production
+ else
+ npm install --only=production
+ fi
+ # Remove our packages to ensure side-by-side versions are used (which we link)
+ rm -rf node_modules/{babel-preset-react-app,eslint-config-react-app,react-dev-utils,react-error-overlay,react-scripts}
+ cd ../..
+}
+
# Check for the existence of one or more files.
function exists {
for f in $*; do
@@ -136,6 +159,9 @@ cd packages/react-error-overlay/
npm test
npm run build:prod
cd ../..
+cd packages/react-dev-utils/
+npm test
+cd ../..
# ******************************************************************************
# First, test the create-react-app development environment.
@@ -264,7 +290,7 @@ function verify_module_scope {
cp src/App.tsx src/App.tsx.bak
# Add an out of scope import
- echo "import sampleJson from '../sample.json'" | cat - src/App.tsx > src/App.tsx.temp && mv src/App.tsx.temp src/App.tsx
+ echo "import sampleJson from '../sample'" | cat - src/App.tsx > src/App.tsx.temp && mv src/App.tsx.temp src/App.tsx
# Make sure the build fails
npm run build; test $? -eq 1 || exit 1
@@ -281,7 +307,6 @@ cd test-app
# Test the build
npm run build
# Check for expected output
-pwd
exists build/*.html
exists build/static/js/*.js
exists build/static/css/*.css
@@ -309,11 +334,18 @@ verify_module_scope
# Eject...
echo yes | npm run eject
+# Ensure Yarn is ran after eject; at the time of this commit, we don't run Yarn
+# after ejecting. Soon, we may only skip Yarn on Windows. Let's try to remove
+# this in the near future.
+if hash yarnpkg 2>/dev/null
+then
+ yarnpkg install --check-files
+fi
+
# ...but still link to the local packages
-npm link "$root_path"/packages/babel-preset-react-app
-npm link "$root_path"/packages/eslint-config-react-app
-npm link "$root_path"/packages/react-dev-utils
-npm link "$root_path"/packages/react-scripts
+install_package "$root_path"/packages/babel-preset-react-app
+install_package "$root_path"/packages/eslint-config-react-app
+install_package "$root_path"/packages/react-dev-utils
# Test the build
npm run build
diff --git a/tasks/local-test.sh b/tasks/local-test.sh
index 42d98ffcd..8ce44b640 100755
--- a/tasks/local-test.sh
+++ b/tasks/local-test.sh
@@ -1,4 +1,8 @@
#!/usr/bin/env bash
+# Copyright (c) 2015-present, Facebook, Inc.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
function print_help {
echo "Usage: ${0} [OPTIONS]"
diff --git a/tasks/release.sh b/tasks/release.sh
index d72a2bb44..0f11bb0d6 100755
--- a/tasks/release.sh
+++ b/tasks/release.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# Copyright (c) 2015-present, Facebook, Inc.
-# All rights reserved.
#
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree. An additional grant
-# of patent rights can be found in the PATENTS file in the same directory.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
# ******************************************************************************
# This releases an update to the `react-scripts` package.
diff --git a/tasks/replace-own-deps.js b/tasks/replace-own-deps.js
index 23a3f4a01..9178b0102 100755
--- a/tasks/replace-own-deps.js
+++ b/tasks/replace-own-deps.js
@@ -1,11 +1,9 @@
#!/usr/bin/env node
/**
* Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
*
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
*/
'use strict';