don't use id as index unless present (fixes #13)

Author: sheppard

rest_pandas/serializers.py

@@ -70,7 +70,8 @@ def get_index_fields(self):
         """
         default_fields = []
         if getattr(self.model_serializer_meta, 'model', None):
-            default_fields = ['id']
+            if 'id' in self.child.get_fields():
+                default_fields = ['id']
         return self.get_meta_option('index', default_fields)
 
     def get_meta_option(self, name, default=None):

tests/test_views.py

@@ -24,6 +24,12 @@ def test_view_csv(self):
         self.assertEqual(len(data), 5)
         self.assertEqual(data[0].value, '0.5')
 
+    def test_view_csv_noid(self):
+        response = self.client.get("/timeseriesnoid.csv")
+        data = self.load_string(response)
+        self.assertEqual(len(data), 5)
+        self.assertEqual(data[0].value, '0.5')
+
     def test_view_json(self):
         response = self.client.get("/timeseries.json")
         self.assertEqual(response.accepted_media_type, "application/json")

tests/testapp/serializers.py

@@ -12,6 +12,12 @@ class Meta:
         fields = '__all__'
 
 
+class TimeSeriesNoIdSerializer(TimeSeriesSerializer):
+    class Meta:
+        model = TimeSeries
+        exclude = ['id']
+
+
 class MultiTimeSeriesSerializer(ModelSerializer):
     class Meta:
         model = MultiTimeSeries

tests/testapp/urls.py

@@ -3,7 +3,8 @@
 from rest_framework.urlpatterns import format_suffix_patterns
 
 from .views import (
-    NoModelView, FromFileView, TimeSeriesView, TimeSeriesViewSet,
+    NoModelView, FromFileView, TimeSeriesView, TimeSeriesNoIdView,
+    TimeSeriesViewSet,
     MultiTimeSeriesView, MultiScatterView, MultiBoxplotView,
     ComplexTimeSeriesView, ComplexScatterView, ComplexBoxplotView,
 )
@@ -15,6 +16,7 @@
     url(r'^nomodel$', NoModelView.as_view()),
     url(r'^fromfile$', FromFileView.as_view()),
     url(r'^timeseries$', TimeSeriesView.as_view()),
+    url(r'^timeseriesnoid$', TimeSeriesNoIdView.as_view()),
     url(r'^multitimeseries$', MultiTimeSeriesView.as_view()),
     url(r'^multiscatter$', MultiScatterView.as_view()),
     url(r'^multiboxplot$', MultiBoxplotView.as_view()),

tests/testapp/views.py

@@ -4,7 +4,8 @@
 )
 from .models import TimeSeries, MultiTimeSeries, ComplexTimeSeries
 from .serializers import (
-    TimeSeriesSerializer, MultiTimeSeriesSerializer,
+    TimeSeriesSerializer, TimeSeriesNoIdSerializer,
+    MultiTimeSeriesSerializer,
     ComplexTimeSeriesSerializer, ComplexScatterSerializer,
     ComplexBoxplotSerializer,
 )
@@ -37,6 +38,11 @@ def get_template_context(self, data):
         return {'name': data['name'] + ' Custom'}
 
 
+class TimeSeriesNoIdView(PandasView):
+    queryset = TimeSeries.objects.all()
+    serializer_class = TimeSeriesNoIdSerializer
+
+
 class TimeSeriesViewSet(PandasViewSet):
     queryset = TimeSeries.objects.all()
     serializer_class = TimeSeriesSerializer