[videosubscriberaccount] Add nullability to (generated and manual) bindings #14948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 6, 2022 17:21
rolfbjarne
requested changes
May 9, 2022
Comment on lines
26
to
29
| if (value.GetConstants () is not null) | ||
| SupportedAuthenticationSchemesString = value.GetConstants ()!; | ||
| else | ||
| ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (value)); |
There was a problem hiding this comment.
IMHO using a temporary variable here would be better:
Suggested change
| if (value.GetConstants () is not null) | |
| SupportedAuthenticationSchemesString = value.GetConstants ()!; | |
| else | |
| ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (value)); | |
| var constants = value.GetConstants (); | |
| if (constants is null) | |
| ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (value)); | |
| SupportedAuthenticationSchemesString = constants; |
There was a problem hiding this comment.
Okay changing this to the proposed code!
However, the value.GetConstants (); returns a NSString?[]
so I went with this code and added a ! to the last line after constants. Internally, these methods throw an exception if it does find a null item inside the constants array and I believe this is what was recommended last time a similar thing happened
mandel-macaque
approved these changes
May 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results22 tests failed, 126 tests passed.Failed tests
Pipeline on Agent XAMBOT-1166.Monterey' |
rolfbjarne
approved these changes
May 12, 2022
|
Merging since the test failures are unrelated timeouts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring nullability changes to VideoSubscriberAccount.
Following the steps here:
nullable enableto all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changesthrow new ArgumentNullException ("object"));toObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (object));for size saving optimization as well to mark that this framework contains nullability changes== nullor!= nulltois nullandis not null