[videotoolbox] Add nullability to (generated and manual) bindings #14971

tj-devel709 · 2022-05-10T18:56:30Z

This PR aims to bring nullability changes to VideoToolbox.
Following the steps here:

I am adding nullable enable to all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changes
Changing all throw new ArgumentNullException ("object")); to ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (object)); for size saving optimization as well to mark that this framework contains nullability changes
Changing any == null or != null to is null and is not null

mandel-macaque · 2022-05-10T19:05:45Z

src/VideoToolbox/VTCompressionProperties.cs

 #endif
 		public VTAlphaChannelMode AlphaChannelMode {
-			get => VTAlphaChannelModeExtensions.GetValue (GetNSStringValue (VTCompressionPropertyKey.AlphaChannelMode));
+			get => VTAlphaChannelModeExtensions.GetValue (GetNSStringValue (VTCompressionPropertyKey.AlphaChannelMode)!);


Why not setting the property as nullable?

I applied this change but reverted it due to Rolf's comment below

src/VideoToolbox/VTVideoEncoder.cs

tj-devel709 · 2022-05-12T17:28:42Z

test failures are unrelated timeouts!

tj-devel709 · 2022-05-16T15:30:24Z

@rolfbjarne @mandel-macaque requested changes are fixed!

rolfbjarne · 2022-05-16T16:22:38Z

src/VideoToolbox/VTCompressionProperties.cs

-		public VTAlphaChannelMode AlphaChannelMode {
-			get => VTAlphaChannelModeExtensions.GetValue (GetNSStringValue (VTCompressionPropertyKey.AlphaChannelMode));
-			set => SetStringValue (VTCompressionPropertyKey.AlphaChannelMode, value.GetConstant ());
+		public VTAlphaChannelMode? AlphaChannelMode {


This is a breaking change, you can't make a value type (enum or struct) nullable :/

Okay! So I will revert the changes to this property

…-VideoToolbox

vs-mobiletools-engineering-service2 · 2022-05-16T19:35:49Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:37:11Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:42:30Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1036.Monterey
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:52:31Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:56:28Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:57:15Z

📋 [PR Build] API Diff 📋

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1017.Monterey'
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T19:57:54Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-16T20:05:53Z

📋 [PR Build] API Diff 📋

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1098.Monterey
Hash: 251120df373e74d15c899b74c8289a0ef5bea1e0

vs-mobiletools-engineering-service2 · 2022-05-17T01:57:55Z

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1044.Monterey'
Merge 251120d into 746cf88

vs-mobiletools-engineering-service2 · 2022-05-17T02:00:09Z

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1036.Monterey'
Merge ab97a51 into 746cf88

tj_devel709 added 4 commits May 9, 2022 14:30

add nullability

ddb3192

throw better exceptions

d2dffcb

use is null and not null

302a82d

remove some exclamation points

19bdb80

tj-devel709 added the not-notes-worthy Ignore for release notes label May 10, 2022

tj-devel709 added this to the Future milestone May 10, 2022

tj-devel709 requested a review from dalexsoto as a code owner May 10, 2022 18:56

mandel-macaque requested changes May 10, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Address changes

35308e9

This comment has been minimized.

Sign in to view

Merge branch 'main' into Nullable-VideoToolbox

f6dc9a7

This comment has been minimized.

Sign in to view

rolfbjarne requested changes May 16, 2022

View reviewed changes

tj_devel709 added 2 commits May 16, 2022 12:41

revert changes to VTAlphaChennelMode

2a8e4f1

Merge remote-tracking branch 'TJ/Nullable-VideoToolbox' into Nullable…

ab97a51

…-VideoToolbox

Merge branch 'main' into Nullable-VideoToolbox

251120d

rolfbjarne approved these changes May 16, 2022

View reviewed changes

mandel-macaque approved these changes May 17, 2022

View reviewed changes

tj-devel709 merged commit f773e62 into dotnet:main May 17, 2022

[videotoolbox] Add nullability to (generated and manual) bindings #14971

[videotoolbox] Add nullability to (generated and manual) bindings #14971

Uh oh!

Conversation

tj-devel709 commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandel-macaque May 10, 2022

Choose a reason for hiding this comment

Uh oh!

tj-devel709 May 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented May 12, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented May 16, 2022

Uh oh!

rolfbjarne May 16, 2022

Choose a reason for hiding this comment

Uh oh!

tj-devel709 May 16, 2022

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

📋 [PR Build] API Diff 📋

API Current PR diff

API diff

Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 16, 2022

📋 [PR Build] API Diff 📋

API Current PR diff

API diff

Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 17, 2022

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

🎉 All 148 tests passed 🎉

Uh oh!

vs-mobiletools-engineering-service2 commented May 17, 2022

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

🎉 All 148 tests passed 🎉

Uh oh!

tj-devel709 commented May 10, 2022 •

edited

Loading