Fix tests

Author: dcherian

flox/core.py

@@ -259,7 +259,7 @@ def _is_bool_supported_reduction(func: T_Agg) -> bool:
 def _is_sparse_supported_reduction(func: T_Agg) -> bool:
     if isinstance(func, Aggregation):
         func = func.name
-    return not HAS_SPARSE or all(f not in func for f in ["first", "last", "prod", "var", "std"])
+    return HAS_SPARSE and all(f not in func for f in ["first", "last", "prod", "var", "std"])
 
 
 def _get_expected_groups(by: T_By, sort: bool) -> T_ExpectIndex:

tests/test_core.py

@@ -76,6 +76,10 @@ def dask_array_ones(*args):
 
 
 DEFAULT_QUANTILE = 0.9
+REINDEX_SPARSE_STRAT = ReindexStrategy(blockwise=False, array_type=ReindexArrayType.SPARSE_COO)
+REINDEX_SPARSE_PARAM = pytest.param(
+    REINDEX_SPARSE_STRAT, marks=(requires_dask, pytest.mark.skipif(not has_sparse, reason="no sparse"))
+)
 
 if TYPE_CHECKING:
     from flox.core import T_Agg, T_Engine, T_ExpectedGroupsOpt, T_Method
@@ -325,7 +329,7 @@ def test_groupby_reduce_all(nby, size, chunks, func, add_nan_by, engine):
         params = list(
             itertools.product(
                 ["map-reduce"],
-                [True, False, None, ReindexStrategy(blockwise=False, array_type=ReindexArrayType.SPARSE_COO)],
+                [True, False, None, REINDEX_SPARSE_STRAT],
             )
         )
         params.extend(itertools.product(["cohorts"], [False, None]))
@@ -460,18 +464,7 @@ def test_numpy_reduce_nd_md():
 
 
 @requires_dask
-@pytest.mark.parametrize(
-    "reindex",
-    [
-        None,
-        False,
-        True,
-        pytest.param(
-            ReindexStrategy(blockwise=False, array_type=ReindexArrayType.SPARSE_COO),
-            marks=pytest.mark.skipif(not has_sparse, reason="no sparse"),
-        ),
-    ],
-)
+@pytest.mark.parametrize("reindex", [None, False, True, REINDEX_SPARSE_PARAM])
 @pytest.mark.parametrize("func", ALL_FUNCS)
 @pytest.mark.parametrize("add_nan", [False, True])
 @pytest.mark.parametrize("dtype", (float,))
@@ -803,7 +796,7 @@ def test_groupby_reduce_axis_subset_against_numpy(func, axis, engine):
         pytest.param(False, (2, 2, 3), marks=requires_dask),
         pytest.param(True, (2, 2, 3), marks=requires_dask),
         pytest.param(
-            ReindexStrategy(blockwise=False, array_type=ReindexArrayType.SPARSE_COO),
+            REINDEX_SPARSE_STRAT,
             (2, 2, 3),
             marks=(requires_dask, pytest.mark.skipif(not has_sparse, reason="no sparse")),
         ),
@@ -860,7 +853,7 @@ def _maybe_chunk(arr):
         ([0, 1, 2], False),
         pytest.param(
             [0, 1, 2],
-            ReindexStrategy(blockwise=False, array_type=ReindexArrayType.SPARSE_COO),
+            REINDEX_SPARSE_STRAT,
             marks=pytest.mark.skipif(not has_sparse, reason="no sparse"),
         ),
     ],