Skip to content

Review hereroskedastic GP implementation #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikitakuklev opened this issue Apr 9, 2025 · 1 comment
Open

Review hereroskedastic GP implementation #307

nikitakuklev opened this issue Apr 9, 2025 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@nikitakuklev
Copy link
Collaborator

We currently use a copy of allegedly-buggy implementation from BoTorch (before it was removed in pytorch/botorch#2616). Need to verify it works well in all relevant scenarios or add guardrails.
@roussel-ryan
Copy link
Collaborator

Agreed, for now I will open a PR that adds a warning to the user when using the class

@roussel-ryan roussel-ryan mentioned this issue Apr 10, 2025
Merged
@nikitakuklev nikitakuklev added bug Something isn't working enhancement New feature or request labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikitakuklev @roussel-ryan