You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@yannickcr Your commit unfortunately doesn't seem to fix this issue. The example provided by @lencioni still produces the buggy result of removing the comment (tested using 7.3.0).
So I would argue that this issue should be re-opened.
Cool, thanks for the update!
(Essentially my first PR on a major project, so I just wanted to make sure I did it properly and understood you correctly :) )
Activity
ahstro commentedon Nov 30, 2016
Title should probably be changed to "jsx-curly-spacing doesn't account for comments" since things like
{something /* comment */}
triggers an error.s-h-a-d-o-w commentedon Sep 6, 2017
@yannickcr Your commit unfortunately doesn't seem to fix this issue. The example provided by @lencioni still produces the buggy result of removing the comment (tested using 7.3.0).
So I would argue that this issue should be re-opened.
ljharb commentedon Sep 6, 2017
The commit includes automated tests that should verify it's working.
Can you open a PR that includes a failing test case?
Added tests for jsx-curly-spacing that deal with comments in children.
s-h-a-d-o-w commentedon Sep 12, 2017
Was that what you had in mind?
ljharb commentedon Sep 12, 2017
Thanks, that's appreciated! I'll take a look soon.
s-h-a-d-o-w commentedon Sep 12, 2017
Cool, thanks for the update!
(Essentially my first PR on a major project, so I just wanted to make sure I did it properly and understood you correctly :) )
Added tests for jsx-curly-spacing that deal with comments in children.
[Tests] Added tests for jsx-curly-spacing that deal with comments in …