[New] support eslint v7 #2635
Merged
[New] support eslint v7 #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
26 tasks
ljharb
force-pushed
the
eslint7
branch
3 times, most recently
from
b2f1f14 to
1d0494f
Compare
17 tasks
|
@toshi-toma i restored the test you'd removed; we shouldn't need to remove tests to get this shipped. That test is the one failing CI, legitimately. |
|
Oh. I understand. I made a mistake that added the test into valid. We should remove the test from valid. then, should pass the failing test. What is the cause... The test failed with ESLint v6 too. |
|
There is an issue -> #1673 |
This was referenced May 11, 2020
This was referenced May 12, 2020
|
ah, thanks, i understand - the test was incorrectly in "invalid" (#1673 would fix that and make it properly invalid), but the parse error in the test was making it be silently ignored. |
8 tasks
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.