Skip to content

dimension_names vs _ARRAY_DIMENSIONS #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomNicholas opened this issue Oct 25, 2024 · 2 comments
Closed

dimension_names vs _ARRAY_DIMENSIONS #273

TomNicholas opened this issue Oct 25, 2024 · 2 comments
Labels
bug Something isn't working zarr-python Relevant to zarr-python upstream

Comments

@TomNicholas
Copy link
Member

I think we're doing this wrong currently, see pydata/xarray#9669
@TomNicholas TomNicholas added bug Something isn't working zarr-python Relevant to zarr-python upstream labels Oct 25, 2024
@norlandrhagen norlandrhagen mentioned this issue Oct 25, 2024
Merged
22 tasks
@rabernat
Copy link
Collaborator

I was just about to open this exact issue.

Everywhere that _ARRAY_DIMENSIONS is used will now need a different code path for V3 data.

This was referenced Nov 5, 2024
Merged
Merged
@maxrjones
Copy link
Member

This is solved because _ARRAY_DIMENSIONS currently only exists in the kerchunk code, which uses Zarr V2 metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working zarr-python Relevant to zarr-python upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rabernat @maxrjones @TomNicholas