Skip to content

Add wheels for Python 3.12 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dstansby opened this issue Oct 11, 2023 · 7 comments
Closed

Add wheels for Python 3.12 #480

dstansby opened this issue Oct 11, 2023 · 7 comments

Comments

@dstansby
Copy link
Contributor

dstansby commented Oct 11, 2023

Now Python 3.12 is released, it would be good to publish wheels for it.

@jakirkham
Copy link
Member

Agreed. Especially since the code is now tested on Python 3.12

Is this something you would be interested in working on David?

Should just be a matter of updating cibuildwheel in GHA

@dstansby
Copy link
Contributor Author

dstansby commented Oct 13, 2023

I don't think anything needs updating, as it builds all wheels by default. On #474 the Python 3.12 wheels are built, so it just requires someone who can upload to PyPI to build the wheels for the last tagged release and upload them.

@jakirkham
Copy link
Member

The wheel uploads are automatic and we just did a release. What else are we still missing?

@dstansby
Copy link
Contributor Author

It looks like 0.12.0 was built using cibuildwheel 2.14 (https://github.com/zarr-developers/numcodecs/actions/runs/6435028120/job/17476132676), but cibuildwheel needs to be 2.16.1 to build Python 3.12 wheels (https://github.com/pypa/cibuildwheel/releases/tag/v2.16.2), so the answer seems to be fix/merge this PR: #474

@jakirkham
Copy link
Member

Ok if you have time/interest to look into fixing that PR, your assistance would be greatly appreciated 🙂

@jakirkham
Copy link
Member

PR ( #474 ) is now merged

What else is still needed here?

@jakirkham
Copy link
Member

We just released 0.12.1. It appears it uploaded wheels for Python 3.12. So looks like this is done. Closing...

Screenshot 2023-10-17 at 5 49 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants