Skip to content

Commit 1558041

Browse files
authored
Refactor core tests, round 2 (#1462)
* chore: refactor tests to inherit create_array from a base class * chore: widen type of shape to variable length tuple * chore: add importskip barrier for lmdb * docs: release notes * chore: remove fsstore kwargs variable * chore: fix type error in creation of fsstore * chore: add `create_filters` method to TestArray. Pop out `compressor` kwarg in create_array.
1 parent aa5db9f commit 1558041

File tree

4 files changed

+249
-624
lines changed

4 files changed

+249
-624
lines changed

docs/release.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ Enhancements
3030
* **Block Indexing**: Implemented blockwise (chunk blocks) indexing to ``zarr.Array``.
3131
By :user:`Altay Sansal <tasansal>` :issue:`1428`
3232

33+
Maintenance
34+
~~~~~~~~~~~
35+
36+
* Refactor the core array tests to reduce code duplication.
37+
By :user:`Davis Bennett <d-v-b>` :issue:`1462`.
38+
3339
.. _release_2.15.0:
3440

3541
2.15.0

zarr/storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ def _require_parent_group(
300300

301301
def init_array(
302302
store: StoreLike,
303-
shape: Tuple[int, ...],
303+
shape: Union[int, Tuple[int, ...]],
304304
chunks: Union[bool, int, Tuple[int, ...]] = True,
305305
dtype=None,
306306
compressor="default",

0 commit comments

Comments
 (0)