Disallow implicit re-exports (#1908)

* No implict reexports

* Clean up v2 mypy ignores

Author: dstansby

pyproject.toml

@@ -201,48 +201,43 @@ disallow_incomplete_defs = true
 disallow_untyped_calls = true
 
 disallow_untyped_defs = true
+no_implicit_reexport = true
+
 
 [[tool.mypy.overrides]]
 module = [
     "zarr.v2.*",
-    "zarr.group",
-    "tests.*",
 ]
-check_untyped_defs = false
+ignore_errors = true
 
 [[tool.mypy.overrides]]
 module = [
-    "zarr.v2.*",
-    "zarr.array_v2",
+    "zarr.group",
+    "tests.*",
 ]
-disallow_any_generics = false
+check_untyped_defs = false
 
 [[tool.mypy.overrides]]
 module = [
-    "zarr.v2.*",
-    "zarr.array_v2",
     "zarr.group"
 ]
 disallow_incomplete_defs = false
 
 [[tool.mypy.overrides]]
 module = [
-    "zarr.v2.*",
-    "zarr.array_v2",
     "zarr.array",
     "zarr.buffer"
 ]
 disallow_untyped_calls = false
 
 [[tool.mypy.overrides]]
 module = [
-    "zarr.v2.*",
-    "zarr.array_v2",
     "zarr.array",
     "zarr.group",
 ]
 disallow_untyped_defs = false
 
+
 [tool.pytest.ini_options]
 minversion = "7"
 testpaths = ["tests"]

src/zarr/array.py

@@ -34,9 +34,9 @@
     ZarrFormat,
     concurrent_map,
 )
-from zarr.config import config
+from zarr.config import config, parse_indexing_order
 from zarr.indexing import BasicIndexer
-from zarr.metadata import ArrayMetadata, ArrayV2Metadata, ArrayV3Metadata, parse_indexing_order
+from zarr.metadata import ArrayMetadata, ArrayV2Metadata, ArrayV3Metadata
 from zarr.store import StoreLike, StorePath, make_store_path
 from zarr.sync import sync
 

src/zarr/codecs/__init__.py

@@ -1,10 +1,25 @@
 from __future__ import annotations
 
-from zarr.codecs.blosc import BloscCname, BloscCodec, BloscShuffle  # noqa: F401
-from zarr.codecs.bytes import BytesCodec, Endian  # noqa: F401
-from zarr.codecs.crc32c_ import Crc32cCodec  # noqa: F401
-from zarr.codecs.gzip import GzipCodec  # noqa: F401
-from zarr.codecs.pipeline import BatchedCodecPipeline  # noqa: F401
-from zarr.codecs.sharding import ShardingCodec, ShardingCodecIndexLocation  # noqa: F401
-from zarr.codecs.transpose import TransposeCodec  # noqa: F401
-from zarr.codecs.zstd import ZstdCodec  # noqa: F401
+from zarr.codecs.blosc import BloscCname, BloscCodec, BloscShuffle
+from zarr.codecs.bytes import BytesCodec, Endian
+from zarr.codecs.crc32c_ import Crc32cCodec
+from zarr.codecs.gzip import GzipCodec
+from zarr.codecs.pipeline import BatchedCodecPipeline
+from zarr.codecs.sharding import ShardingCodec, ShardingCodecIndexLocation
+from zarr.codecs.transpose import TransposeCodec
+from zarr.codecs.zstd import ZstdCodec
+
+__all__ = [
+    "BatchedCodecPipeline",
+    "BloscCodec",
+    "BloscCname",
+    "BloscShuffle",
+    "BytesCodec",
+    "Endian",
+    "Crc32cCodec",
+    "GzipCodec",
+    "ShardingCodec",
+    "ShardingCodecIndexLocation",
+    "TransposeCodec",
+    "ZstdCodec",
+]

src/zarr/codecs/pipeline.py

@@ -11,12 +11,11 @@
     ArrayBytesCodec,
     ArrayBytesCodecPartialDecodeMixin,
     ArrayBytesCodecPartialEncodeMixin,
-    ByteGetter,
     BytesBytesCodec,
-    ByteSetter,
     Codec,
     CodecPipeline,
 )
+from zarr.abc.store import ByteGetter, ByteSetter
 from zarr.buffer import Buffer, NDBuffer
 from zarr.codecs.registry import get_codec_class
 from zarr.common import JSON, concurrent_map, parse_named_configuration

src/zarr/codecs/sharding.py

@@ -14,11 +14,10 @@
     ArrayBytesCodec,
     ArrayBytesCodecPartialDecodeMixin,
     ArrayBytesCodecPartialEncodeMixin,
-    ByteGetter,
-    ByteSetter,
     Codec,
     CodecPipeline,
 )
+from zarr.abc.store import ByteGetter, ByteSetter
 from zarr.buffer import Buffer, NDBuffer
 from zarr.chunk_grids import RegularChunkGrid
 from zarr.codecs.bytes import BytesCodec

src/zarr/metadata.py

@@ -41,6 +41,9 @@
 _bool = bool
 
 
+__all__ = ["ArrayMetadata"]
+
+
 class DataType(Enum):
     bool = "bool"
     int8 = "int8"

src/zarr/store/__init__.py

@@ -3,3 +3,5 @@
 from zarr.store.remote import RemoteStore
 from zarr.store.local import LocalStore
 from zarr.store.memory import MemoryStore
+
+__all__ = ["StorePath", "StoreLike", "make_store_path", "RemoteStore", "LocalStore", "MemoryStore"]