Merge pull request #2343 from rabernat/ryan/fix-remote-store-exists

fix RemoteStore.empty

Author: jhamman

src/zarr/storage/remote.py

@@ -148,7 +148,10 @@ async def empty(self) -> bool:
 
         # TODO: it would be nice if we didn't have to list all keys here
         # it should be possible to stop after the first key is discovered
-        return not await self.fs._ls(self.path)
+        try:
+            return not await self.fs._ls(self.path)
+        except FileNotFoundError:
+            return True
 
     def with_mode(self, mode: AccessModeLiteral) -> Self:
         # docstring inherited

tests/v3/test_store/test_remote.py

@@ -186,3 +186,10 @@ def test_from_upath(self) -> None:
         path = UPath(f"s3://{test_bucket_name}", endpoint_url=endpoint_url, anon=False)
         result = RemoteStore.from_upath(path)
         assert result.fs.endpoint_url == endpoint_url
+
+    async def test_empty_nonexistent_path(self, store_kwargs) -> None:
+        # regression test for https://github.com/zarr-developers/zarr-python/pull/2343
+        store_kwargs["mode"] = "w-"
+        store_kwargs["path"] += "/abc"
+        store = await self.store_cls.open(**store_kwargs)
+        assert await store.empty()