Remove/relax erroneous "meta" path check (#1123)

* assertion on path not containing meta should be meta/

this avoids disallowing key names such as 'metabolite', for instance

* remove meta check altogether from the v2 branch as it is v3-specific

* update docs/release.rst

* Add test for #6853

Co-authored-by: Josh Moore <[email protected]>

Author: grlee77

docs/release.rst

@@ -35,6 +35,9 @@ Bug fixes
 * Fix bug in LRUEStoreCache in which the current size wasn't reset on invalidation.
   By :user:`BGCMHou <BGCMHou>` and :user:`Josh Moore <joshmoore>` :issue:`1076`, :issue:`1077`.
 
+* Remove erroneous check that disallowed array keys starting with "meta".
+  By :user:`Gregory R. Lee <grlee77>`; :issue:`1105`.
+
 Documentation
 ~~~~~~~~~~~~~
 

fixture/meta/.zarray

@@ -0,0 +1,23 @@
+{
+    "chunks": [
+        2,
+        2
+    ],
+    "compressor": {
+        "blocksize": 0,
+        "clevel": 5,
+        "cname": "lz4",
+        "id": "blosc",
+        "shuffle": 1
+    },
+    "dimension_separator": ".",
+    "dtype": "<i8",
+    "fill_value": 0,
+    "filters": null,
+    "order": "C",
+    "shape": [
+        2,
+        2
+    ],
+    "zarr_format": 2
+}

fixture/meta/0.0

@@ -628,7 +628,6 @@ def _array_iter(self, keys_only, method, recurse):
         if self._version == 2:
             for key in sorted(listdir(self._store, self._path)):
                 path = self._key_prefix + key
-                assert not path.startswith("meta")
                 if contains_array(self._store, path):
                     _key = key.rstrip("/")
                     yield _key if keys_only else (_key, self[key])
@@ -643,7 +642,7 @@ def _array_iter(self, keys_only, method, recurse):
                 if key.endswith(array_sfx):
                     key = key[:-len(array_sfx)]
                 path = self._key_prefix + key
-                assert not path.startswith("meta")
+                assert not path.startswith("meta/")
                 if key.endswith('.group' + self._metadata_key_suffix):
                     # skip group metadata keys
                     continue

zarr/hierarchy.py

@@ -2559,3 +2559,9 @@ def test_normalize_store_arg(tmpdir):
         path = tempfile.mkdtemp()
         store = normalize_store_arg("file://" + path, zarr_version=2, mode='w')
         assert isinstance(store, FSStore)
+
+
+def test_meta_prefix_6853():
+
+    fixture = group(store=DirectoryStore('fixture'))
+    assert list(fixture.arrays())