From 94b2bfdf5d52cac0baab2c2baf28deb3ec3a7318 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Tue, 28 Jan 2025 10:20:46 +0000 Subject: [PATCH 1/3] Fix release note filename --- changes/{2533.bigfix.rst => 2533.bugfix.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename changes/{2533.bigfix.rst => 2533.bugfix.rst} (100%) diff --git a/changes/2533.bigfix.rst b/changes/2533.bugfix.rst similarity index 100% rename from changes/2533.bigfix.rst rename to changes/2533.bugfix.rst From 69c18a3fa097f44a771b1c8c5e26c61486e2613c Mon Sep 17 00:00:00 2001 From: David Stansby Date: Tue, 28 Jan 2025 10:27:01 +0000 Subject: [PATCH 2/3] Split big release note into lots of smaller ones --- changes/2693.bugfix.1.rst | 1 + changes/2693.bugfix.2.rst | 1 + changes/2693.bugfix.3.rst | 1 + changes/2693.bugfix.4.rst | 1 + changes/2693.bugfix.rst | 13 ------------- changes/2693.feature.1.rst | 1 + changes/2693.feature.2.rst | 1 + changes/2693.feature.3.rst | 3 +++ changes/2693.feature.4.rst | 1 + changes/2693.feature.5.rst | 1 + changes/2693.feature.6.rst | 1 + changes/2693.feature.7.rst | 1 + changes/2693.feature.8.rst | 1 + changes/2693.feature.9.rst | 1 + 14 files changed, 15 insertions(+), 13 deletions(-) create mode 100644 changes/2693.bugfix.1.rst create mode 100644 changes/2693.bugfix.2.rst create mode 100644 changes/2693.bugfix.3.rst create mode 100644 changes/2693.bugfix.4.rst delete mode 100644 changes/2693.bugfix.rst create mode 100644 changes/2693.feature.1.rst create mode 100644 changes/2693.feature.2.rst create mode 100644 changes/2693.feature.3.rst create mode 100644 changes/2693.feature.4.rst create mode 100644 changes/2693.feature.5.rst create mode 100644 changes/2693.feature.6.rst create mode 100644 changes/2693.feature.7.rst create mode 100644 changes/2693.feature.8.rst create mode 100644 changes/2693.feature.9.rst diff --git a/changes/2693.bugfix.1.rst b/changes/2693.bugfix.1.rst new file mode 100644 index 0000000000..a46ad9d28d --- /dev/null +++ b/changes/2693.bugfix.1.rst @@ -0,0 +1 @@ +Match the errors raised by read only stores in StoreTests. diff --git a/changes/2693.bugfix.2.rst b/changes/2693.bugfix.2.rst new file mode 100644 index 0000000000..972ba0b27e --- /dev/null +++ b/changes/2693.bugfix.2.rst @@ -0,0 +1 @@ +Use stdout rather than stderr as the default stream for LoggingStore. diff --git a/changes/2693.bugfix.3.rst b/changes/2693.bugfix.3.rst new file mode 100644 index 0000000000..a6eed34c48 --- /dev/null +++ b/changes/2693.bugfix.3.rst @@ -0,0 +1 @@ +Ensure that ZipStore is open before getting or setting any values. diff --git a/changes/2693.bugfix.4.rst b/changes/2693.bugfix.4.rst new file mode 100644 index 0000000000..002f078345 --- /dev/null +++ b/changes/2693.bugfix.4.rst @@ -0,0 +1 @@ +Update equality for LoggingStore and WrapperStore such that 'other' must also be a LoggingStore or WrapperStore respectively, rather than only checking the types of the stores they wrap. diff --git a/changes/2693.bugfix.rst b/changes/2693.bugfix.rst deleted file mode 100644 index 14b45a221e..0000000000 --- a/changes/2693.bugfix.rst +++ /dev/null @@ -1,13 +0,0 @@ -Implement open() for LoggingStore -LoggingStore is now a generic class. -Use stdout rather than stderr as the default stream for LoggingStore -Ensure that ZipStore is open before getting or setting any values -Update equality for LoggingStore and WrapperStore such that 'other' must also be a LoggingStore or WrapperStore respectively, rather than only checking the types of the stores they wrap. -Indicate StoreTest's `test_store_repr`, `test_store_supports_writes`, `test_store_supports_partial_writes`, and `test_store_supports_listing` need to be implemented using `@abstractmethod` rather than `NotImplementedError`. -Separate instantiating and opening a store in StoreTests -Test using Store as a context manager in StoreTests -Match the errors raised by read only stores in StoreTests -Test that a ValueError is raise for invalid byte range syntax in StoreTests -Test getsize() and getsize_prefix() in StoreTests -Test the error raised for invalid buffer arguments in StoreTests -Test that data can be written to a store that's not yet open using the store.set method in StoreTests diff --git a/changes/2693.feature.1.rst b/changes/2693.feature.1.rst new file mode 100644 index 0000000000..faf54d4d37 --- /dev/null +++ b/changes/2693.feature.1.rst @@ -0,0 +1 @@ +Implemented open() for LoggingStore. diff --git a/changes/2693.feature.2.rst b/changes/2693.feature.2.rst new file mode 100644 index 0000000000..091ce4754e --- /dev/null +++ b/changes/2693.feature.2.rst @@ -0,0 +1 @@ +LoggingStore is now a generic class. diff --git a/changes/2693.feature.3.rst b/changes/2693.feature.3.rst new file mode 100644 index 0000000000..a0fdd77082 --- /dev/null +++ b/changes/2693.feature.3.rst @@ -0,0 +1,3 @@ +Change StoreTest's `test_store_repr`, `test_store_supports_writes`, +`test_store_supports_partial_writes`, and `test_store_supports_listing` +to to be implemented using `@abstractmethod`, rather raising `NotImplementedError`s. diff --git a/changes/2693.feature.4.rst b/changes/2693.feature.4.rst new file mode 100644 index 0000000000..c69ec87cc5 --- /dev/null +++ b/changes/2693.feature.4.rst @@ -0,0 +1 @@ +Separate instantiating and opening a store in StoreTests. diff --git a/changes/2693.feature.5.rst b/changes/2693.feature.5.rst new file mode 100644 index 0000000000..b9dde46f67 --- /dev/null +++ b/changes/2693.feature.5.rst @@ -0,0 +1 @@ +Add a test for using Stores as a context managers in StoreTests. diff --git a/changes/2693.feature.6.rst b/changes/2693.feature.6.rst new file mode 100644 index 0000000000..3dd6c79c8d --- /dev/null +++ b/changes/2693.feature.6.rst @@ -0,0 +1 @@ +Test that a ValueError is raised for invalid byte range syntax in StoreTests. diff --git a/changes/2693.feature.7.rst b/changes/2693.feature.7.rst new file mode 100644 index 0000000000..dfa346391a --- /dev/null +++ b/changes/2693.feature.7.rst @@ -0,0 +1 @@ +Test getsize() and getsize_prefix() in StoreTests. diff --git a/changes/2693.feature.8.rst b/changes/2693.feature.8.rst new file mode 100644 index 0000000000..3a9d4043a2 --- /dev/null +++ b/changes/2693.feature.8.rst @@ -0,0 +1 @@ +Test the error raised for invalid buffer arguments in StoreTests. diff --git a/changes/2693.feature.9.rst b/changes/2693.feature.9.rst new file mode 100644 index 0000000000..8362e89b17 --- /dev/null +++ b/changes/2693.feature.9.rst @@ -0,0 +1 @@ +Test that data can be written to a store that's not yet open using the store.set method in StoreTests From 0e32ae1d8db2ef6e105ed547318572660e0309dd Mon Sep 17 00:00:00 2001 From: David Stansby Date: Tue, 28 Jan 2025 10:55:25 +0000 Subject: [PATCH 3/3] Fix code syntax --- changes/2693.feature.3.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/changes/2693.feature.3.rst b/changes/2693.feature.3.rst index a0fdd77082..06200e3010 100644 --- a/changes/2693.feature.3.rst +++ b/changes/2693.feature.3.rst @@ -1,3 +1,3 @@ -Change StoreTest's `test_store_repr`, `test_store_supports_writes`, -`test_store_supports_partial_writes`, and `test_store_supports_listing` -to to be implemented using `@abstractmethod`, rather raising `NotImplementedError`s. +Change StoreTest's ``test_store_repr``, ``test_store_supports_writes``, +``test_store_supports_partial_writes``, and ``test_store_supports_listing`` +to to be implemented using ``@abstractmethod``, rather raising ``NotImplementedError``.