diff --git a/docs/release.rst b/docs/release.rst index 5ebb52bdab..6cb49b371c 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -20,6 +20,9 @@ Next release By :user:`Josh Moore `; :issue:`571`. +* ``encode_group_metadata`` metadata parameter is now mandatory. + + .. _release_2.4.0: 2.4.0 diff --git a/zarr/meta.py b/zarr/meta.py index 181c6efa69..4886a18d3d 100644 --- a/zarr/meta.py +++ b/zarr/meta.py @@ -106,12 +106,8 @@ def decode_group_metadata(s): return meta -# N.B., keep `meta` parameter as a placeholder for future -# noinspection PyUnusedLocal -def encode_group_metadata(meta=None): - meta = dict( - zarr_format=ZARR_FORMAT, - ) +def encode_group_metadata(meta): + meta["zarr_format"] = ZARR_FORMAT return json_dumps(meta) diff --git a/zarr/tests/test_storage.py b/zarr/tests/test_storage.py index a0c8412e23..c193d791cc 100644 --- a/zarr/tests/test_storage.py +++ b/zarr/tests/test_storage.py @@ -499,7 +499,7 @@ def test_init_array_overwrite_group(self): # setup path = 'foo/bar' store = self.create_store() - store[path + '/' + group_meta_key] = encode_group_metadata() + store[path + "/" + group_meta_key] = encode_group_metadata({}) # don't overwrite with pytest.raises(ValueError):