-
Notifications
You must be signed in to change notification settings - Fork 31
Non-deletable stores. #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Carreau, I think it is reasonable if a store does not support deletion. If you agree, then yes I'd suggest we clarify that supporting deletion is optional somehow. E.g., maybe stores can be readable, writable, deletable, listable, these are the basic capabilities. A store that is only readable can still be useful. Similarly a store that is only readable and writable can still be useful. |
That's fine with me, but that's push more complexity on the Zarr Protocol implementation, while you could try to push the deletion implementation details to the store. That seem also to be there only to accommodate the zip store. |
So this includes that there may be stores that do not support deletion (such as any read-only store would, too). I assume that resolves this issue, please re-open if that's not the case. |
Think what Matthias was referring to is That said, think in practice Side note: We may prefer to fix the |
Thanks for the clarification @jakirkham! Do you think there's a TODO for the current v3 core spec from this issue? I'm re-opening it, but I'm not quite sure if this belongs into the zarr-specs repo or rather zarr-python? Sorry for the confusion, seems like I'm missing some context here. @joshmoore, can you help? |
Seems like there's enough confusion around this that we should minimally try to add our expectations in the V3 spec and possibly V2. @caviere will soon be investigating the ZipStore and we can try to dig into these questions which may then lead to wanting to address delete-ability more broadly in the spec. |
Since the zip store is currently not yet specified in v3 I assume this does not block ZEP 1, which is mostly about the core spec. Further clarifications can also be added to the core spec after ZEP 1 is accepted. |
I just realized that the zipStore does not allow deletion (and thus does not allow rename).
Is that something that should be addressed in the spec, of should it maybe be fixed in the ZipStore with TombStones ?
The text was updated successfully, but these errors were encountered: