tmpFilePath: re-use the same function

And move under `Compilation.Directory`, since it belongs there most.

Author: motiejus

src/Compilation.zig

@@ -3981,7 +3981,7 @@ fn updateCObject(comp: *Compilation, c_object: *CObject, c_obj_prog_node: *std.P
 
         // We can't know the digest until we do the C compiler invocation,
         // so we need a temporary filename.
-        const out_obj_path = try comp.tmpFilePath(arena, o_basename);
+        const out_obj_path = try comp.local_cache_directory.tmpFilePath(arena, o_basename);
         var zig_cache_tmp_dir = try comp.local_cache_directory.handle.makeOpenPath("tmp", .{});
         defer zig_cache_tmp_dir.close();
 
@@ -4129,16 +4129,6 @@ fn updateCObject(comp: *Compilation, c_object: *CObject, c_obj_prog_node: *std.P
     };
 }
 
-pub fn tmpFilePath(comp: *Compilation, ally: Allocator, suffix: []const u8) error{OutOfMemory}![]const u8 {
-    const s = std.fs.path.sep_str;
-    const rand_int = std.crypto.random.int(u64);
-    if (comp.local_cache_directory.path) |p| {
-        return std.fmt.allocPrint(ally, "{s}" ++ s ++ "tmp" ++ s ++ "{x}-{s}", .{ p, rand_int, suffix });
-    } else {
-        return std.fmt.allocPrint(ally, "tmp" ++ s ++ "{x}-{s}", .{ rand_int, suffix });
-    }
-}
-
 pub fn addTranslateCCArgs(
     comp: *Compilation,
     arena: Allocator,

src/main.zig

@@ -668,19 +668,9 @@ fn copyToFile(
     in_fd: std.os.fd_t,
     dst_dir: Compilation.Directory,
 ) ![]const u8 {
-    // the section below is inspired by Compilation.tmpFilePath
-    const new_name = blk: {
-        const s = std.fs.path.sep_str;
-        const rand_int = std.crypto.random.int(u64);
-        if (dst_dir.path) |p| {
-            break :blk try std.fmt.allocPrint(arena, "{s}" ++ s ++ "tmp" ++ s ++ "{x}", .{ p, rand_int });
-        } else {
-            break :blk try std.fmt.allocPrint(arena, "tmp" ++ s ++ "{x}", .{rand_int});
-        }
-    };
+    const new_name = try dst_dir.tmpFilePath(arena, "waspipe");
     try dst_dir.handle.makePath("tmp");
-
-    var outfile = try dst_dir.handle.createFile(new_name, std.fs.File.CreateFlags{ .exclusive = true });
+    var outfile = try dst_dir.handle.createFile(new_name, .{});
     defer outfile.close();
     errdefer dst_dir.handle.deleteFile(new_name) catch {};
 
@@ -3967,7 +3957,7 @@ fn cmdTranslateC(comp: *Compilation, arena: Allocator, fancy_output: ?*Translate
 
             const c_src_basename = fs.path.basename(c_source_file.src_path);
             const dep_basename = try std.fmt.allocPrint(arena, "{s}.d", .{c_src_basename});
-            const out_dep_path = try comp.tmpFilePath(arena, dep_basename);
+            const out_dep_path = try comp.local_cache_directory.tmpFilePath(arena, dep_basename);
             break :blk out_dep_path;
         };