stage2: compiler panic when using @ptrToInt in bitwise AND

[topolarity]

Zig Version

0.10.0-dev.1393+291f5055f

Steps to Reproduce

test "comptime ptrToInt in AND expression" {
    comptime var x: u8 = 15;
    try std.testing.expect(@ptrToInt(&x) & 0x00 == 0);
}

Expected Behavior

Test should compile successfully and pass.

Actual Behavior

The test fails because we end up calling toBigInt on a decl_ref_mut, which is not an integer type.

We're probably missing a dereference here for the indirect Value.

Analyzing testme.zig: testme.zig:test.comptime ptrToInt in AND expression
      %28 = decl_ref("std")
      %29 = field_ptr(%28, "testing")
      %30 = field_call_bind(%29, "expect")
      %31 = dbg_stmt(3, 27)
      %32 = ptr_to_int(%23)
      %33 = int(255)
    > %34 = bit_and(%32, %33)
      %35 = cmp_eq(%34, @Ref.zero)
      %36 = call(.auto, %30, [%35])
      %37 = is_non_err(%36)
      %38 = condbr(%37, {
        %40 = err_union_payload_unsafe(%36)
        %43 = break(%39, %40)
      }, {
        %41 = err_union_code(%36)
        %42 = ret_node(%41)
      })
    For full context, use the command
      zig ast-check -t testme.zig

  in testme.zig: testme.zig:test.comptime ptrToInt in AND expression
    > %39 = block({%28..%38})

error(stdlib): metadata: 7fdb1aa25f68
/home/topolarity/repos/zig/src/value.zig:983:21: 0x3080801 in value.Value.toBigInt (zig)
            else => unreachable,
                    ^
/home/topolarity/repos/zig/src/value.zig:3007:40: 0x34dfe1b in value.Value.bitwiseAnd (zig)
        const lhs_bigint = lhs.toBigInt(&lhs_space);
                                       ^
/home/topolarity/repos/zig/src/Sema.zig:8222:51: 0x3323c31 in Sema.zirBitwise (zig)
                .bit_and => try lhs_val.bitwiseAnd(rhs_val, sema.arena),
                                                  ^
/home/topolarity/repos/zig/src/Sema.zig:645:65: 0x31e1c8a in Sema.analyzeBodyInner (zig)
            .bit_and                      => try sema.zirBitwise(block, inst, .bit_and),
                                                                ^
/home/topolarity/repos/zig/src/Sema.zig:3850:34: 0x35083c2 in Sema.resolveBlockBody (zig)
        if (sema.analyzeBodyInner(child_block, body)) |_| {
                                 ^

[davidgmbb]

This is no longer crashing

[Vexu]

Now it just behaves (IMO) incorrectly.