False dependency loop

[DerryAlex]

Zig Version

0.11.0-dev.923+a52dcdd3c

Steps to Reproduce and Observed Behavior

Possibly related #14005

Observed Behavior:

error: struct 'GLib.SListNullable' depends on itself
pub const SListNullable = packed struct {
                          ~~~~~~~^~~~~~
referenced by:
    SListImpl: /home/chief/workplace/gir-zig/generate/output/GLib.zig:8243:30
    SListNullable: /home/chief/workplace/gir-zig/generate/output/GLib.zig:8250:17
    SListNullable: /home/chief/workplace/gir-zig/generate/output/GLib.zig:8249:34
    SListImpl: /home/chief/workplace/gir-zig/generate/output/GLib.zig:8247:15

Related code

pub const SListImpl = extern struct { // L8243
    /// read write 
    Data: ?*anyopaque,
    /// read write 
    Next: core.SListNullable, // L8247
};
pub const SListNullable = packed struct { // L8249
    instance: ?*SListImpl, // L8250

    pub fn new(self: ?SList) SListNullable {
        return .{ .instance = if (self) |some| some.instance else null };
    }

    pub fn get(self: SListNullable) ?SList {
        return if (self.instance) |some| SList{ .instance = some } else null;
    }
};

I failed to narrow down this. If extracted into small files, it behaves correctly. Maybe there is something to do with the file size.

Possibly related infomation

// GLib.zig
const core = @import("core.zig");

// core.zig
const GLib = @import("GLib.zig");
pub usingnamespace GLib;

Expected Behavior

No error

[nektro]

don't think there's a bug here imo likely duplicate of #12325

[Vexu]

Reduction:

const SListImpl = extern struct {
    Next: SListNullable,
};
const SListNullable = packed struct {
    instance: ?*SListImpl,
};
comptime {
    _ = @sizeOf(SListNullable) + 1;
}

Removing extern makes it work.

[jayschwa]

This appears to be fixed in master after #17172 was merged.

[jayschwa]

This issue was originally assigned to the 0.11.1 milestone. Now that it's closed and only fixed in master, I changed the milestone to 0.12.0. FYI, in case the issue should still exist in 0.11.1 and be reopened.

[nektro]

the 0.11.1 milestone is andrew's checklist to cherry pick fixes, 0.12.0 is for if only going to be fixed in future versions

[andrewrk]

Don't worry, the git commit log is my checklist