Skip to content

Proposal: add name field to TypeInfo.FnArg #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
data-man opened this issue Oct 3, 2020 · 6 comments
Closed

Proposal: add name field to TypeInfo.FnArg #6530

data-man opened this issue Oct 3, 2020 · 6 comments
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.14.0

Comments

@data-man
Copy link
Contributor

data-man commented Oct 3, 2020

Declaration.data.Fn.arg_names is a bit inconvenient to use.
@tadeokondrak
Copy link
Contributor

tadeokondrak commented Oct 3, 2020 •
edited
Loading

What is the usefulness of getting a function's argument names in the first place?

Although assuming #1717 gets implemented and this ability stays, this seems like it's the best way.

@data-man
Copy link
Contributor Author

data-man commented Oct 3, 2020

What is the usefulness of getting a function's argument names in the first place?

  • benchmarkers
  • testers
  • can be used in std.fmt
  • etc.

@andrewrk
Copy link
Member

andrewrk commented Oct 4, 2020

Although assuming #1717 gets implemented and this ability stays, this seems like it's the best way.

Seems reasonable.

@andrewrk andrewrk added accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Oct 4, 2020
@andrewrk andrewrk added this to the 0.8.0 milestone Oct 4, 2020
@andrewrk andrewrk mentioned this issue Oct 4, 2020
Closed
@andrewrk
Copy link
Member

andrewrk commented Oct 4, 2020

assuming...this ability stays

#6534

@data-man
Copy link
Contributor Author

data-man commented Oct 4, 2020

Wow! My first accepted proposal. Thanks! 😄

@andrewrk
Copy link
Member

andrewrk commented Oct 4, 2020

Congrats :)

@data-man data-man mentioned this issue Mar 15, 2021
Closed
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 May 19, 2021
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 Nov 20, 2021
@andrewrk andrewrk modified the milestones: 0.10.0, 0.11.0 Apr 16, 2022
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Apr 9, 2023
@andrewrk andrewrk modified the milestones: 0.13.0, 0.12.0 Jun 29, 2023
@andrewrk andrewrk removed the accepted This proposal is planned. label Jan 25, 2025
@andrewrk andrewrk closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@andrewrk @data-man @tadeokondrak