Skip to content

enable optimizations for coroutines #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewrk opened this issue Mar 2, 2018 · 1 comment
Closed

enable optimizations for coroutines #802

andrewrk opened this issue Mar 2, 2018 · 1 comment
Labels
optimization upstream An issue with a third party project that Zig uses.
Milestone
0.5.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Mar 2, 2018

Right now we set optnone noinline on coroutines because of https://bugs.llvm.org/show_bug.cgi?id=36578

We also don't do the coroutine allocation elision IR because of a bug I didn't file yet. (I implemented it and it crashed LLVM).

This issue is to do both of these optimizations.
@andrewrk andrewrk added optimization upstream An issue with a third party project that Zig uses. labels Mar 2, 2018
@andrewrk andrewrk added this to the 1.1.0 milestone Mar 2, 2018
@andrewrk andrewrk mentioned this issue Apr 29, 2019
Closed
@andrewrk
Copy link
Member Author

Solved by not using LLVM's coroutines, merged in #3033.

@andrewrk andrewrk modified the milestones: 1.1.0, 0.5.0 Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization upstream An issue with a third party project that Zig uses.
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@andrewrk