Allow deserialization failures with some commands.

See home-assistant/core#50005

Author: puddly

tests/api/test_request.py

@@ -285,3 +285,36 @@ async def test_znp_unknown_frame(connected_znp, caplog):
 
     # Unknown frames are logged in their entirety but an error is not thrown
     assert repr(frame) in caplog.text
+
+
+async def test_handling_known_bad_command_parsing(connected_znp, caplog):
+    znp, _ = connected_znp
+
+    bad_frame = GeneralFrame(
+        header=t.CommandHeader(
+            id=0x9F, subsystem=t.Subsystem.ZDO, type=t.CommandType.AREQ
+        ),
+        data=b"\x13\xDB\x84\x01\x21",
+    )
+
+    caplog.set_level(logging.WARNING)
+    znp.frame_received(bad_frame)
+
+    # The frame is expected to fail to parse so will be logged as only a warning
+    assert len(caplog.records) == 1
+    assert caplog.records[0].levelname == "WARNING"
+    assert repr(bad_frame) in caplog.messages[0]
+
+
+async def test_handling_unknown_bad_command_parsing(connected_znp):
+    znp, _ = connected_znp
+
+    bad_frame = GeneralFrame(
+        header=t.CommandHeader(
+            id=0xCB, subsystem=t.Subsystem.ZDO, type=t.CommandType.AREQ
+        ),
+        data=b"\x13\xDB\x84\x01\x21",
+    )
+
+    with pytest.raises(ValueError):
+        znp.frame_received(bad_frame)

zigpy_znp/api.py

@@ -358,7 +358,17 @@ def frame_received(self, frame: GeneralFrame) -> bool:
             return
 
         command_cls = c.COMMANDS_BY_ID[frame.header]
-        command = command_cls.from_frame(frame, align=self.nvram.align_structs)
+
+        try:
+            command = command_cls.from_frame(frame, align=self.nvram.align_structs)
+        except ValueError:
+            # Some commands can be received corrupted. They are not useful:
+            # https://github.com/home-assistant/core/issues/50005
+            if command_cls == c.ZDO.ParentAnnceRsp.Callback:
+                LOGGER.warning("Failed to parse broken %s as %s", frame, command_cls)
+                return
+
+            raise
 
         LOGGER.debug("Received command: %s", command)