Skip to content

Commit 47d83e2

Browse files
sukrawidhyawanandy-shi88
authored andcommitted
Set lowest level logger (#403)
* set lowest log level will fire on console * add missing logger * Remove warn log level in config file * update comment config file
1 parent 52e1c57 commit 47d83e2

File tree

11 files changed

+42
-15
lines changed

11 files changed

+42
-15
lines changed

cmd/block/blockGenerator.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ func generateBlocks(numberOfBlocks int, blocksmithSecretPhrase, outputPath strin
161161
blocksmith,
162162
blockService,
163163
nodeRegistrationService,
164+
log.New(),
164165
)
165166
startTime := time.Now().UnixNano() / 1e6
166167
fmt.Printf("generating %d blocks\n", numberOfBlocks)

common/interceptor/interceptor.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func NewServerInterceptor(logger *logrus.Logger, ownerAddress string) grpc.Unary
5858
case err != nil:
5959
logger.WithFields(fields).Error(fmt.Sprint(err))
6060
case errHandler != nil:
61-
logger.WithFields(fields).Warning(errHandler)
61+
logger.WithFields(fields).Error(errHandler)
6262
default:
6363
logger.WithFields(fields).Info("success")
6464
}
@@ -119,7 +119,7 @@ func NewClientInterceptor(logger *logrus.Logger, ignoredErrors map[codes.Code]st
119119
case errInvoker != nil:
120120
statusCode, isKnownErr := status.FromError(errInvoker)
121121
if !isKnownErr || (ignoredErrors[statusCode.Code()] == "") {
122-
logger.WithFields(fields).Warning(fmt.Sprint(errInvoker))
122+
logger.WithFields(fields).Error(fmt.Sprint(errInvoker))
123123
}
124124
default:
125125
logger.WithFields(fields).Info("success")

common/util/logger.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,11 @@ InitLogger is function that should be implemeneted with interceptor. That can ce
3838
*/
3939
func InitLogger(path, filename string, levels []string) (*logrus.Logger, error) {
4040
var (
41-
logLevels []logrus.Level
42-
logger *logrus.Logger
43-
err error
44-
logFile *os.File
41+
logLevels []logrus.Level
42+
lowestLevel logrus.Level
43+
logger *logrus.Logger
44+
err error
45+
logFile *os.File
4546
)
4647
_, err = os.Stat(path)
4748
if err != nil && os.IsNotExist(err) {
@@ -69,6 +70,10 @@ func InitLogger(path, filename string, levels []string) (*logrus.Logger, error)
6970
case "panic":
7071
logLevels = append(logLevels, logrus.PanicLevel)
7172
}
73+
// lowestLevel will based on the list log level will use
74+
if lowestLevel < logLevels[len(logLevels)-1] {
75+
lowestLevel = logLevels[len(logLevels)-1]
76+
}
7277
}
7378
if len(logLevels) < 1 {
7479
logLevels = append(
@@ -84,6 +89,8 @@ func InitLogger(path, filename string, levels []string) (*logrus.Logger, error)
8489
Writer: logFile,
8590
EntryLevels: logLevels,
8691
})
92+
// lowestLevel use to set lowest level will fire
93+
logger.SetLevel(lowestLevel)
8794

8895
return logger, nil
8996
}

core/blockchainsync/blockchainSync.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func (bss *Service) GetMoreBlocksThread(runNext chan bool) {
9797
}
9898

9999
func (bss *Service) getMoreBlocks(runNext chan bool) {
100-
log.Info("Get more blocks...")
100+
bss.Logger.Info("Get more blocks...")
101101
// notify observer about start of blockchain download of this specific chain
102102

103103
lastBlock, err := bss.BlockService.GetLastBlock()

core/smith/blockchainProcessor.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ type (
3636
BlockService service.BlockServiceInterface
3737
NodeRegistrationService service.NodeRegistrationServiceInterface
3838
LastBlockID int64
39+
Logger *log.Logger
3940
}
4041
)
4142

@@ -45,12 +46,14 @@ func NewBlockchainProcessor(
4546
blocksmith *model.Blocksmith,
4647
blockService service.BlockServiceInterface,
4748
nodeRegistrationService service.NodeRegistrationServiceInterface,
49+
logger *log.Logger,
4850
) *BlockchainProcessor {
4951
return &BlockchainProcessor{
5052
Chaintype: ct,
5153
Generator: blocksmith,
5254
BlockService: blockService,
5355
NodeRegistrationService: nodeRegistrationService,
56+
Logger: logger,
5457
}
5558
}
5659

@@ -62,10 +65,10 @@ func (bp *BlockchainProcessor) CalculateSmith(lastBlock *model.Block, generator
6265
// since default balance was 1000 times higher than default ps
6366
ps, err := bp.BlockService.GetParticipationScore(generator.NodePublicKey)
6467
if ps == 0 {
65-
log.Info("Node has participation score = 0. Either is not registered or has been expelled from node registry")
68+
bp.Logger.Info("Node has participation score = 0. Either is not registered or has been expelled from node registry")
6669
}
6770
if err != nil {
68-
log.Errorf("Participation score calculation: %s", err)
71+
bp.Logger.Errorf("Participation score calculation: %s", err)
6972
generator.Score = big.NewInt(0)
7073
} else {
7174
generator.Score = big.NewInt(ps / int64(constant.ScalarReceiptScore))
@@ -209,7 +212,7 @@ func (bp *BlockchainProcessor) SortBlocksmith(sortedBlocksmiths *[]model.Blocksm
209212
var blocksmiths []model.Blocksmith
210213
nextBlocksmiths, err := bp.BlockService.GetBlocksmiths(lastBlock)
211214
if err != nil {
212-
log.Errorf("SortBlocksmith: %s", err)
215+
bp.Logger.Errorf("SortBlocksmith: %s", err)
213216
return
214217
}
215218
// copy the nextBlocksmiths pointers array into an array of blocksmiths

core/smith/blockchainProcessor_test.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"reflect"
77
"testing"
88

9+
log "github.com/sirupsen/logrus"
910
"github.com/zoobc/zoobc-core/common/util"
1011
coreUtil "github.com/zoobc/zoobc-core/core/util"
1112

@@ -21,6 +22,7 @@ func TestNewBlockchainProcessor(t *testing.T) {
2122
blocksmith *model.Blocksmith
2223
blockService service.BlockServiceInterface
2324
nodeRegistrationService service.NodeRegistrationServiceInterface
25+
logger *log.Logger
2426
}
2527
tests := []struct {
2628
name string
@@ -46,7 +48,12 @@ func TestNewBlockchainProcessor(t *testing.T) {
4648
for _, tt := range tests {
4749
t.Run(tt.name, func(t *testing.T) {
4850
if got := NewBlockchainProcessor(
49-
tt.args.ct, tt.args.blocksmith, tt.args.blockService, tt.args.nodeRegistrationService); !reflect.DeepEqual(got, tt.want) {
51+
tt.args.ct,
52+
tt.args.blocksmith,
53+
tt.args.blockService,
54+
tt.args.nodeRegistrationService,
55+
tt.args.logger,
56+
); !reflect.DeepEqual(got, tt.want) {
5057
t.Errorf("NewBlockchainProcessor() = %v, want %v", got, tt.want)
5158
}
5259
})
@@ -212,6 +219,7 @@ func TestBlockchainProcessor_SortBlocksmith_01(t *testing.T) {
212219
},
213220
&mockBlockService{},
214221
nil,
222+
log.New(),
215223
)
216224
listener := bProcessor.SortBlocksmith(&sortedBlocksmiths)
217225
listener.OnNotify(&model.Block{}, &chaintype.MainChain{})
@@ -274,6 +282,7 @@ func TestBlockchainProcessor_SortBlocksmith_02(t *testing.T) {
274282
},
275283
&mockBlockService{},
276284
nil,
285+
log.New(),
277286
)
278287
listener := bProcessor.SortBlocksmith(&sortedBlocksmiths)
279288
listener.OnNotify(&model.Block{}, &chaintype.MainChain{})
@@ -338,6 +347,7 @@ func TestBlockchainProcessor_SortBlocksmith_03(t *testing.T) {
338347
},
339348
&mockBlockService{},
340349
nil,
350+
log.New(),
341351
)
342352
listener := bProcessor.SortBlocksmith(&sortedBlocksmiths)
343353
listener.OnNotify(&model.Block{}, &chaintype.MainChain{})
@@ -412,6 +422,7 @@ func TestBlockchainProcessor_SortBlocksmith_fail(t *testing.T) {
412422
},
413423
&mockBlockServiceFail{},
414424
nil,
425+
log.New(),
415426
)
416427
listener := bProcessor.SortBlocksmith(&sortedBlocksmiths)
417428
listener.OnNotify(&model.Block{

main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ func startMainchain(mainchainSyncChannel chan bool) {
353353
model.NewBlocksmith(nodeSecretPhrase, util.GetPublicKeyFromSeed(nodeSecretPhrase)),
354354
mainchainBlockService,
355355
nodeRegistrationService,
356+
loggerCoreService,
356357
)
357358

358359
if !mainchainBlockService.CheckGenesis() { // Add genesis if not exist

resource/config.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ ownerAccountAddress = "BCZEGOb3WNx3fDOVf9ZS4EjvOIv_UeW4TVBQJ_6tHKlE"
2121
smithing=true
2222
proofOfOwnershipReqTimeoutSec = 2
2323
# Log Levels
24-
logLevels=["warn", "fatal", "error", "panic"]
24+
# Available log level: info, warn, error, fatal, panic
25+
logLevels=["fatal", "error", "panic"]

resource/config2.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ ownerAccountAddress = "OnEYzI-EMV6UTfoUEzpQUjkSlnqB82-SyRN7469lJTWH"
2020
# smithing=true
2121
proofOfOwnershipReqTimeoutSec = 1
2222
# Log Levels
23-
logLevels=["warn", "fatal", "error", "panic"]
23+
# Available log level: info, warn, error, fatal, panic
24+
logLevels=["fatal", "error", "panic"]

resource/config3.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ ownerAccountAddress = "BCZKLvgUYZ1KKx-jtF9KoJskjVPvB9jpIjfzzI6zDW0J"
1919

2020
proofOfOwnershipReqTimeoutSec = 1
2121
# Log Levels
22-
logLevels=["warn", "fatal", "error", "panic"]
22+
# Available log level: info, warn, error, fatal, panic
23+
logLevels=["fatal", "error", "panic"]

resource/config4.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ ownerAccountAddress = "nK_ouxdDDwuJiogiDAi_zs1LqeN7f5ZsXbFtXGqGc0Pd"
1818

1919
proofOfOwnershipReqTimeoutSec = 1
2020
# Log Levels
21-
logLevels=["warn", "fatal", "error", "panic"]
21+
# Available log level: info, warn, error, fatal, panic
22+
logLevels=["fatal", "error", "panic"]

0 commit comments

Comments
 (0)