fix some test cases that is affected

Author: astaphobia

common/transaction/multiSignature_test.go

@@ -3,6 +3,7 @@ package transaction
 import (
 	"database/sql"
 	"errors"
+	"fmt"
 	"reflect"
 	"testing"
 
@@ -1161,7 +1162,7 @@ type (
 	mockMultisignatureValidateMultisigInfoExist struct {
 		MultisignatureInfoHelperInterface
 	}
-	mockValidateMultisigUtilValidateSignatureInfoSucess struct {
+	mockValidateMultisigUtilValidateSignatureInfoSuccess struct {
 		MultisigTransactionUtilInterface
 	}
 
@@ -1174,11 +1175,14 @@ var (
 	mockFeeMultisignatureValidate int64 = 10
 )
 
-func (*mockValidateMultisigUtilValidateSignatureInfoSucess) ValidateSignatureInfo(
+func (*mockValidateMultisigUtilValidateSignatureInfoSuccess) ValidateSignatureInfo(
 	signature crypto.SignatureInterface, signatureInfo *model.SignatureInfo, multisignatureAddresses map[string]bool,
 ) error {
 	return nil
 }
+func (*mockValidateMultisigUtilValidateSignatureInfoSuccess) ValidateMultisignatureInfo(info *model.MultiSignatureInfo) error {
+	return nil
+}
 
 func (*mockMultisignatureValidateMultisigInfoNotExist) GetMultisigInfoByAddress(
 	multisigInfo *model.MultiSignatureInfo,
@@ -1316,6 +1320,40 @@ func (*mockAccountBalanceHelperMultisignatureValidateSuccess) GetBalanceByAccoun
 func (*mockAccountBalanceHelperMultisignatureValidateSuccess) HasEnoughSpendableBalance(bool, []byte, int64) (enough bool, err error) {
 	return true, nil
 }
+
+type (
+	mockMultiSignatureInfoHelper struct {
+		wantErr bool
+		MultisignatureInfoHelper
+	}
+	mockMultiSigTransactionUtil struct {
+		wantErr bool
+		MultisigTransactionUtil
+	}
+)
+
+func (m *mockMultiSignatureInfoHelper) GetMultisigInfoByAddress(*model.MultiSignatureInfo, []byte, uint32) error {
+	if m.wantErr {
+		return fmt.Errorf("wantErr")
+	}
+	return nil
+}
+func (m *mockMultiSigTransactionUtil) ValidatePendingTransactionBytes(
+	UtilInterface,
+	TypeActionSwitcher,
+	MultisignatureInfoHelperInterface,
+	PendingTransactionHelperInterface,
+	*model.MultiSignatureInfo,
+	[]byte, []byte,
+	uint32,
+	bool,
+) error {
+	if m.wantErr {
+		return fmt.Errorf("wantErr")
+	}
+	return nil
+}
+
 func TestMultiSignatureTransaction_Validate(t *testing.T) {
 	type fields struct {
 		ID                       int64
@@ -1404,7 +1442,7 @@ func TestMultiSignatureTransaction_Validate(t *testing.T) {
 				},
 				MultisigUtil:             &mockMultisignatureValidateMultisigUtilValidateMultisigInfoSuccessSignatureInfoFail{},
 				AccountBalanceHelper:     &mockAccountBalanceHelperMultisignatureValidateSuccess{},
-				MultisignatureInfoHelper: &MultisignatureInfoHelper{},
+				MultisignatureInfoHelper: &mockMultiSignatureInfoHelper{},
 			},
 			args: args{
 				dbTx: true,
@@ -1438,8 +1476,9 @@ func TestMultiSignatureTransaction_Validate(t *testing.T) {
 					UnsignedTransactionBytes: make([]byte, 32),
 					SignatureInfo:            &model.SignatureInfo{},
 				},
-				MultisigUtil:         &mockMultisignatureValidateMultisigUtilValidatePendingTxSuccessValidateSignatureInfoFail{},
-				AccountBalanceHelper: &mockAccountBalanceHelperMultisignatureValidateSuccess{},
+				MultisigUtil:             &mockMultiSigTransactionUtil{},
+				AccountBalanceHelper:     &mockAccountBalanceHelperMultisignatureValidateSuccess{},
+				PendingTransactionHelper: &mockMultisignatureValidateMultisigUtilPendingTransactionHelperPendingTransactionExist{},
 			},
 			args: args{
 				dbTx: true,
@@ -1520,26 +1559,6 @@ func TestMultiSignatureTransaction_Validate(t *testing.T) {
 			},
 			wantErr: true,
 		},
-		{
-			name: "Validate - multisignatureInfo:notExist - pending transaction exist - " +
-				"get multisigInfo exist - ValidateSignatureSuccess",
-			fields: fields{
-				Fee: mockFeeMultisignatureValidate,
-				Body: &model.MultiSignatureTransactionBody{
-					MultiSignatureInfo:       nil,
-					UnsignedTransactionBytes: nil,
-					SignatureInfo:            &model.SignatureInfo{},
-				},
-				PendingTransactionHelper: &mockMultisignatureValidateMultisigUtilPendingTransactionHelperPendingTransactionExist{},
-				MultisignatureInfoHelper: &mockMultisignatureValidateMultisigInfoExist{},
-				MultisigUtil:             &mockValidateMultisigUtilValidateSignatureInfoSucess{},
-				AccountBalanceHelper:     &mockAccountBalanceHelperMultisignatureValidateSuccess{},
-			},
-			args: args{
-				dbTx: true,
-			},
-			wantErr: false,
-		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {