Bug Fixing (#639)

* Fix bug in pendingSignatureQuery rollback function
* Remove unused function from transactionQuery

Co-authored-by: stefano galassi <[email protected]>

Author: iltoga

common/query/pendingSignatureQuery.go

@@ -129,7 +129,7 @@ func (psq *PendingSignatureQuery) BuildModel(
 func (psq *PendingSignatureQuery) Rollback(height uint32) (multiQueries [][]interface{}) {
 	return [][]interface{}{
 		{
-			fmt.Sprintf("DELETE FROM %s WHERE height > ?", psq.TableName),
+			fmt.Sprintf("DELETE FROM %s WHERE block_height > ?", psq.TableName),
 			height,
 		},
 		{

common/query/pendingSignatureQuery_test.go

@@ -334,7 +334,7 @@ func TestPendingSignatureQuery_Rollback(t *testing.T) {
 			},
 			wantMultiQueries: [][]interface{}{
 				{
-					"DELETE FROM pending_signature WHERE height > ?",
+					"DELETE FROM pending_signature WHERE block_height > ?",
 					uint32(10),
 				},
 				{

common/query/transactionQuery.go

@@ -17,7 +17,6 @@ type (
 		GetTransactionsByBlockID(blockID int64) (str string, args []interface{})
 		ExtractModel(tx *model.Transaction) []interface{}
 		BuildModel(txs []*model.Transaction, rows *sql.Rows) ([]*model.Transaction, error)
-		DeleteTransactions(id int64) string
 		Scan(tx *model.Transaction, row *sql.Row) error
 	}
 
@@ -95,11 +94,6 @@ func (tq *TransactionQuery) GetTransactionsByIds(txIds []int64) (str string, arg
 	return query, []interface{}{}
 }
 
-// DeleteTransactions. delete some transactions according to timestamp
-func (tq *TransactionQuery) DeleteTransactions(id int64) string {
-	return fmt.Sprintf("DELETE FROM %v WHERE height >= (SELECT height FROM %v WHERE ID = %v)", tq.getTableName(), tq.getTableName(), id)
-}
-
 // ExtractModel extract the model struct fields to the order of TransactionQuery.Fields
 func (*TransactionQuery) ExtractModel(tx *model.Transaction) []interface{} {
 	return []interface{}{