Skip to content

Enhance: Add Merkle Root On Main Block (for transactions) #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukrawidhyawan opened this issue Sep 29, 2020 · 0 comments · May be fixed by #1286
Open

Enhance: Add Merkle Root On Main Block (for transactions) #1225

sukrawidhyawan opened this issue Sep 29, 2020 · 0 comments · May be fixed by #1286
Assignees
Labels
CORE core functionalities ENHANCE FEATURE New feature or request WIP

Comments

@sukrawidhyawan
Copy link
Contributor

sukrawidhyawan commented Sep 29, 2020

Description

This Implementation will build the Merkle Root & Merkle Tree main block. The leaf of Merkle Root comes from the transactions included in the block. Field Merkle Root & Merkle Tree already added into the Block model when adding Merkle Root for spine block (related issue: #1205 ), it makes can directly into step on building Merkle Root on the main block

Breakdown

  • Build Merkle root for the main block from its transaction if exist otherwise leave it nil
  • Enhance validation main block to validate the Merkle Root when receiving a complete block (already included the transactions).
    • One of the options is selecting the random transaction of the block, build the intermediate hashes from Merkle Tree & validate the Merkle Root

Expected behavior

blocks will have Merkle Root & Merkle Tree & can validate it's Merkle when receiving from other peers

@sukrawidhyawan sukrawidhyawan added FEATURE New feature or request CORE core functionalities ENHANCE labels Sep 29, 2020
@sukrawidhyawan sukrawidhyawan changed the title Enhance: Add Merkle Root On Main Block Smith Enhance: Add Merkle Root On Main Block Sep 29, 2020
@allanbintoro allanbintoro self-assigned this Sep 29, 2020
@capt4ce capt4ce changed the title Enhance: Add Merkle Root On Main Block Enhance: Add Merkle Root On Main Block (for transactions) Sep 30, 2020
@allanbintoro allanbintoro linked a pull request Oct 14, 2020 that will close this issue
3 tasks
@abiman7u abiman7u added this to the V.0.0.2.W.02 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE core functionalities ENHANCE FEATURE New feature or request WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants