Skip to content

Bug: fix spine smith process #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iltoga opened this issue Feb 11, 2020 · 0 comments · Fixed by #587
Closed

Bug: fix spine smith process #586

iltoga opened this issue Feb 11, 2020 · 0 comments · Fixed by #587
Assignees
Labels
BUG Something isn't working

Comments

@iltoga
Copy link
Contributor

iltoga commented Feb 11, 2020

Description

update blocksmith selection to match the block spine public keys from previous block, both when generating new blocks and validating the ones coming from peers.

This is because, when downloading the spine blocks it could happen that the node is unable to validate new blocks if it they are smithed by newly registered nodes that have their public keys included in the same blocks the node is trying to validate (in that scenario the node's public key isn't in the db yet because the block hasn't been pushed yet)

Steps to reproduce

unfortunately this is very hard to reproduce because we should need to wait for a smithing node to generate a spine block with a newly registered blocksmith (node). Then we would have to start a new non-smithing node and wait util it downloads that spine block. At that point the node wouldn't be able to validate the block and proceed downloading the blockchain.

Expected behavior

Spine blocks smithed with a valid spine public key shouldn't fail validation

@iltoga iltoga added the BUG Something isn't working label Feb 11, 2020
@iltoga iltoga self-assigned this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant