Skip to content

Enhance: spine blocks manifest and spine public keys validation process #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iltoga opened this issue Mar 9, 2020 · 0 comments · Fixed by #631
Closed

Enhance: spine blocks manifest and spine public keys validation process #627

iltoga opened this issue Mar 9, 2020 · 0 comments · Fixed by #631
Assignees
Labels

Comments

@iltoga
Copy link
Contributor

iltoga commented Mar 9, 2020

Description

As of now spine block manifests and spine public keys records that are downloaded together with spine blocks are not validated before being pushed, so in theory a misbehaving node could send a correct spine block with a modified version of block manifest and make new nodes download its version of the snapshot referred by it.

Breakdown

  • Add general validation of spine block manifest and spine public keys in blockSpineService.ValidateBlock (there is already a TODO for that)

Expected behavior

Before pushing a block, all block attached data (spine block manifests and spine public keys) should be validated against the block's payload hash to make sure they have not been tampered by the sending node

Diagram

image

@iltoga iltoga added the ENHANCE label Mar 9, 2020
@iltoga iltoga self-assigned this Mar 9, 2020
@iltoga iltoga changed the title Enhance: spine blocks manifest validation process Enhance: spine blocks manifest and spine public keys validation process Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant