Skip to content

Enhance: change Bitcoin address format & Add public key in Bitcoin signature #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sukrawidhyawan opened this issue Mar 13, 2020 · 0 comments · Fixed by #670
Closed

Enhance: change Bitcoin address format & Add public key in Bitcoin signature #659

sukrawidhyawan opened this issue Mar 13, 2020 · 0 comments · Fixed by #670
Labels
Milestone

Comments

@sukrawidhyawan
Copy link
Contributor

Description

Currently address getting from generate Bitcoin Account is the hex of public key(66 characters), It should be the address (34 characters) getting from the public key.
In Bitcoin signature will contain the public key of the sender to verify sender address and signature transaction

Breakdown

  • Change Bitcoin address format from hex of public key into commonly address that Bitcoin user use
  • Add public key into signature field when sender using the Bitcoin address

Expected behavior

A brief description of what you expected to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant