Skip to content

Bug: new node can't download blocks after starting from a snapshot #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iltoga opened this issue Mar 31, 2020 · 0 comments · Fixed by #719
Closed

Bug: new node can't download blocks after starting from a snapshot #718

iltoga opened this issue Mar 31, 2020 · 0 comments · Fixed by #719
Assignees
Labels
BUG Something isn't working

Comments

@iltoga
Copy link
Contributor

iltoga commented Mar 31, 2020

Description

Because of how the block validation works, new nodes that starts downloading a snapshot get stuck at some point and can't finish downloading the rest of main blocks.
As a solution we are going to include in a snapshot the 720 blocks (minRollBackHeight) previous to snapshotHeight.

Steps to reproduce

  1. run a node till generates a snapshot and let it smith some 10's more main blocks
  2. run a second node
  3. verify that the second node is not able to download all remaining blocks from first node

Expected behavior

A node should always be able to finish downloading main blocks

@iltoga iltoga added the BUG Something isn't working label Mar 31, 2020
@iltoga iltoga self-assigned this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant